From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>,
Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [Patch v2] mm/sparse: only sub-section aligned range would be populated
Date: Thu, 6 Aug 2020 09:29:36 +0200 [thread overview]
Message-ID: <1c817ced-8ad9-ce91-2992-94092bc065b3@redhat.com> (raw)
In-Reply-To: <20200805214955.ds7y3nwjoz2ms37h@master>
On 05.08.20 23:49, Wei Yang wrote:
> On Fri, Jul 03, 2020 at 11:18:28AM +0800, Wei Yang wrote:
>> There are two code path which invoke __populate_section_memmap()
>>
>> * sparse_init_nid()
>> * sparse_add_section()
>>
>> For both case, we are sure the memory range is sub-section aligned.
>>
>> * we pass PAGES_PER_SECTION to sparse_init_nid()
>> * we check range by check_pfn_span() before calling
>> sparse_add_section()
>>
>> Also, the counterpart of __populate_section_memmap(), we don't do such
>> calculation and check since the range is checked by check_pfn_span() in
>> __remove_pages().
>>
>> Clear the calculation and check to keep it simple and comply with its
>> counterpart.
>>
>> Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
>>
>
> Hi, Andrew,
>
> Is this one picked up?
I can spot it in -next via the -mm tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=68ad9becb23be14622e39ed36e5b0621a90a41d9
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-08-06 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 3:18 Wei Yang
2020-07-03 7:14 ` David Hildenbrand
2020-08-05 21:49 ` Wei Yang
2020-08-06 7:29 ` David Hildenbrand [this message]
2020-08-06 9:59 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c817ced-8ad9-ce91-2992-94092bc065b3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
--cc=richard.weiyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox