From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69400C5475B for ; Tue, 12 Mar 2024 02:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC0E06B013F; Mon, 11 Mar 2024 22:26:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C79936B0140; Mon, 11 Mar 2024 22:26:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B870F6B0141; Mon, 11 Mar 2024 22:26:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AA6586B013F for ; Mon, 11 Mar 2024 22:26:21 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45847120F3F for ; Tue, 12 Mar 2024 02:26:21 +0000 (UTC) X-FDA: 81886797762.11.CBFB5E0 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf23.hostedemail.com (Postfix) with ESMTP id 6153D140008 for ; Tue, 12 Mar 2024 02:26:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VOWFjIxO; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710210379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j8bXqps/luirsJ8RKYPi+CeFj7wz4+E9180FYv/b4Y4=; b=yGWjaeMIvTLDHdyiWwg1cl+baKo6Vz7RYoh4BywlcHhouv817agdfLS7tnn50LSKx8wlLW 6s+vMwz6L73VpjzzvWzHGGAz33DkYxzU+FQaRpUygpyRforVcmBfIhv5U+qtNjuWlZpy/r TeAnm2GYyFdv1otvqhSJDlY+sO6kLh0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VOWFjIxO; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710210379; a=rsa-sha256; cv=none; b=hNJKOlRu6JsUuadIYctA205l+jLeiyEAwr7sKR7ldD2j6mmbJtcJo4/SgiOP0Xeia87/S0 1qW8YjQZsckteW97hELXIZ1docCxa2PtJauj8TWwFokALS7wA6bx9yWgEMBvVkR4cDOto6 bsqjlS/LjF6fnJGTaT3bPHOq8lK07WM= Message-ID: <1c6f90d0-ef3a-4ea4-8de6-ad93c93ed3da@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710210377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j8bXqps/luirsJ8RKYPi+CeFj7wz4+E9180FYv/b4Y4=; b=VOWFjIxO+KLG+Y2DQgdeXdXmOQt01YCZZIl71j/ooGiYMy1/iZXvWcFbfBJ3i+d1Wb8kHL kxV/sKbb2G2BYvI7ZmvdKpeqasTVvfKLrva39nlG3UkkEX6yJ03kot/SC4l40PI7ABnp6t 6JmikJQvMbZGhNIdUJI7gmlC3ka1voY= Date: Tue, 12 Mar 2024 10:26:07 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v6 8/8] hugetlb: parallelize 1G hugetlb initialization Content-Language: en-US To: Daniel Jordan Cc: Andrew Morton , David Hildenbrand , David Rientjes , Muchun Song , Tim Chen , Steffen Klassert , Jane Chu , "Paul E . McKenney" , Randy Dunlap , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com References: <20240222140422.393911-1-gang.li@linux.dev> <20240222140422.393911-9-gang.li@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6153D140008 X-Stat-Signature: t4m5tuhqxxmmbtx5e5f5nkawg9czydyc X-Rspam-User: X-HE-Tag: 1710210379-826440 X-HE-Meta: U2FsdGVkX1+2RSV2ZNxyMdYTXeB6U0o/8cJmEXuCIfzX0PP92hlhcPkn8mTWzQVcvLFf/ePS2T97D2xe3Arcks8ZzMirMyxC5ZZSQU/qBWaMFCVcXhZgQeAzbqYGctIb/+4OHSdS+daLGEiJ86FhPb7StmgWvaN0FYd3ad8gW28Tp1rR6P0QgNQ+LGgAq1St3WdX9ftxmrFVqPgKCUbV+G5UjoDmVexdyOKoypVCDdnh88uI6wV1dy8bVSqtmzf5qndXapTUMQSHlPDwzTLYitKqEh0eshNaglzTfrGqkf8Nk89ZvTE8IL9/Vu4MnAtU4Aqsf5I/DnQ5uTUOGJt+zmXEUrMB2akgRxKi1u7ddVysXzikWTc1QOm4JJVpInjkvFOgQU6+AYExzxMH17PyxS+ajvrpqMXP/b6ycvy29X6bwAwS365q+qJI2GaLuHaBa6pUkYl8ps3EVBd84tNOb+z+R26uY4hhiQmg/pSCiR7wgtvG2Lov5BdMjQvggaxD03roqHoWDqA4UR/MVC7oolKdfyOC0yZFd1OHSLi/M5brsdLbZXl+S75cbXSCd9HL9Aw7AbJWkAdi0J5nRLwDyugyT7K81aF4mS58Vtw6bB30OAGOYxabwUtqOazArfUbkUo+7qVwySJoeaL3DxqBfqn8OITlil86czQ40k3c6McTbzOhWl3AS/uttD6VF6XMnFevgxr6oFNbxiYEwVU/vebX489HLi8/R8fw/UwqTwkMxdHY1xBMXexgf4wQRZfMgGMk6feZpmfRl2qrRYtmb6iE7Y7yi6qkTAZh0mOCsak0VLfKPz8PHCG9v5TBsdcL76hd2P/3bMSfkR9VX3IWHuiFvtSrXEb/7q8Lx4Jqhxk3HdiEuYfOXhBHIioQQjd9PSWfayB2egX4ycg4TfAC3Mfw/Y4HZtp5riow4IY6ZacX+AkWXH5mtqI986EPx5D1FsjmyRtnEKVvkeru3cB V1ct3CH4 QjwAlrc4HQGPZAigu/BlCORS7EYU/mxrXX90aGIkr6DvqooWAG9M9IIV006oZcJKGoW2pnt9tqbOhux29ueZqP0zQZHbk1QyTxNS9y3c1P1YmzH4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for your review :) On 2024/3/9 01:35, Daniel Jordan wrote: > On Thu, Feb 22, 2024 at 10:04:21PM +0800, Gang Li wrote: >> Optimizing the initialization speed of 1G huge pages through >> parallelization. >> >> 1G hugetlbs are allocated from bootmem, a process that is already >> very fast and does not currently require optimization. Therefore, >> we focus on parallelizing only the initialization phase in >> `gather_bootmem_prealloc`. >> >> Here are some test results: >> test case no patch(ms) patched(ms) saved >> ------------------- -------------- ------------- -------- >> 256c2T(4 node) 1G 4745 2024 57.34% >> 128c1T(2 node) 1G 3358 1712 49.02% >> 12T 1G 77000 18300 76.23% > > Another great improvement. > >> +static void __init gather_bootmem_prealloc_parallel(unsigned long start, >> + unsigned long end, void *arg) >> +{ >> + int nid; >> + >> + for (nid = start; nid < end; nid++) >> + gather_bootmem_prealloc_node(nid); >> +} >> + >> +static void __init gather_bootmem_prealloc(void) >> +{ >> + struct padata_mt_job job = { >> + .thread_fn = gather_bootmem_prealloc_parallel, >> + .fn_arg = NULL, >> + .start = 0, >> + .size = num_node_state(N_MEMORY), >> + .align = 1, >> + .min_chunk = 1, >> + .max_threads = num_node_state(N_MEMORY), >> + .numa_aware = true, >> + }; >> + >> + padata_do_multithreaded(&job); >> +} > > Looks fine from the padata side. > > Acked-by: Daniel Jordan # padata