From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C41FC54F30 for ; Tue, 27 May 2025 08:54:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B5336B0092; Tue, 27 May 2025 04:54:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38C3C6B0099; Tue, 27 May 2025 04:54:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A1FA6B009D; Tue, 27 May 2025 04:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07F636B0092 for ; Tue, 27 May 2025 04:54:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 68E5C120431 for ; Tue, 27 May 2025 08:54:10 +0000 (UTC) X-FDA: 83488075860.28.8111BC5 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf28.hostedemail.com (Postfix) with ESMTP id 160ACC0002 for ; Tue, 27 May 2025 08:54:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="CTIcv/SD"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.198.163.15) smtp.mailfrom=binbin.wu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748336048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZMf/WoV2AXoFbb8R9icFcZXfscy79zCS2X5V3ybu05Y=; b=7kBvf4HoY2ZEdtZRxVewqxyz8RUdx8OTyPwZ/zEP/1t1j+m9jrnyXUhA3n+8VfTSo9kTgJ FMk3KrOVbm6fS20Q7U+qEEf8trjpXwn0EkOVvYzZlzJgNfiDB4qqhFBLRwWEAED2LAtaVK vOu/dNob+CcJgh+GRNlUfhA6W4omTPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748336048; a=rsa-sha256; cv=none; b=rGKcpky1qPveILvFdnjlIgutf3nGXfxXG2JGbZi82k+ImhBQlCpCU3extKTS4A3YiYejn4 sN8QEMz0N8l/uPwQ98diBO6oftYx9jpMhpmj1k7IzgYYeVgsM4CEKM5eBRO5WEB1kcr/bX uiH6djxednphUoTzPYnUUpZWtOGWhxI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="CTIcv/SD"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.198.163.15) smtp.mailfrom=binbin.wu@linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748336048; x=1779872048; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ahN1juhOBybAptIvDNG/Uw4hA0zokWa6fSCXBMIa8ZQ=; b=CTIcv/SDq8zlaAavWxcwQHjW5YUFQHaDdmtQkqgiLfypcQlkCZwzi84+ qOMe4jedZocBiqi6uhz5FXgw9iVeOcVipiXoMxI3bdg1fElOZ9ueAJpK4 GYH0YCeCZp1WFtKPTFrJdQSOItjrK7cVhRzAkV2BZaT9bH8Wae1sgTvCX Ejo68UBMfEqY5OkTr+GIVvaLA2Kf9oOkyuyWehrjoTpvcelYGKArDcRJe K47B/XAmq0sPJo/qB37HNagRrLZbgdCvabU+Of0rtNdqYvF3Mt0LstEfs XmrK8DvDTtRGEu1CevhksKxhsb+qJQ8DwnoHVdsiDGN3R7yD7+2zGelvN Q==; X-CSE-ConnectionGUID: TLAvr8VgQtKOeJ0OmgjO9g== X-CSE-MsgGUID: hRIT2a5ER/WzRUZ1KflF9g== X-IronPort-AV: E=McAfee;i="6700,10204,11445"; a="50473939" X-IronPort-AV: E=Sophos;i="6.15,317,1739865600"; d="scan'208";a="50473939" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2025 01:54:06 -0700 X-CSE-ConnectionGUID: DJWU2wIBQVGR2iHz4Ab5dQ== X-CSE-MsgGUID: mwknysU4Q3qMo9InnvRemg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,317,1739865600"; d="scan'208";a="142717170" Received: from unknown (HELO [10.238.11.3]) ([10.238.11.3]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2025 01:53:47 -0700 Message-ID: <1c5cfc23-3f63-404d-a4bf-030c24412b20@linux.intel.com> Date: Tue, 27 May 2025 16:53:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 03/51] KVM: selftests: Update guest_memfd_test for INIT_PRIVATE flag To: Ackerley Tng , Ira Weiny Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com References: <65afac3b13851c442c72652904db6d5755299615.1747264138.git.ackerleytng@google.com> <6825f0f3ac8a7_337c392942d@iweiny-mobl.notmuch> Content-Language: en-US From: Binbin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 160ACC0002 X-Stat-Signature: px78kuwayi1reycp5mhageaqpq7w3zoz X-Rspam-User: X-HE-Tag: 1748336047-846548 X-HE-Meta: U2FsdGVkX18mfwWCRY4gTBTF4OSIsE6LVMSzidcq1xCsbmyVFuL4puBvoBce2sGVDJwqnTLsrlLShziL2Qz+9AlwdbzNolldj6808X2d+AaRH6hO0dD4Qxn+OhhlRexkt4nyd+TUHgI1Whec++devxiFgsQp/PmKRQXwf/uyFiTyNimdzrRVv/NNkwcdwcBx5p8HZYHltURRQRKlcUHGwMYNoiYGwsqZrU16v1Ws/FQfNJyJDC1V3LvkhWKAiSPJlWZ1yE0bxmLPcrVzS52eq5mdsfQbi0V9422gnTktIuLlAYQddgXvT2qaOen53PYtyxX+bHOpQlEk1m06yNAnvW/JXzvJ/hou0XiJB4qttGQKSPXFILGeonTL1SmiyBPkQsSB7JRhaZAEnQ5RYANnkLSw/nB7jmpTqlAdR2DRpIrFYQrG0Tdbf3KYfKPHL0KZdkVicztkl/Ln0t2b9nsSFftyOCxqfXlUNVj3JGjw6iyHpoRSgmgAkQf2c8y+Ej/ZLrlwMpUgxpAYXfwKlue/B8tdfinaJaMz2qpArrP4GREMZO1smi6AcBEu/BwDvmR2iRCp3TZT/Unxh62ECJaaGG9SA1Tf5yqMPUrdoAjdHLTBDOpGNCgnYwVGrW18qKhzuAcMPZv7SnsyJHRK8zm9T+JsGPnmwIWSp70xZitWlsJN/0vzfXicl4npN2k3cLpUUyoGcYJoDQSUlTQynqflO6RegzIFrHbr1rLdGLPNjlqd9tndOJpQZdYcO26rjdNHoWCGBPGuwdJhj+aZ5lF7uU51XFZDGXHBuOy1HwEz3BmIpkXaSbgV6J5TrahzDaQtE2uJWPrQJtYyjRK4MeTk3TbPbjOKGYO6tw1pQncGahjZYvc6eXdolEywWfmzKQgTjgnF3nEYbiQqGDQS3XSGlqpDM6869H3dp0q3c1WU9IMzKislWKThuGehwcadxqRtEZvBYZK91zJ6LNspvd1 bwEKt2Y3 5BvGrXIYMVmxFCeZWhy2tDGvZHyjREc6HBFemIZq3VAVtSbLPm6BhtTh4/+Lqn79fr66mV9RO6TUIazqK8pGJu6bnR4BZPW5ywTwRjBxwv4Zi5U4ClQjqskCWhnN3yfPthYBb1nIZCsxkVr2a/T88GCgDa6zI47aNsmTtrrXo2LZVbKD8VeJ4Pv87xA63dktMtd4SkaQ3hUbuzOwHCa/z9XGh1xqBFlzXbwugnsdG+3oSHTn7+1LyV4+2C7CxqIwZfPLXEcViJf6HVaHtMglTyxv3+qq0S+VKJ3wHSdT3vHKuwrfQ3qiv5n4c2Efi4AExgW2eleW5EAQRzStZscwZ9RpHbC9IW0SpQiaMNkQ1XBX3B9jIy+Weh6NDgeUpExXx3k3xr4r6sgoKfJ1RhPqRxr1iZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/17/2025 1:42 AM, Ackerley Tng wrote: > Ira Weiny writes: > >> Ackerley Tng wrote: >>> Test that GUEST_MEMFD_FLAG_INIT_PRIVATE is only valid when >>> GUEST_MEMFD_FLAG_SUPPORT_SHARED is set. >>> >>> Change-Id: I506e236a232047cfaee17bcaed02ee14c8d25bbb >>> Signed-off-by: Ackerley Tng >>> --- >>> .../testing/selftests/kvm/guest_memfd_test.c | 36 ++++++++++++------- >>> 1 file changed, 24 insertions(+), 12 deletions(-) >>> >>> diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c >>> index 60aaba5808a5..bf2876cbd711 100644 >>> --- a/tools/testing/selftests/kvm/guest_memfd_test.c >>> +++ b/tools/testing/selftests/kvm/guest_memfd_test.c >>> @@ -401,13 +401,31 @@ static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, >>> kvm_vm_release(vm); >>> } >>> >>> +static void test_vm_with_gmem_flag(struct kvm_vm *vm, uint64_t flag, >>> + bool expect_valid) >>> +{ >>> + size_t page_size = getpagesize(); >>> + int fd; >>> + >>> + fd = __vm_create_guest_memfd(vm, page_size, flag); >>> + >>> + if (expect_valid) { >>> + TEST_ASSERT(fd > 0, >>> + "guest_memfd() with flag '0x%lx' should be valid", >>> + flag); >>> + close(fd); >>> + } else { >>> + TEST_ASSERT(fd == -1 && errno == EINVAL, >>> + "guest_memfd() with flag '0x%lx' should fail with EINVAL", >>> + flag); >>> + } >>> +} >>> + >>> static void test_vm_type_gmem_flag_validity(unsigned long vm_type, >>> uint64_t expected_valid_flags) >>> { >>> - size_t page_size = getpagesize(); >>> struct kvm_vm *vm; >>> uint64_t flag = 0; >>> - int fd; >>> >>> if (!(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) >>> return; >>> @@ -415,17 +433,11 @@ static void test_vm_type_gmem_flag_validity(unsigned long vm_type, >>> vm = vm_create_barebones_type(vm_type); >>> >>> for (flag = BIT(0); flag; flag <<= 1) { >>> - fd = __vm_create_guest_memfd(vm, page_size, flag); >>> + test_vm_with_gmem_flag(vm, flag, flag & expected_valid_flags); >>> >>> - if (flag & expected_valid_flags) { >>> - TEST_ASSERT(fd > 0, >>> - "guest_memfd() with flag '0x%lx' should be valid", >>> - flag); >>> - close(fd); >>> - } else { >>> - TEST_ASSERT(fd == -1 && errno == EINVAL, >>> - "guest_memfd() with flag '0x%lx' should fail with EINVAL", >>> - flag); >>> + if (flag == GUEST_MEMFD_FLAG_SUPPORT_SHARED) { >>> + test_vm_with_gmem_flag( >>> + vm, flag | GUEST_MEMFD_FLAG_INIT_PRIVATE, true); >> I don't understand the point of this check. In 2/51 we set >> GUEST_MEMFD_FLAG_INIT_PRIVATE when GUEST_MEMFD_FLAG_SUPPORT_SHARED is set. >> >> When can this check ever fail? >> >> Ira > In 02/51, GUEST_MEMFD_FLAG_INIT_PRIVATE is not set by default, > GUEST_MEMFD_FLAG_INIT_PRIVATE is set as one of the valid_flags. > > The intention is that GUEST_MEMFD_FLAG_INIT_PRIVATE is only valid if > GUEST_MEMFD_FLAG_SUPPORT_SHARED is requested by userspace. > > In this test, the earlier part before the if block calls > test_vm_with_gmem_flag() all valid flags, and that already tests > GUEST_MEMFD_FLAG_SUPPORT_SHARED individually. > > Specifically if GUEST_MEMFD_FLAG_SUPPORT_SHARED is set, this if block > adds a test for when both GUEST_MEMFD_FLAG_SUPPORT_SHARED and > GUEST_MEMFD_FLAG_INIT_PRIVATE are set, and sets that expect_valid is > true. Maybe it's more clear to move this case out of the loop? > > This second test doesn't fail, it is meant to check that the kernel > allows the pair of flags to be set. Hope that makes sense.