From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ABF8C433EF for ; Mon, 11 Jul 2022 22:50:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D04C7940024; Mon, 11 Jul 2022 18:50:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB4E3940010; Mon, 11 Jul 2022 18:50:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3BE940024; Mon, 11 Jul 2022 18:50:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A6EFF940010 for ; Mon, 11 Jul 2022 18:50:27 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7284334200 for ; Mon, 11 Jul 2022 22:50:27 +0000 (UTC) X-FDA: 79676314494.31.0FBA0F0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 02F8220030 for ; Mon, 11 Jul 2022 22:50:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8F52612BC; Mon, 11 Jul 2022 22:50:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D0FDC34115; Mon, 11 Jul 2022 22:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657579825; bh=2Gu+t/Fulb4KZh2OM3NDzpYPsvdLLj3c4PEsBwp7qxg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lc3WlFtsehEk/R/e6sfX0z7Izzgsycg7DmRqJGiPEr/ohSe9cslxuKc69opAXEhOG INAhfEguVDmg6C1T02LTglJungdVskKIYManfQWUkaTgLmKxcvu42m7ral/GETDG4K lcSy/AN9WoHog2dOTv/weYIYqAJNoAkwvmd/ER9dyeiAIUQ+49mot0vMdqhG2/IU8f /iJTjT0mar4UBStbUpOtIqKF4HUFCxgB3nTcuZV/Bz5fEBnCkD1W66CaaU5cixBC3T cz6ziocAKl18kFFYj6PJ098j1k+14tjk6E3V/NUtC2Ko3T3pQ8N+pIrSQmfWqz6/yP YfbiBxx7+zAqQ== Message-ID: <1c58c7e1-2c21-e0d2-34c7-252074ecc70d@kernel.org> Date: Mon, 11 Jul 2022 15:50:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done Content-Language: en-US To: Nadav Amit , linux-kernel@vger.kernel.org, Thomas Gleixner , Dave Hansen Cc: Ingo Molnar , Borislav Petkov , x86@kernel.org, Linux MM , Nadav Amit , Peter Zijlstra References: <20220710233355.4066-1-namit@vmware.com> From: Andy Lutomirski In-Reply-To: <20220710233355.4066-1-namit@vmware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657579827; a=rsa-sha256; cv=none; b=P093fa44YIJDkCzWgbJeKMAl12Lg5mMlnJP7RUVWeDId2YmExBkC+lOuYZ4K20Y1jT2Owd KK/YtwBdBVG1W2mfWm5zFdXTe2RsJkJ+HqRZZ60ZcXrTLgPE3Hdnd94jbymp3VcRsE4l8D NSIpd+WTCZvjG5QP3uSKp8rJ9NwHR8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657579827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WyNUjaij+RrlT2ZyeehpgLcH0q61JSMADhZEaNZjcqg=; b=3kQ61LLmAONeu7KS6wx4ln9nusKaRUY1F5Z7kQ2OT/1a8aABxnarMtGLY5ZfGGfCgXfg6z lzKtJ3U7U/x2NEj7+AG9hknFNxUiZf/DNL0ZTB3blR6XHGT0K5lbjA6aPnk2dvZ/C0JL9E ypEzRxnld7z5XaMogFYTfWGXIzSQsGY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lc3WlFts; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of luto@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=luto@kernel.org Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lc3WlFts; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of luto@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=luto@kernel.org X-Rspamd-Server: rspam03 X-Stat-Signature: bqr6ubjssjfdtgeyto98j4prfwnmaefw X-Rspamd-Queue-Id: 02F8220030 X-Rspam-User: X-HE-Tag: 1657579826-692994 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/10/22 16:33, Nadav Amit wrote: > From: Nadav Amit > > Currently, if flush_tlb_func() does not flush for some reason, the > tracing of the flush will be done only in certain cases, depending on > the reason of the flush. Be consistent and just do not trace in all > cases when the flush was eventually not done. > > Suggested-by: Dave Hansen > Cc: Peter Zijlstra (Intel) > Cc: Andy Lutomirski > Signed-off-by: Nadav Amit Can you remove this comment, too? > /* Tracing is done in a unified manner to reduce the code size */ > -done: > trace_tlb_flush(!local ? TLB_REMOTE_SHOOTDOWN : > (f->mm == NULL) ? TLB_LOCAL_SHOOTDOWN : > TLB_LOCAL_MM_SHOOTDOWN,