From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A9AEB64DA for ; Thu, 20 Jul 2023 15:46:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01900280127; Thu, 20 Jul 2023 11:46:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0A7528004C; Thu, 20 Jul 2023 11:46:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAC1E280127; Thu, 20 Jul 2023 11:46:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA81028004C for ; Thu, 20 Jul 2023 11:46:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A5097140166 for ; Thu, 20 Jul 2023 15:46:38 +0000 (UTC) X-FDA: 81032417676.05.CA71811 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf19.hostedemail.com (Postfix) with ESMTP id A99281A0004 for ; Thu, 20 Jul 2023 15:46:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gdaRnsbf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TR2K2P18; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf19.hostedemail.com: domain of hare@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689867996; a=rsa-sha256; cv=none; b=vXKalyLfdgimlcegSRLwDIki7UwXEc/ydHrZLxzswHJWiSPAxw4orN7b3mREN1EsyE8ll2 laENLvK7EOv8BQO+bw3VbD4/howsLoDsvaN8iLWPoT3yWVp6t6VivCTazEURJ/rMBBtjvk H0QnnAP25v+u+/OG5U1YsOzO46mUWJc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gdaRnsbf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TR2K2P18; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf19.hostedemail.com: domain of hare@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689867996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yLwu76gRWU/gtJLigWATvmyIiImBcDcslavNxHnggBg=; b=A7ksZ8dEmH6+9TDBDTDVA4NkwtHkWtbCgICwVXIpqpbGt2cKGrmP6JUGkrYSS935oLHNUz YEAYhJ6jqGIgeW6qUOG81krhy+5lwOfxkmLcbfF/sTuzM/R6t1D9CRpM/7DPJdEAzgkxfj XluKzTmyRTisK4NdkEr3s72lbZCn5Uw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 631691F8CD; Thu, 20 Jul 2023 15:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689867995; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yLwu76gRWU/gtJLigWATvmyIiImBcDcslavNxHnggBg=; b=gdaRnsbftK/DowJQCbRChuyD9QH/21GNn10b/CV+6b0py3A89FpuSfiennIbi+fnWY5U8W rG1SUWIxvhjg49kP8cNxq/FxvOCglXuWDq98519gtyZI/Y+F05lA6aJh6kFGWhaePrHuZX FtUNerKtilfBq/hjQsaY9d9FZPEtm7o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689867995; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yLwu76gRWU/gtJLigWATvmyIiImBcDcslavNxHnggBg=; b=TR2K2P18PUKBn8mkobycPVfaIxQMgfsN37E5cFDGRQbhk9eASePSCA4mc07lQ4LT4PcdQ5 bM9FaCd9T5HcI1Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F1EA8133DD; Thu, 20 Jul 2023 15:46:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pr3qNtpWuWR1IQAAMHmgww (envelope-from ); Thu, 20 Jul 2023 15:46:34 +0000 Message-ID: <1c326210-f8a8-79ba-45e8-69ce6a86d2b3@suse.de> Date: Thu, 20 Jul 2023 17:46:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 4/6] block: stop setting ->direct_IO Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230720140452.63817-1-hch@lst.de> <20230720140452.63817-5-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230720140452.63817-5-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A99281A0004 X-Stat-Signature: yyynt69i7qk5q7tqzd5ynrio5pobmrxk X-HE-Tag: 1689867996-439615 X-HE-Meta: U2FsdGVkX18l0zAgbx74BHfgPxMNspOnTTCHX04MTYaTH3c2MVfGHlqHttIsachENZw9h4aU6cTamPwkRwa5Y9uJGnd+3vt1fGgwDJK9DYmFxnTBNw5e2W/j5p4K4eZP2mjduY45WtP3VbaPEYSGcvb/7wuzzJJAbMdF6wOXw6EmcdmnoJG/wMZQ5VEFuPvH4GkRxpXYX64WOebJ/n2DTJzwsFwlmfttoNDm7hyJQGG1PD22u66A8/c+7pdbxagXDUOmNG5Zx/yMuhx69wLDRtAPUTGgDbr18PcFljkgQUfn+taa+EVEyfN02ZpnZF9gifP9B+HYGFkJhxi8FxzrCQy8NfU3l5jcfUuI+LQSIUpBU41T853ynK7/eTGbxq5nTBFd6lHznTMeL1N9hTPTrEhB3lWjYAwBiKru6iabCCYS8NJ4iLEvtqQytjrNe2x9hSCDXVc1h2UlEmeADV0/v7tsJ01LbxXxbNVGPKfYtzqYhq7vDZcCkOHvw+lTWm85a26UUUt/3LhntjwpgjDdwfSlZjT3c47F8rGzL9+9iKMTVfvoe6EFvIETHOtVLb1zTzd86/3BHOeK9h+Tqi99rLq62h2PeHUew1JQpxBTMgVbyhuH3dpBr94PXR9VxxVuA3fUjeFtJwcF6caYCQWR368trU/OVaqXN51rELrtzaaJG0rHJPAVoZe5EZ35Feek2Lcki/bT22QtFH4XoOnCUSMPsCzlyR34qvdjsMW0gNzHDRDQ6hgHRQRkcRXrCROeXIvc2Flblv0JX+6MI1fg0PSTdGZiaGNLgwm1g4tJPjyd+0pIFFxDvppVc/IDxThooNBEzye7mz1mn/o2s/PygSY/heOO7mBgsMQzdTxDgCa9og8BF8YSHYPzZCQT2vrIYZOuHU0wUtP7Qkcdahtr1ib6qdZ7zc9HLkNj/NGFkFXp9SdB1KNTKBdM4ybzTs128gHV5GvaauYLDIaz/Db MMf/t+a6 YsXdoIuy9OiugrwayKR6E4BFieMk6iNV/Wn68oJo8eNgiK2lWG4ufBi9iq3QDzFoSZUAe3LkOqHMuXCs6Pk8xYKNUFU3IkvNorI+/ycZW71i4jK4/vKydKNOKzBziHZ9TOg14uxXspSpXDNAmqTbeqy3qkJ/zJirZYqL5Q1bOe24W0lr9GZhAWSmtk8VGv8IRLm20HV5rR4IBNhj7YeqK7UEOeAMsnhthVGOSJDBw38Gy6L7aQH8qRCuLWiUZW2Lv4hkPozWWvlC9/8I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/20/23 16:04, Christoph Hellwig wrote: > Direct I/O on block devices now nevers goes through aops->direct_IO. > Stop setting it and set the FMODE_CAN_ODIRECT in ->open instead. > > Signed-off-by: Christoph Hellwig > --- > block/fops.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman