From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE8DEB64DC for ; Sun, 25 Jun 2023 04:04:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA3D48D0002; Sun, 25 Jun 2023 00:04:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E53BC8D0001; Sun, 25 Jun 2023 00:04:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D428F8D0002; Sun, 25 Jun 2023 00:04:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C42528D0001 for ; Sun, 25 Jun 2023 00:04:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9053040909 for ; Sun, 25 Jun 2023 04:04:44 +0000 (UTC) X-FDA: 80939928888.05.07BF36D Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf21.hostedemail.com (Postfix) with ESMTP id A44CC1C0009 for ; Sun, 25 Jun 2023 04:04:41 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XCFH2esE; spf=pass (imf21.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687665882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KLYEE95h8dfs8ybeBu3uzI6jcL58MXhesvKSmBarnZc=; b=e/y5V256fDXHJHztNCjaRGz+a+Lmdt4godfBdAklTX4JIQi8VvMoc5ORyMI9RO1JTxrLMs vjOY4Wvm6SyO3SWEBKzlV8AIYvPjj7sk/OxkPAzDrbtBDD7avcAQ2gTtiqtK9ohFbv5dFd 64ixwUwZ4e+TlM+AEu9bSyCdfOSpnTY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687665882; a=rsa-sha256; cv=none; b=pLtfParcbTdZfcDyB3YZOYRY5K8xGes5MX8C8DKXn2z859bmWBpQ9cH+rF7oN6zPIdMeaa Km9XNPYpDOMoLrb5WGXwoFg9hWR2/E31xnfGV7c4UmOgFMiMVrCdvvLavcTiFEwCqjGIvg w/LoAH7ewAcyB7LTUhS3xmeMtolIRYI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XCFH2esE; spf=pass (imf21.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1b7f223994fso4667815ad.3 for ; Sat, 24 Jun 2023 21:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687665880; x=1690257880; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KLYEE95h8dfs8ybeBu3uzI6jcL58MXhesvKSmBarnZc=; b=XCFH2esEI44BmGIvxFS9RZBf6xAFLp++eoTJOz+383WetmcWQdA8L+ABRvpbCxxoFG rh0Pz45cOMGW6bOiCCWdR7Rrn43oGmS+qITFZUzfB3ouORvyjagC+7oj1RjahlWN7zF4 ROAdDX4TvwprD/Eblsks4vcL/6dF8ZCSEwbKARKi2e+LLR9OnCZwUfrki3irQNckUWyj VZqwbU2khR6MivWz/BmLTAjuUn6lUaYBfWN0GfdaZqGrBjUItuFGNLL8x29BhvgjA7jS CO4tMwRlgwg/EZz0L9hMmt6cnJ0SwwFP5oXHBDEim9TQoNTI0ORcU1Aa6f4LHlO4oXeW Hmmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687665880; x=1690257880; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KLYEE95h8dfs8ybeBu3uzI6jcL58MXhesvKSmBarnZc=; b=ao5s+msURNoNLLAhcLOQKVsIiOVYBevfCSP0VtKP/2gWUs4S3nn9rkvJQ2glE1E/IU WwWrs6mqF3ZmafWVyYASRYUA9b9o20ePup22qM/hHJn8FuEHH1NMwQSeVRigC65/2V7w Yd8D6/YJlc4qby+1i04bX30t/O4b1jHEa8/JC0Q74MXhFAm2+P66gJqeOahfHaC7SjU5 OiD0r3HN8x7FWADc8hHxivUEvaw7M8hZlUrH3104KUz0P0W8rToky6VrcQMiHiuxypL8 TiwOkkekTp5F04WlhTA0RZ0eKf6tNcw1BeGuOMN9466gUUkGP+09lVryc7k9kFPBP4IU 8/XQ== X-Gm-Message-State: AC+VfDwv/jMbYavHOrTLVCr71aL0A83l0fbPm4+X0oIIZ+5JCdyDo0se P7Bjh5BA91LcXIFeJhzWRrhDdw== X-Google-Smtp-Source: ACHHUZ7/AQXQTv0DowtVUwuM8z36C5q7DKfIwWqjl7D2Vin04YsC7Zfb8EsdqfJWteI+OtIsID3KHA== X-Received: by 2002:a17:903:22d0:b0:1b0:5c0a:3f80 with SMTP id y16-20020a17090322d000b001b05c0a3f80mr4326175plg.44.1687665880307; Sat, 24 Jun 2023 21:04:40 -0700 (PDT) Received: from [10.255.209.141] ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id k9-20020a170902760900b001b54a88e6adsm1788065pll.309.2023.06.24.21.04.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 21:04:39 -0700 (PDT) Message-ID: <1c0c3915-99d2-f75c-027a-70a1321b4662@bytedance.com> Date: Sun, 25 Jun 2023 12:04:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3 0/4] Optimize the fast path of mas_store() To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, Liam.Howlett@oracle.com References: <20230615084301.97701-1-zhangpeng.00@bytedance.com> From: Peng Zhang In-Reply-To: <20230615084301.97701-1-zhangpeng.00@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A44CC1C0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: n46ra3ymi5xptxyptxmadfyattsowo3q X-HE-Tag: 1687665881-60273 X-HE-Meta: U2FsdGVkX18Z3ANbZ9gAT4xtZgvqmmHNSEh0MyMRmkeW1WlixEaJq0PoDeEJTyHDc1kidp7RcBbuB0w+db+WUPc34djuxL7jfT2dFge1fLJ52iTXLiyIhrpxgwUtGuHjAfNEPziA8/y8QdtpjZueA8rUYS0xXsrAV5wIqPVu3Zlh3FaQZsw4JgVz+6Azct2dJaoknmLX+2orOPM0wHLWoCg2FFPPW7LGKdiPVVx1HANsgT5YZFi2s3twWDTul3wk5jtRDM3y+4pFeLNeM0iXkMu8UPM2tFxys5YtC/+1JSJtkzerckNwSIsLbqDVccSBo+7uXb0aEy7bfyGrxAzI+4ROxDaUbxNZsHIvJPJPGmbWtUUvgK9sugUvpQ/bD86HTGoIt/5t7Xm2sGVaS/IQo86jVM7/uggaVQF2jiuVrhP3HZ3zKiH1pXycjP5Ji5ALo5B7L5T/l3HzHGqakL4hHHI4an4JnjQhWN3OjnpHiBy+LMuf+19FM1p+IpK03TBWhStLjsvnH7YvDBeuN0x0LIUK/Oat6K2YtBQuUZRLpB8gCJZiv1A/NwyyTYjab0i+DNkDmtqS2sPi1ko74a/CBH6fjRwbUtlE4g34YVokz4HVsumysCpI/IwZXO34q3X26D0zBcto7nvSGVlGFwW4SaIkxAojLjeIPZmf30pF5PGOOLjoDsUmWUSfh/V/f0aNkaNjBJ4QUdOEvkOX/U6Ze9UPXyrRYMNbBUA3chPqJL5EJ/+EcSrRKK3ilVSosQpdVu+gM/nBbusxum4Vz4NsnsnEw2e1ED0xr7CLv6E2hbuPONqiPS45cQY0iklaCOi1jprJDA4IaGUAeGBCdhNlS+57CsJuh3n3CISGQNapYWeHP4gP0KdY2pIUSreD3aqUl+aMB2pk7S0FgmidaLcIpbaYR1Hu1q9TMYMmxCWaVI5nf8JKsZu7awNUE8kH8Dmd7QrmvOJs0Flq0f4+A0C TXXJiUAY VAI4vNT2x4810K0ZbPjDMyz8AfHBRssbICkgHepnqveH+8QeTShumQ5o4sHW+nQptZcpD7pntTPKmFjaIpJdgz+z0y6q6HbFefYG9fXmNSuSnlxHLdItyxLao2Ms2gqxt3kZt34H0aUJ2hM9Iq0013skF1W9nlMXQWDNO1jK49G4LtSzxQ8xHaYyqlVu/t1/kNTLuJ1M+GS1yn5XBHMEamP7loUn3ezuEtbc5BwPlTQQtMdOoHNd+y6ffshn1D2oD3PKCuckNpGdwyUn2tK5tGhQjZyyD48QJRsQRYpeB/xm/dr9taPhgZ4zG9VY/ha9hKetYXJWXHqV8jXCgml28gzwvYpkFJqyk/7PLaWuH8LFEy789o84XTD2vAGt+zxlCRhigQrLzXSe4yY6jykg8MJR4l7bEmcX84dv1XSBpcZN2hppfeQ/bK0jYKe5S+PU5LZxQ7RDd6xQZ9eq1GNhENAw38S+2TVCZps8HUcG1x1q8/L1RhJtOce3CJtuSdXFQh4E5DsGNjcuBYvjqTk0XAwIyHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/6/15 16:42, Peng Zhang 写道: > Add fast paths for mas_wr_append() and mas_wr_slot_store() respectively. > The newly added fast path of mas_wr_append() is used in fork() and how > much it benefits fork() depends on how many VMAs are duplicated. > > Changes since v2: > - Add test for expanding range in RCU mode. [2/4] > > v1: https://lore.kernel.org/lkml/20230602075353.5917-1-zhangpeng.00@bytedance.com/ > v2: https://lore.kernel.org/lkml/20230609120347.63936-1-zhangpeng.00@bytedance.com/ > > Peng Zhang (4): > maple_tree: add test for mas_wr_modify() fast path > maple_tree: add test for expanding range in RCU mode > maple_tree: optimize mas_wr_append(), also improve duplicating VMAs > maple_tree: add a fast path case in mas_wr_slot_store() > > lib/maple_tree.c | 69 +++++++++++++++++++---------- > lib/test_maple_tree.c | 65 +++++++++++++++++++++++++++ > tools/testing/radix-tree/maple.c | 75 ++++++++++++++++++++++++++++++++ > 3 files changed, 186 insertions(+), 23 deletions(-) > Hi Andrew, I think this patchset can be queued for testing. Both v2 and v3 just update the test code.