From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B82E77188 for ; Fri, 20 Dec 2024 09:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD4A26B007B; Fri, 20 Dec 2024 04:03:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B843E6B0083; Fri, 20 Dec 2024 04:03:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C4016B0085; Fri, 20 Dec 2024 04:03:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 689776B007B for ; Fri, 20 Dec 2024 04:03:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0E396807F2 for ; Fri, 20 Dec 2024 09:03:55 +0000 (UTC) X-FDA: 82914748434.19.B184E5B Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.6]) by imf13.hostedemail.com (Postfix) with ESMTP id 054F720003 for ; Fri, 20 Dec 2024 09:03:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b="LMxBIfQ/"; dmarc=pass (policy=none) header.from=126.com; spf=pass (imf13.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.6 as permitted sender) smtp.mailfrom=yangge1116@126.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734685401; a=rsa-sha256; cv=none; b=YYufhShJx4OmVfqlJakUuakeJPZqjb9Dmr+raOBmURriuN6DXDpuK36We9D1ViKpAsgAUE RLqH5tABDOHfHzwUlV18fjcSaFf19fyUgqYQ1fR8TWkmrPYwRq/gMnBRE2RmlftK4NcQha ldOPdFb8LslPoBHni9StPE6IVCnipMQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b="LMxBIfQ/"; dmarc=pass (policy=none) header.from=126.com; spf=pass (imf13.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.6 as permitted sender) smtp.mailfrom=yangge1116@126.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734685401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2tfd3OeQZhvI5s/uqg7ObNyfdEbgcw00VOEf8s5Q39Y=; b=O7PNmhtln5n9VdA+fbxD+1rwmplduCKidYKb4Nm8voiig6g2fZpCUI1VvNMri3NIPLd35n /LFUg51uJou25hbEEWKfRLxezj1FG0vDRVRl0Ejj9xp5DcP9bAaIYVUPj6Ps+/8hSWABu8 S+wQwbvo4TPAYfjzeYOVo2m99ZYOq50= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:From: Content-Type; bh=2tfd3OeQZhvI5s/uqg7ObNyfdEbgcw00VOEf8s5Q39Y=; b=LMxBIfQ/6s5HdH5tuYLCTk50lSZueaxbNM8GuKaOMTxzX44ZLRw95DYT+imuju OVV0HQ+mNX3BXLUtCfXHsyo6B/WSpT/Cs6b57KpoDKvJGY85YHdK164y32OVniRi 5WHilgR0V1U7V49CBOIZyR7k4TzTJt0GYqhUJyOZP7Mmc= Received: from [172.20.10.3] (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wD3H3nhMmVnd+hkAA--.65229S2; Fri, 20 Dec 2024 17:03:30 +0800 (CST) Message-ID: <1c05db02-f1f7-475b-ad89-9c00ab970604@126.com> Date: Fri, 20 Dec 2024 17:03:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] replace free hugepage folios after migration To: SeongJae Park Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, muchun.song@linux.dev, liuzixing@hygon.cn References: <20241219184301.63011-1-sj@kernel.org> From: Ge Yang In-Reply-To: <20241219184301.63011-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3H3nhMmVnd+hkAA--.65229S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Zw48AFy3tr18CFyfKF4kJFb_yoW8Jw43pF ykGF1DtrW8trykurZ7trsxAFyavrn0qryjkrWxJa47A3W3tw1qgF15Zr15Ar4rurZ7GF4I v3y2gF4q9a1UX3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Ut8nOUUUUU= X-Originating-IP: [39.144.39.55] X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbiOhG7G2dlJ1XGEwAAsu X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 054F720003 X-Stat-Signature: 9mi84ia8phij9y4kx8ogy5ba7cpemrix X-Rspam-User: X-HE-Tag: 1734685398-281380 X-HE-Meta: U2FsdGVkX19hDy28nijeUlu9+OVbfKytVr2eo9eVgkQa4axaPDN6qEUydgY4jUEv0VTOfIbI4kk7d+KyKsrhOSv1oOCBuCIlS6ONU5HwGlYcH/maizEOrQXaXKf8M0KNXJEut+9LfufM/uPpBicRI+IYPYmMeGmmFAP2KuMa7R1zCxUy5dVvGbHjNu6NiwqA17LNhBOn9CT9OW8jtyBcS65Vhmovl1opDN00CAp3nJgc2a6c0d6933IxeXep623ocvuQJ6agc4NU6bbGqo/sQZ2OI9SxnXjKJJxx6hKQJDLYheFDfCtMXdog1ImLu4zPqr7XQUYwLkSTh73oO8PEyhdimmpprpCJYDfUdBTvUOaQ5qepm7LS9hwe/Lm5Kr5TMnVkWD223zkOp+a+Vtrma2sFkx2CKhgXuPL4z83RhQJIVGn6yP7xT32V5ZSTIE61W6qdn7QW7U0403lKFO2vnhdqz+HkxeE880l6PsCoUI7dfv3m/PCXFVlAQj/44qU/Huuf+bz+Dzkg68FD38FZyVe0rnasffnchlshihGplnOzxjQe9bS+/MQ9Zarw+BQ4yll1Cg+2/0DBpNOnTUA+WMVj5yxekt3CUXDoeHDtuT1j9WltbNNzioprgSdg90AV8TAOcNEui6i0vn6gq17RRbfS3n4VESpn1Y1JVOK5bUhOWCMg5pUnJ2y9T11aYzeLXuj7JZ4EGlR7+E7aTPyYa1Rm5c7YNW6IdI+1h4tojWAC2FZ0BrbgccoZfcKP1q0tzZV0J8Ep9Be0e7Vx6nq2eI6nQSvH11jUKUFK59JyM/FIQbLoTOrJWQo+yFirdko7hfFW++gk5tkU9ro1PC3w8kwlQv8ZgK742OANPfJu36QelmZ5GE8EHdkqsoC2EHOszIHUtTplN6iv/gk+f1qcg6R0+uCpj+kFSLejHxIBCDYDfAUTZGiVLToDX6I3y7KTiFTPxdzJbTNX6QYEEgP 9av+8sRT dZvraU6p8a4GPo8Jz8wXSW2P+qoEywJfP5/aAMoAV9UX2rbVtk3Pw77yNlGX7YMMeAadVgqops33ydM7G02zncPp1ojPhqsRpY1oFj4HeDGxTa5rMzrhHMtWFWqaySKEUM1Wy7E+rVvQNl826942wEuLDhAR5BU41yA3H0v2+58uwA/2yeMyp7oHRnn6HRuGeiqzQVCabmueRdL1tJvdUrE2Qg3uIiBfoHXuS0i/7nW1tv/oGrldUwNw6u5XaE/Fe5FF4KVkhMi/2voT7u32KkO9KtKA9k+ZqmuLHuwEWS2C8gFqdEWtOVKfSQlv9MBlVIL5Pkm8OdO0YRjom62C4XetuhDNyZoyJJtXKIdo5cepXdyyHkPmv/HmMw5kzUxsoKEpSqIDghkltsoh2re98ZDUBD5Q85wa1mk1M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/12/20 2:43, SeongJae Park 写道: > Hello, > > On Wed, 18 Dec 2024 14:33:08 +0800 yangge1116@126.com wrote: > > [...] >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index ae4fe86..7d36ac8 100644 >> --- a/include/linux/hugetlb.h >> +++ b/include/linux/hugetlb.h >> @@ -681,6 +681,7 @@ struct huge_bootmem_page { >> }; >> >> int isolate_or_dissolve_huge_page(struct page *page, struct list_head *list); >> +int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn); >> struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, >> unsigned long addr, int avoid_reserve); >> struct folio *alloc_hugetlb_folio_nodemask(struct hstate *h, int preferred_nid, >> @@ -1059,6 +1060,11 @@ static inline int isolate_or_dissolve_huge_page(struct page *page, >> return -ENOMEM; >> } >> >> +int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn) >> +{ >> + return 0; >> +} >> + > > I think this should be static inline. Otherwise, build fails when > CONFIG_HUGETLB_PAGE is unset. Since this is already merged into mm-unstable > and the problem and fix seems straigthforward, I directly sent my fix: > https://lore.kernel.org/20241219183753.62922-1-sj@kernel.org > > > Thanks, > SJ > > [...] Thanks.