Re: [PATCH] replace free hugepage folios after migration

[Ge Yang <yangge1116@126.com>]

在 2024/12/20 2:43, SeongJae Park 写道:
> Hello,
> 
> On Wed, 18 Dec 2024 14:33:08 +0800 yangge1116@126.com wrote:
> 
> [...]
>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
>> index ae4fe86..7d36ac8 100644
>> --- a/include/linux/hugetlb.h
>> +++ b/include/linux/hugetlb.h
>> @@ -681,6 +681,7 @@ struct huge_bootmem_page {
>>   };
>>   
>>   int isolate_or_dissolve_huge_page(struct page *page, struct list_head *list);
>> +int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn);
>>   struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
>>   				unsigned long addr, int avoid_reserve);
>>   struct folio *alloc_hugetlb_folio_nodemask(struct hstate *h, int preferred_nid,
>> @@ -1059,6 +1060,11 @@ static inline int isolate_or_dissolve_huge_page(struct page *page,
>>   	return -ENOMEM;
>>   }
>>   
>> +int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn)
>> +{
>> +	return 0;
>> +}
>> +
> 
> I think this should be static inline.  Otherwise, build fails when
> CONFIG_HUGETLB_PAGE is unset.  Since this is already merged into mm-unstable
> and the problem and fix seems straigthforward, I directly sent my fix:
> https://lore.kernel.org/20241219183753.62922-1-sj@kernel.org
> 
> 
> Thanks,
> SJ
> 
> [...]

Thanks.