From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F90C433F5 for ; Fri, 10 Sep 2021 12:02:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85170610F8 for ; Fri, 10 Sep 2021 12:02:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85170610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1FE626B0071; Fri, 10 Sep 2021 08:02:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AE56900003; Fri, 10 Sep 2021 08:02:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04EE5900002; Fri, 10 Sep 2021 08:02:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id EBAD46B0071 for ; Fri, 10 Sep 2021 08:02:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9AB40183C4791 for ; Fri, 10 Sep 2021 12:02:37 +0000 (UTC) X-FDA: 78571526754.21.A2A5488 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 3045BF000090 for ; Fri, 10 Sep 2021 12:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631275356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iWvPmFJHWrTlqeQKg0WJIhQRDa/OXRfQkCvoOjfDvyU=; b=FqjZyVbxUC5BJ9hl8MF4a3xquLchYpoAYn31Cahfhzmia9DG9+9CNLA8hgpdcCdADF3SWt GCr7tPCFcLIQs4Kq9Sn3VogPSaEUdYUvUtpE1OCbnbKoJR63PhJYOgTzoXcIUGFsrvkSly 2ohY7u9hQfqUwR3pYrpTeBRbBvzZU0c= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-O8bLQ5SzPNKqgQqv6U4QUg-1; Fri, 10 Sep 2021 08:02:35 -0400 X-MC-Unique: O8bLQ5SzPNKqgQqv6U4QUg-1 Received: by mail-wr1-f72.google.com with SMTP id t15-20020a5d42cf000000b001565f9c9ee8so448759wrr.2 for ; Fri, 10 Sep 2021 05:02:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=iWvPmFJHWrTlqeQKg0WJIhQRDa/OXRfQkCvoOjfDvyU=; b=433ZGvhDZr9EV17GocT/DXsbQ3UYeyoJCElqvdZ+ZB8Hm6YoHf/ZE5koG7l2YMJ+Vf zWOjNMfx2A5DZVkKc1I8t2thdBOFd5MoVPvIPMjvak3yl8w0WkneAyZ1rqr6+K9HXn5c divCWvFm39We7QkFr5UmNuX+W3yKSADN9X26AZFIKGWimBI+SaiH13+8IBiQ3jNxVecS h0Ps9IBW0Wx0O3btqppj7YJTxnqYsLicaQ4DCWxCfGR29rHgQsayU8zMxfEx/DE+JdNz BLSSsQaONragUuJqqmTXtwVN+1c3ZMvcrt7wpcNRkECpO+9kFZvZDT6u7nkpQkOkUmt3 32QQ== X-Gm-Message-State: AOAM531Y7hEoN5+CQjECh4Ts3/Az8kcwtSdPvWeTlPLXbdGy0Xr99HHV 5tFRKmusbE6XO/NXzEUrnYBTMcPIR2NGJS9tWWWhAqzHeO+BaQdj1V36YQ8ZD4oVVfQpGnAIqZu /0qziiOtjbrw= X-Received: by 2002:a05:6000:22d:: with SMTP id l13mr9271502wrz.410.1631275354067; Fri, 10 Sep 2021 05:02:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd3qcB6kC9qWP9tPtuHubmv7UT+qXoQljya60b6zYbxh0B1+EDeOuZj9otYChgIELZe0IRyA== X-Received: by 2002:a05:6000:22d:: with SMTP id l13mr9271461wrz.410.1631275353843; Fri, 10 Sep 2021 05:02:33 -0700 (PDT) Received: from [192.168.3.132] (p5b0c600c.dip0.t-ipconnect.de. [91.12.96.12]) by smtp.gmail.com with ESMTPSA id x21sm4078642wmi.15.2021.09.10.05.02.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Sep 2021 05:02:33 -0700 (PDT) Subject: Re: [patch 079/147] fs/proc/kcore.c: add mmap interface To: Mike Rapoport Cc: Andrew Morton , adobriyan@gmail.com, chenying.kernel@bytedance.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, songmuchun@bytedance.com, torvalds@linux-foundation.org, zhouchengming@bytedance.com, zhoufeng.zf@bytedance.com References: <20210908025730.S88ylmikU%akpm@linux-foundation.org> <303e9a27-7495-1c94-64a1-a1149a39f0a9@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: <1c028f97-fbf2-acf8-9b7f-be0449246aab@redhat.com> Date: Fri, 10 Sep 2021 14:02:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3045BF000090 X-Stat-Signature: 5azn9yrymnk3psa56ipdmtbk3x3in8du Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FqjZyVbx; spf=none (imf16.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1631275357-411159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.09.21 14:00, Mike Rapoport wrote: > On Fri, Sep 10, 2021 at 12:08:17PM +0200, David Hildenbrand wrote: >> On 08.09.21 04:57, Andrew Morton wrote: >>> + >>> + if (vma->vm_flags & (VM_WRITE | VM_EXEC)) { >>> + ret = -EPERM; >>> + goto out; >>> + } >>> + >>> + vma->vm_flags &= ~(VM_MAYWRITE | VM_MAYEXEC); >>> + vma->vm_flags |= VM_MIXEDMAP; >>> + vma->vm_ops = &kcore_mmap_ops; >>> + >> >> This breaks all my efforts to sanitize /proc/kore access for virtio-mem. >> >> Is there still a way to nack this? > > Already done: > > https://lore.kernel.org/mm-commits/CAHk-=wgQ+8kmczLLKCY7yDsGHQBRcZESKd1dNaKbrjUgbWeb3A@mail.gmail.com > > and down the same thread. > Yeah, spotted Linus' reply just after I sent my reply. ... afterwards I thought about the implications fpr secretmem and ordinary memory hotunplug and was happy that we dodged this bullet. :) -- Thanks, David / dhildenb