From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFF0C04AA5 for ; Thu, 25 Aug 2022 10:49:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D81E0940008; Thu, 25 Aug 2022 06:49:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D310B940007; Thu, 25 Aug 2022 06:49:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8C6940008; Thu, 25 Aug 2022 06:49:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AD67D940007 for ; Thu, 25 Aug 2022 06:49:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 81CE5A1994 for ; Thu, 25 Aug 2022 10:49:44 +0000 (UTC) X-FDA: 79837794288.05.D396357 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 07A0920003 for ; Thu, 25 Aug 2022 10:49:43 +0000 (UTC) Received: from [192.168.10.7] (unknown [39.53.61.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 20DB46601E9A; Thu, 25 Aug 2022 11:49:39 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1661424582; bh=XkXPRTCnn8052jSrei91LRmXIOrhuSsnF8sZf7lA8MA=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=g7ucgvT/HMYyMaHad4z8nxdP4MVUQ3ZO8rDgsIv5Mw17IyGU+TirSXECdNoQsTHA2 mJsK2clwfJtrCff27ujqfR3UujxtMW2ltvacmS9U4f8/QMgh3YIHBQGF0ypwPYzgFy V2d/5vJPg/PczJM+VQBFzkxDg8wfSSaMTEKMUSJy4PeUobRnLA8R3xV74SGFkAZ+Sh xehd3876tXBbHz6hRF8Xo1oIPCYdIWC76LdIpHjxh7GFt+3VkZSsKRDd9D1FGCNWPu EN1JmKmJWXxdkzaz6LEcWE8x4yGnRSlrjCr7+ULT7NACyeLTu2LaGQy6glmfVb/0+S 9d2ocZKEpAEXg== Message-ID: <1bfb71e6-1553-b83d-b151-8c8c5ffc5066@collabora.com> Date: Thu, 25 Aug 2022 15:49:36 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Cc: usama.anjum@collabora.com, Jonathan Corbet , Alexander Viro , Andrew Morton , Shuah Khan , "open list:DOCUMENTATION" , open list , "open list:PROC FILESYSTEM" , "open list:MEMORY MANAGEMENT" , "open list:KERNEL SELFTEST FRAMEWORK" , kernel@collabora.com Subject: Re: [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit Content-Language: en-US To: Greg KH References: <20220825070926.2922471-1-usama.anjum@collabora.com> <20220825070926.2922471-3-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661424584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=giDLeiqHR138cu8YxBWaUA+q5tHQtYpaBO4GfbDV8Pk=; b=QB0DlKwliUFFbpsbs4wWkbpOPxqyQSj9D6m3X1TohXiNYp5a0Yl9Zj23jnaTUWAl77PcEz y6nR/jUSEVVWxtD3k5NtBKPFZXXr1NHnaf810E703FJAV6KKyVkM7ozE4e6lU7iwMv3O5l ndQDUoI+/ZSZ6mz7sN34JPZHnkl4/9Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="g7ucgvT/"; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf13.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661424584; a=rsa-sha256; cv=none; b=lQeIxoOBR/0mduj72wAgdkRKMEtKeI3zdW9WbDMHHYByjHszXib2Xgb6t0/e9g2NhqUoby Vr2flHU3Bwvv+8VF3asEZlSuxiEo9M0I5VBnmQim2V31VVUkb1a+ySiQaKXNd9vQskqIla Ph4CN2L2TVGtJQahDXDGU0+Pd60AlW0= Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="g7ucgvT/"; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf13.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 07A0920003 X-Stat-Signature: xq5tiz3e8rffykeb9ujii4cbfwcedp5z X-Rspam-User: X-HE-Tag: 1661424583-928601 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/25/22 12:22 PM, Greg KH wrote: > On Thu, Aug 25, 2022 at 12:09:24PM +0500, Muhammad Usama Anjum wrote: >> - The flags can be specified in the flags field. Currently only one >> PAGEMAP_SD_NO_REUSED_REGIONS is supported which can be specified to >> ignore the VMA dirty flags. > > You forgot to check that all other bits in that flag are set to 0 > properly, otherwise you can never add a new bit to the field ever as you > can't expect userspace got it right and did not accidentaly set it > already. > > There is kernel documentation on how to add a new ioctl, you might want > to read up on that first before resending this. Thank you so much for the review. I'll revisit and resend a v3. > > thanks, > > greg k-h -- Muhammad Usama Anjum