From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: usama.anjum@collabora.com, Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:PROC FILESYSTEM" <linux-fsdevel@vger.kernel.org>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
kernel@collabora.com
Subject: Re: [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit
Date: Thu, 25 Aug 2022 15:49:36 +0500 [thread overview]
Message-ID: <1bfb71e6-1553-b83d-b151-8c8c5ffc5066@collabora.com> (raw)
In-Reply-To: <YwcjTOgKD22TXwYk@kroah.com>
On 8/25/22 12:22 PM, Greg KH wrote:
> On Thu, Aug 25, 2022 at 12:09:24PM +0500, Muhammad Usama Anjum wrote:
>> - The flags can be specified in the flags field. Currently only one
>> PAGEMAP_SD_NO_REUSED_REGIONS is supported which can be specified to
>> ignore the VMA dirty flags.
>
> You forgot to check that all other bits in that flag are set to 0
> properly, otherwise you can never add a new bit to the field ever as you
> can't expect userspace got it right and did not accidentaly set it
> already.
>
> There is kernel documentation on how to add a new ioctl, you might want
> to read up on that first before resending this.
Thank you so much for the review. I'll revisit and resend a v3.
>
> thanks,
>
> greg k-h
--
Muhammad Usama Anjum
next prev parent reply other threads:[~2022-08-25 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 7:09 [PATCH v2 0/4] Implement IOCTL to get and clear soft dirty PTE Muhammad Usama Anjum
2022-08-25 7:09 ` [PATCH v2 1/4] fs/proc/task_mmu: update functions to clear the soft-dirty bit Muhammad Usama Anjum
2022-08-25 7:09 ` [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit Muhammad Usama Anjum
2022-08-25 7:21 ` Greg KH
2022-08-25 7:22 ` Greg KH
2022-08-25 10:49 ` Muhammad Usama Anjum [this message]
2022-08-25 7:09 ` [PATCH v2 3/4] selftests: vm: add pagemap ioctl tests Muhammad Usama Anjum
2022-08-25 7:09 ` [PATCH v2 4/4] mm: add documentation of the new ioctl on pagemap Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bfb71e6-1553-b83d-b151-8c8c5ffc5066@collabora.com \
--to=usama.anjum@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox