From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E52C2BD09 for ; Mon, 1 Jul 2024 06:57:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93F646B0092; Mon, 1 Jul 2024 02:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C8566B0095; Mon, 1 Jul 2024 02:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71B766B0096; Mon, 1 Jul 2024 02:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E70C6B0092 for ; Mon, 1 Jul 2024 02:57:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B4E441A1966 for ; Mon, 1 Jul 2024 06:57:41 +0000 (UTC) X-FDA: 82290278322.19.7F8B254 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 76DFA40016 for ; Mon, 1 Jul 2024 06:57:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cnjiK24K; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719817031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IpTSHvGGLKrRIbXymuTxT7TJOOuk+NtEfOPydwUddDU=; b=W5H85tFjGFbVP/tW5N/5rjW/df5k1lf3M+//U7oWtcKpa4n30i70fgPKc8jUvReBmUPMKk FU5csr6QrS8MFsUlPthgbTZNp8ZTQ3NjlPxoQsAlacPg+xCkhLbj/+ENzFw7Ewc0xSUV6E WX5NKzFeJK3kGK8ijzKZFSC5W/bprng= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cnjiK24K; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719817031; a=rsa-sha256; cv=none; b=jGM+9Qy8yR0SDaDwGhkQ1TCtDTEzRdPJ2y5psHxqAlhdBF+9OjtNhWybfsiZ8hymRVixOz DBU6dGjYScalBVZSAsYtn3NPdnFszIeETHy/6TLjjkfNzyny+SmH15abmWrmZs73iUDKuY BKj0wGxjV53GR75DnlZDN6VjiV0ep+4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719817058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IpTSHvGGLKrRIbXymuTxT7TJOOuk+NtEfOPydwUddDU=; b=cnjiK24KesKhZjaARCTG1t0tuZUf1S2fIVUCzjZKNd7Pmzi957jMLmsrps+3kCPSGIWuK8 NjKpU96CqAaeav+Fbd4t3plv1IG3wbEBCEhyojtxxHN55XpC+KCvjNMHHprzM/F8fLB1le dML2bMZuT9sMkHSTIWVv9hVwueS85B0= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-zxCIRelDNbC0A6ZpuJqpxQ-1; Mon, 01 Jul 2024 02:57:35 -0400 X-MC-Unique: zxCIRelDNbC0A6ZpuJqpxQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ec584f36bfso24293141fa.3 for ; Sun, 30 Jun 2024 23:57:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719817054; x=1720421854; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IpTSHvGGLKrRIbXymuTxT7TJOOuk+NtEfOPydwUddDU=; b=RO+6EqDU6J910CAAT35kCY1LP9jPbNkvP/dmytbGcM4epbgFx/auS+mvSp7HLD/eHu 2BWgw0WSyf6cLsuUoB+KVRBa6s3/DHY0buv94vWgOGNhnjB65Q76M81GKjJpqTETZAIA j9wLmNX0aaCrNXmfpw3Ld7szsCPiJRvdR/B3vafZzrrPxPbO4jWKSFTa4AXCgntXLfXH cr/Y1tKFslnJwKRlVFMG5VztYpJFNxrxLECFLTvuQ6fmgGU5z3xUehlAxLas35V7DAF6 CeOmYBk5v+KGf3NfnMnhiMcHH4RtMx+I26UoUYnQD/wHVP7tTY4k0Wkftprhnjt6iA0e P16w== X-Forwarded-Encrypted: i=1; AJvYcCUW05C7hRZ8roxeNQxhtKwfjbGoGIqqge6f7TX0QwEUWcinGGyAsbIQqRn3BtujB95PqmEMoPOz1fG1fPvIu3VNUAE= X-Gm-Message-State: AOJu0Yx3v3GNVYqLwJdrYbiyPvbTlg9z1/edkq8DiGYKKXXfYQz2wMGc 9HuMzsWhVxVfwi2hmlJlPvfCBmA6E6rLLw6B8+bbjJsw1oBLmskX4NRpbTqf4wcUbN9rH8lvv6u TyGYpzAGcs8z9CTMekeh/IBNqUSYVSgTOqE80OA8R6WNVkB8R X-Received: by 2002:a2e:9556:0:b0:2ec:58e8:d7a2 with SMTP id 38308e7fff4ca-2ee5e359092mr25084541fa.16.1719817053958; Sun, 30 Jun 2024 23:57:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/HNWdb4R7HyFPm87+8vcgtMUhbGbar8AL+VQEjwkzMxx2hDvAu8eV7BURsrmPE30qqdiZcw== X-Received: by 2002:a2e:9556:0:b0:2ec:58e8:d7a2 with SMTP id 38308e7fff4ca-2ee5e359092mr25084441fa.16.1719817053536; Sun, 30 Jun 2024 23:57:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c72e:2200:7ed7:c239:d423:3b31? (p200300cbc72e22007ed7c239d4233b31.dip0.t-ipconnect.de. [2003:cb:c72e:2200:7ed7:c239:d423:3b31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0e1345sm9105356f8f.54.2024.06.30.23.57.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jun 2024 23:57:33 -0700 (PDT) Message-ID: <1bf214bb-86a7-4f73-a839-39a4b37bc04a@redhat.com> Date: Mon, 1 Jul 2024 08:57:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem To: Bang Li , hughd@google.com, akpm@linux-foundation.org Cc: ryan.roberts@arm.com, wangkefeng.wang@huawei.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240628104926.34209-1-libang.li@antgroup.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240628104926.34209-1-libang.li@antgroup.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 76DFA40016 X-Stat-Signature: f7uyot7cdbsmogz47ajo9kweur73m31g X-Rspam-User: X-HE-Tag: 1719817059-240832 X-HE-Meta: U2FsdGVkX1+P9UB7nNJqWI+zU7vWR0I4DtyjnqQ/whM/erYCYtujPFjvIzsGoc+git4gZLhBsGzonG6HKIvZKGd0qmxhpVzYyek21g/pTCPIpxwEnDMLgYn5zlc+CNaE3DZ0g+bEmbCGAsuc7DY3fCi+PuKXyAuUgtRuWt7OtrVOyZXwdp1B3P6ltKFjsczyhGO/hs7J3lcL9UAANxyuacxQD16TSEatNRFqQ9gOVoLvlFPChx3azpEz7LZeGVTzrsrL0Q4Pi4H8LUREtSumDx4LNowTB8bTDqWvH42Qz2LhWaLQFXWrQqhnTYEfc7SQaHz4HLvsbaHUA1o+tXXtGeq+5a/7f04jqqXvgoFLU3J9O9+02lL44zrrYz6T1tu/z/78Q5Ek2H4PHCJPwKsKK0YbNsiaW+3QzDqIcBUQ6DjnzHXw40ib97G+JStciMRFahX5sbkEVEYPOE+lFrkrZjEbmxogF19TEgkpBzFClhzXeTJElrpUG1hxEWmRUvRBq+2Odv9XJHs7qZnJcxtT8EytiPSMf/nPIAv1MSi+V2WqkT9iTMxzbvyIxOWhWJFYTMY3Ot5IoVGcpSnWuNMpon4iZS4QsVDFkNIPOTC+cyef3p4WFjpduY8zBYLE8ShRJR+bSCgaKH+0l9fzoNDgTQ8Hh9BtvDxxjnzMuFba+XZMHRPky/EwrdzChwzwHkC2G2BXkGB4NKhZrCNAehArbcdj9jC7+4yMXx4ZLYXy7L8qvdGXpLYEC7OpBiaKdtbw2ZL/SaCkNH9LpuFVPBf5xZqwYbPvwbEUfs6r6/uBn6FkEGq5dXRQGI+6j8cyKi9K18GzUKninYBA9kzc8oN3UNqmdmxdhPTdGB6psI4jzR1BfYMTdImC+h0iRbOABuu876S1h4MWLm4ssQ8haix4H9ybF76JpE3v6OOUEz2A4OUIgcbK8Y2/MfDMQ4R9YSSbQZxYMRiyNVX2XU6PFhk zKWxjqBy RGTT3d3nnxobgWzN/dc1MOKtAMU/06iYm+VScQU91/pAUXOwEKfgOXATps3V/q1kR8u4FNH7atsEyFUzZkf0SF5lMjDX7kWDTK2gCCQk0mj9wmjmGzRpau5ak2o3p79lBfsTphfnN2xeAoHou8SZocCbmyAUpKpQKbB8VCI+muAWsLPn3qh0Tx2+0pnMC/DrjC3z9AJkeqlr1C0HVbn2eAwlEprN8mJ8DUd2nRyrsbWp3cigPsCYSo9TRAvjo7KKopVEKb+vNrQAz88F8w+b85cgKafA9lTueKc00x9asdLE6bTw+Bu+8wdORpIEuGEyXvNmGnC+CjMsVkBkiOg4YOGeltfPTLRtWV4H5WUZPP12AdoObzA/0aLXHv/MiM0ZvdTG3C7JwWDh7f1kDJFIS1r9vUshGo1tNweJEcKtqWOeMLtQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.06.24 12:49, Bang Li wrote: > After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for > anonymous shmem"), we can configure different policies through > the multi-size THP sysfs interface for anonymous shmem. But > currently "THPeligible" indicates only whether the mapping is > eligible for allocating THP-pages as well as the THP is PMD > mappable or not for anonymous shmem, we need to support semantics > for mTHP with anonymous shmem similar to those for mTHP with > anonymous memory. > > Signed-off-by: Bang Li > --- > fs/proc/task_mmu.c | 10 +++++++--- > include/linux/huge_mm.h | 11 +++++++++++ > mm/shmem.c | 9 +-------- > 3 files changed, 19 insertions(+), 11 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 93fb2c61b154..09b5db356886 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -870,6 +870,7 @@ static int show_smap(struct seq_file *m, void *v) > { > struct vm_area_struct *vma = v; > struct mem_size_stats mss = {}; > + bool thp_eligible; > > smap_gather_stats(vma, &mss, 0); > > @@ -882,9 +883,12 @@ static int show_smap(struct seq_file *m, void *v) > > __show_smap(m, &mss, false); > > - seq_printf(m, "THPeligible: %8u\n", > - !!thp_vma_allowable_orders(vma, vma->vm_flags, > - TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL)); > + thp_eligible = !!thp_vma_allowable_orders(vma, vma->vm_flags, > + TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL); > + if (vma_is_anon_shmem(vma)) > + thp_eligible = !!shmem_allowable_huge_orders(file_inode(vma->vm_file), > + vma, vma->vm_pgoff, thp_eligible); I would have thought the correct fix is to return the correct result from thp_vma_allowable_orders(). -- Cheers, David / dhildenb