From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D061C5AE59 for ; Thu, 5 Jun 2025 07:47:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9B9E6B0577; Thu, 5 Jun 2025 03:47:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4C1D6B0579; Thu, 5 Jun 2025 03:47:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3B526B057B; Thu, 5 Jun 2025 03:47:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 83A726B0577 for ; Thu, 5 Jun 2025 03:47:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 31CD0161C38 for ; Thu, 5 Jun 2025 07:47:10 +0000 (UTC) X-FDA: 83520566220.15.B252D53 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id AD14F1A0012 for ; Thu, 5 Jun 2025 07:47:07 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SwDu5b3S; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749109627; a=rsa-sha256; cv=none; b=uNxSAxZMl0sM2TkZZfP6JpaVapAO34hq29iO5KYyNqEt50x5RBl4q7ugrPJjzkDHxU5DvJ IPNl+AE5glVSm45lN/QRcFPuBg2Yukaby+Bf5nB7AzB6J9zWofm9FvjIKGTwNFYxEw5UMd wtDFp7WJv8IaesKEsaQY1qUFKcf5GxM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SwDu5b3S; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749109627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BNCAVSpJXh/o+ewQaU32BKixyPokxZNp2s0CedjuqZA=; b=nwlvktOt1+8yjD01S0t3GjLDGQ1Pd0WctJY5oJ4ssL+WbfdZwMg88pbLTLzPmQ6tRZMDFM BFmIyDqVAXaRQFElpdvu7d/YjuVvtkRyN0rZ/tEQytlAJp6fw3okmrIw6rBobjUz6bBYCP WhX+6G8p/YWMmu7Wvn2CzsxTjAAVPDA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749109627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BNCAVSpJXh/o+ewQaU32BKixyPokxZNp2s0CedjuqZA=; b=SwDu5b3SoiJX5EwUga3pk7E/CfIR/hfYT5r/p5s2l8JY8fK0segaNQIVaCHAjBQXDChjwk W3z+XPZggla/9gvxuLPEpsR/7mSiT+RIJ8iHJxKKML16l22FTCAVrWFGUjLNYwy08jS7rt itdVKIpU6Vj84/GruIiFdhJ1ccLARtM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-sJcqsF79MYKe5NWTUJo4WQ-1; Thu, 05 Jun 2025 03:47:05 -0400 X-MC-Unique: sJcqsF79MYKe5NWTUJo4WQ-1 X-Mimecast-MFC-AGG-ID: sJcqsF79MYKe5NWTUJo4WQ_1749109624 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a5058f9ef4so286952f8f.2 for ; Thu, 05 Jun 2025 00:47:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749109624; x=1749714424; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BNCAVSpJXh/o+ewQaU32BKixyPokxZNp2s0CedjuqZA=; b=N5cbkykc/pdVeYyIHULm1tOwcPd4vKDo88LYQ/QSxdJoL4pDE1GrexlozQdX3MsVpy CnO1BBS/pNW2YDeWh9sCDxnElF8+J1egv7tx/XYc8RnKdByQGD7KaWXqYuVCZinAG1Wj svZXj5vpZGFboMLexJ/UBGMjrCpaqZ9Bds/6aSzca9sl43XLVQ5W8r87/ryexyTuAMQc s3P2m+SeN41i8dtQvQcat7vH9nCrh16+XXh4ELIzjqG7AIPR7nFPXtCNz3rxt8T6JcSh 6ine6r3W+xx+ygTAtumA6SwMTbA4HBiBgszxWeTsNEhKmKaydXanpnDtN8LMLhN0K3MC uG5Q== X-Forwarded-Encrypted: i=1; AJvYcCVj44rXuCmLN9zVvHFE8aAs4JQNVQEzGUPsdWE6oP2IeJ8c4ln39DZ0ArSURqtmsBcfTGbLnJkwLg==@kvack.org X-Gm-Message-State: AOJu0Yw6qU/DOPqtBePCVbyPzfClR4pZlQrPPWdeQSOsVn9CxtnfWXJH CyfeHk8iehpHoEN66JLUdBkQO2qTdG31WdrOF0ITyROng3y/sRuRhNjSTp77o5kX2U0+pTqtGCa UAw5+yC8sP1M6hdC1DmG/CJSVReiQqO6WAN/uX4Iw4K4SqU0jWxCa X-Gm-Gg: ASbGncvFgaJSiqLvr0L7CbHQi52+KDe6W53EJVtleA3FCQ9C42rAeYIN2riAqiCajj+ QTPkhFpYBfKTrqXUKBFIEA8yq6tL6550LEOfIF+A4bA4jOMMUWjUTk6dj18MX7z4gnnctonUD0u hZY64jwtpt+toaXfEY0h08i4B8FSwvb1rgwx8NCNd6o5VfCjfHcJIlK1w9cN1y7FVXTI6FKj3F1 MZvfUO35yX99Pa/2X0GstbS5uqxXI9jI4bMRM+rmR0uUmAroTBsfTuu9WjrbsjxTexTqGkbyEJB YCfMyqIdTMvNHMPnbRTW6H+y7ay4SzvTE+Z4LtX1yhwW+eq56GGSc+UiWB4eCGi/+mBMPGMZiNk HASerr9s4H2oHBGP4wKpKz53aHcW5pBR3GHQm X-Received: by 2002:a05:6000:1e52:b0:3a3:7753:20ff with SMTP id ffacd0b85a97d-3a51dbf715fmr4102344f8f.35.1749109624120; Thu, 05 Jun 2025 00:47:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKW5Vy6rvHU4tuAc9hNiYrFzw0cH5ZBqlwWRS7YJXQsUQupDovOp0p7SPbZ/AnZh5B2Orkug== X-Received: by 2002:a05:6000:1e52:b0:3a3:7753:20ff with SMTP id ffacd0b85a97d-3a51dbf715fmr4102321f8f.35.1749109623707; Thu, 05 Jun 2025 00:47:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f009752esm23716613f8f.74.2025.06.05.00.47.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 00:47:03 -0700 (PDT) Message-ID: <1bee21f5-6c59-49c4-ad3b-74e6a0ad6ac8@redhat.com> Date: Thu, 5 Jun 2025 09:47:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gup: optimize longterm pin_user_pages() for large folio To: lizhe.67@bytedance.com Cc: akpm@linux-foundation.org, dev.jain@arm.com, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, peterx@redhat.com References: <20250605033430.83142-1-lizhe.67@bytedance.com> <20250605073950.1834-1-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605073950.1834-1-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9aQJePJkA3t-XNZqNroZYFSGPl8ObV48BZ--j9LdVIA_1749109624 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AD14F1A0012 X-Stat-Signature: feda379sww5n3fzquu9o5jx93b8jxpj3 X-Rspam-User: X-HE-Tag: 1749109627-628821 X-HE-Meta: U2FsdGVkX1+Ld3yRYAuCWeEf2Ag8hs4+ZH0WJ5TWJp9LEwkqLDB+TRaGUx72dWAFvYlxGM4Vgl4KbmB9z2wUW1PIAmOU/eE2LKbvozqxO1t5UdJM8uhhSA6mzWR+H1I1i1tllWFskMx946fZ+FFdrqz4Vk153zrcTpuF/D09NYrh5QUv4h0Z/u8XPjyHLIBXqJPWIyBkYU/DZ0EB47vMKmKJnbIfSynb9BJczZ8rDStugUyOclXA1I5T+Eby3/PHZCPrhpyUUArPZb1ar11eptIodavTA9cnPaw+0PSTHPUBtRzuvTYk3TEGxg63+L+5RV+YvOjyTgxJCOpFiYUHRAcM10LQPVKpjlRfUTYMGUJIBoAuN13XM+DSI4kSfD89G4Ps9fxSNn5cczNhQoA1/J2dwc5qQNPFs32ELI9By80L2TY1CxwAy5hlGvpz1jKHtwRTiyDujmkF+/YnAziaN+/rdv5VNJwWPWkZt8SWWZxyMZNNzqHulz7aAaRqeX7eXYu6rMf7lt0CLXCzsJBZSAjAAYSQOquf/IMqMEi71ImRmLJlLWc5QPsJcI1SM1GDKZrJS82+/unHMAmRGnFp/0/bO8pDi1+QvMmbeOeQpCSUCzkrIicflpmOvyhtMmx2m/eL47cHBKz7v5lAPiK+nlcekZ0CkKJzFYy//YhRju5aagIrp2a4qzERuA0SL/Rmg1mP7BfVKKpG4AnX/CyC1NPLcVyxnbops89Xb7rwp1gPgggYPEsEV/qcyAoxWU1XfeqQ2nj8JdqtDTqt7sFHm4U6dc/B2bPES0c/qh4RzLU0Uw/IDKDmn2bpey6hQBcJDs/wnZG2aIEFRaeLw0yVhGRnMCPldCBW2ZrSVDNhlOGnv/FuekGNrp7T15uAtwZ2+6/eh0pOAplJRS2jkQylKvIJiFcGyC4hro/Wqh2ZYLwRzJgNeahZM5p4Xe1Av8aLzXPFn93zNyjT9e+n/QY zQKnZp9V EJJPOSd/2YpLLFPsC+uAR8PeaeXLhhu7AtvE4tpgtN4bt2qrW7m0FfSZDGG4N+Wl6mOswqhp0Ii3rOT4Lk3PFB9mL2nmGryRRNqPEAZy2NiCMiIrPFXB6e7dcpCToWLQqHHpYL9jOXoDzMcAv5v3Puy5bBDzqDShnND60Nca+DNbNtXIDBjzU5akNNKLhtjuIZTs2yrASOQWLvHvP10eDoYe1cH/wCHNubTDokSMm/5RtAA6nl4Yk2fM6bvylDZi2WRpEalFJqO3fwIlzgJSvK/hpRx2JxZKYxIB31cpMUMH3+KIWpCmp3sA2Mbzzkr/12TWGLlVXBQdF4q2wTWHcSGy7VAq+4xVeM32RY7a1a4KkbYi1LHZJnI3truhepeieffUzrFPC+aPpDClOBKzJDgLxnJn1vW+FaYgZMhNgSedsSzLYsgiy3ug20CwLZVp64kJnguGefIM1lInZwnQS0kPhTxVgwAbW2yU2jnYQvZm0h7Q+J2R8MbEjroCbf/ikcd8zRHHeAo0aXfg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 09:39, lizhe.67@bytedance.com wrote: > On Thu, 5 Jun 2025 11:34:30 +0800, lizhe.67@bytedance.com wrote: > >> @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios( >> struct list_head *movable_folio_list, >> struct pages_or_folios *pofs) >> { >> - struct folio *prev_folio = NULL; >> bool drain_allow = true; >> - unsigned long i; >> - >> - for (i = 0; i < pofs->nr_entries; i++) { >> - struct folio *folio = pofs_get_folio(pofs, i); >> + struct folio *folio; >> + long i = 0; >> >> - if (folio == prev_folio) >> - continue; >> - prev_folio = folio; >> + for (folio = pofs_get_folio(pofs, i); folio; >> + folio = pofs_next_folio(folio, pofs, &i)) { > > Hi David, I used three tabs for indentation here, but it doesn't seem to be > the effect you wanted. Did you mean that the indentation could be achieved > through tags and spaces, so that the folio on this line would be positioned > directly below the folio on the previous line Yes, that's what we do for these cases. -- Cheers, David / dhildenb