From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215F3C6FA8E for ; Fri, 3 Mar 2023 02:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5386B0072; Thu, 2 Mar 2023 21:26:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A5736B0073; Thu, 2 Mar 2023 21:26:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71E116B0074; Thu, 2 Mar 2023 21:26:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 632056B0072 for ; Thu, 2 Mar 2023 21:26:21 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 21549AB89E for ; Fri, 3 Mar 2023 02:26:21 +0000 (UTC) X-FDA: 80525997762.21.2B8F109 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf28.hostedemail.com (Postfix) with ESMTP id AA8BAC0003 for ; Fri, 3 Mar 2023 02:26:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=F+ErKTfo; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf28.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677810376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UzZ+ZRe8zRKGwBpmocpMFrxyHnKU+v+KIhEEsnsa1k=; b=kXIYplVHMQCtx2x2lWjabarl/oQjyjhFAoM+yVdB0LmGlNaXQKVrlFzN1pRAcXArkZmilq lQ6TYSzwHk9s54gd9KxsDCUcrT0llILKocA6z0lzeKpJoU9hSd1HHXRalG9xqOHRkVjRR2 XK5b4AIPmUGZjoR5Zgq5C45fEx0WEdA= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=F+ErKTfo; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf28.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677810376; a=rsa-sha256; cv=fail; b=ggKDToQcBdppZIy7X71DBN99ps0cvCE0muslm0sWS/rX7DiDaGCLXatksyupZbbfEGOUVi 4w/3RHiE3ypFaVoXlfod6XOXeaIdsLXiFYy21ILSoodTVO9AJaLx1h8R7izkP3/LozjsuI vz7TXOLQ+HV8M65uORHv4Hn5H0y2zhI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677810375; x=1709346375; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=pBjwgK6ZjfyvRN7GFggM8ejKg7kAwPu4XJZn5BtLCMY=; b=F+ErKTfo4rvkoTJHjzPZ80Qx/SP1LG1yqDsxoIBaxk6DW1NBq/ylrKjb tEviimtomj+WvOJnZvSgwqRkJptJbD+ROKmdYR1hah39T4vALG6APByef 7Eibq8U9/WLAifJtKBg313clCHjN8teILDGpZIFZdibw81DiNW0uMTx/U usPMYhBkU+mWfADtR1moTbfkNa2JKL1SrC9R+shSdtAqgt4zZ8JUwG4Xt DSGEvN0VpChTnDS0p1brPGu/iuaGlfqG9Okp3PwpEc2POCuRMRYYHupf+ p7Ds7Wym9mSHNGrzA/uR2bmNmjIX/wioz4fgykUKlsiugms8JGNgRvha5 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="337245509" X-IronPort-AV: E=Sophos;i="5.98,229,1673942400"; d="scan'208";a="337245509" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 18:26:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="675201555" X-IronPort-AV: E=Sophos;i="5.98,229,1673942400"; d="scan'208";a="675201555" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 02 Mar 2023 18:26:13 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 18:26:13 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 2 Mar 2023 18:26:13 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Mar 2023 18:26:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhauyrY0UNFatfMeWT7/E5g/SRN4caEnQFy/kKGLMa2bjwPlS4fb1Y3RTUivbGBc3F7aWsud3OtA+2+nG2bhHSUIWDHyi8HzOkgoRbxHuSL8B3tL4j71JbIlWaBK7TzPc5RTg8sGE08hp32O3SOKnSo68Za4+ad+3foWWqlUx+NjK+Th1S6C1d/rS4jFxq3CKDes/ynhUG5aoq7MBTI6/+VDoI6CvVCBMDVMWm6ojnHA6LUw4ptH4FQJMW4kd7VwUnz5lAC7xFK6bIkXJf1W/CwUawoZWd2/n9aSFL93HwJV7cJAdOAip3QGoH0TX0L8rzX8l/+OEd7XcPPkmvDopg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9UzZ+ZRe8zRKGwBpmocpMFrxyHnKU+v+KIhEEsnsa1k=; b=OqMHQu/Q0MKQQV2sShyZe6YpMHW8/ar8ITjdRuRROOmoPcg//gi8Hds9xkeflYVQDtkWzaLb7Vu8+DUpwbJJHLhGL2l8u0XCoIoCnSEfp2S+5TwQeEHvcs7TajkjpXY3SpDL3I1Qs8zsmpVXte57E0YGhauqUwPBptzbqI04AqP1aEUMzsU//7sUIdNwa+/Js1LxXPHeqLIvN1jSGo8dOVgGQSVXUOOuyMXkhqu+JahAUm3xyen0ENFYAonBKPskt9v/QhgFeNLiJpSfM202WaqY0bMMvzqEU9rd4mXEWSSq3yb2kyPL0kz83MVfbZFvIS7HEt3m+5IVdh5LSTW1YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by PH0PR11MB7496.namprd11.prod.outlook.com (2603:10b6:510:280::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18; Fri, 3 Mar 2023 02:26:11 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6%9]) with mapi id 15.20.6156.020; Fri, 3 Mar 2023 02:26:11 +0000 Message-ID: <1bdb4b86-1ea4-5018-9a1b-b9014d48451b@intel.com> Date: Fri, 3 Mar 2023 10:26:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.8.0 Subject: Re: [PATCH v2 0/5] batched remove rmap in try_to_unmap_one() Content-Language: en-US To: David Hildenbrand , "akpm@linux-foundation.org" CC: "linux-mm@kvack.org" , "willy@infradead.org" , "mike.kravetz@oracle.com" , "sidhartha.kumar@oracle.com" , "naoya.horiguchi@nec.com" , "chu, jane" References: <20230228122308.2972219-1-fengwei.yin@intel.com> <20230228122823.eba4f0fa5f7f436a2f8b3a3b@linux-foundation.org> <19263da54b9818332620345bbed69e8ded241e00.camel@intel.com> <604c372c-e474-14a7-dd80-c5197f12564d@redhat.com> <1c6c9d3e-3a7e-4d07-7c7c-9b7c01bcdac6@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0181.apcprd01.prod.exchangelabs.com (2603:1096:4:189::13) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|PH0PR11MB7496:EE_ X-MS-Office365-Filtering-Correlation-Id: 1921e5c0-fd88-46d0-71ff-08db1b8ea6eb X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /5NiF5Mec4OTErIrWTcsf8ati5PfNq9MaHVHZz+msMk8KAM7W1WX6jWxBQA0087Ilch1EYJTSv3pBD3dov1FcHYJFiFLMJnT4eAdE+w8tKpXrlPnp+GCR3ZV+qIh5tEmWMmoHUrD4YnB6IJFYfnQ6IYkBMxuF6qIOYhGnRMdb1eI13x2A+/BYn1EilL9N7vWnpsK+IEgmmcbsueK7JnuC/Xck2N5KMgiZ+EUHQRHxM/uMGiOpPqfB0dDcdJ2DHElrJgQ4pwAFGpQb3feZ+m7dVIr3UM6ezcqQBi0ap8m/ZMWq7WI03tGfeHnkVqGhIrvgtQUabooVws2hCV/JnhdiUpOSlLkAK6F4ckviIhvMwX8dU547xnUxUhq89afGQx929/vzkj2QnNS6GoAXEVDghhTybxBRks23QF/eaK6PVjpmoSgBb1skn4UgBNswf0439ihYXmh+VuA6anMC1jsOXGhWAV5ifOEEU/Z9ROkU0X0zdfhV+zYXjBkIgctAe8tztuQ/YFn4qWAk/cahInoKqc+YKnWFES89HtYO6W5wW+UGKlBjmLFHwUgUfKLicNR5nmaLpyYgN2xKLv68NpPS1GGM7FjjidY0PiSPnqQ5+t6UYtHSXPlRnGuMCgwRn/zcM7A/xpfukJVJ5AzuDhBJjmK8dhoTjcdkeBo5Jvq8cA+UOXeti5r8CtazR2Tu/hlYrWjNE9Vd0adJu81mU0Y4rMFy4PTosjcQLmRQo+mwKQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(376002)(136003)(346002)(396003)(451199018)(38100700002)(82960400001)(31696002)(36756003)(6666004)(86362001)(66476007)(66946007)(2906002)(41300700001)(66556008)(8936002)(4326008)(8676002)(5660300002)(6512007)(53546011)(2616005)(6506007)(26005)(186003)(83380400001)(110136005)(478600001)(316002)(6486002)(31686004)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzVMb21HN21SVTRWd20yb2IwV2grbTdFTFQ5QTY2VEZRdnA3SlU1Nmo3M3g0?= =?utf-8?B?MU80cDRSK00rbEgxVm1qWUdRSjY2RXRiaEZ0UTBnbjBYNTEvOUFZeFp2Y2F6?= =?utf-8?B?RGNiSEdhTUtuUzFtd1ltY2JFUFp4emxxRjBHT3ZzeDYxREtJSkhaWlNMTkt0?= =?utf-8?B?SURhUk1tbzFDeWwrUGtQWU04OG9jeGtuT0dvalBrYzJhNm5HejlZa1RDNCtr?= =?utf-8?B?YzV6WStTWTljTHJkTG8rMFpiSlZKZHBncFJUWnNmVjczTWw2emJSLzlBd2Z3?= =?utf-8?B?UFZJSm53RXRCcHMyTzNocnM5NHVYbzJ2M0xDZXNTcTRXK3FUSVM0VGdvYXIw?= =?utf-8?B?WTZkOEVEVnNpTElBaXE3dk15TUdUcSsrL2ROL2xrZnlKZ0NlQjBjU1RPUFI3?= =?utf-8?B?T2hvUERUdVU3bkF3cUM3T2xkdEk0ZFVTRzA4Sk0yazBPVGdCWEZHcjkwWFk1?= =?utf-8?B?NFd1T1BIbmNSYnVUQTZwK01HR3lmZE02UnVhZXBYMHNXSXBpRVUwWTJrUmZx?= =?utf-8?B?Z0NtSXNFaGpkR3pJbzVGZDl0dmdPRXpZczgwektNaitDa1BtV1ZrNWVDTDJE?= =?utf-8?B?VGJ1cE9YMTg3dUxCVWZiUjZpZXp2bVZUckdXWWthQmR3Yy9ScFRxaGV1OTQ3?= =?utf-8?B?UnFQSmpmSTVmejBJWTF4YjRRMzdON3A1TE52YkozdFVPMjlmamFFTEhlODFr?= =?utf-8?B?SHdGVk8xZElzS2VYMURhTWJTR1lCeVhoZmd4Z3Q3dS9mVWZaLzhURG9WN1Jv?= =?utf-8?B?MFAwU1FSOVprNXhsSzRuZVZ0OFFiQ3ZFWHU4L2ROM1dVT3BZUTlKNkVPMGVm?= =?utf-8?B?aW12OGo3WkVsQTNHeEZ4RFpEQ3dBWDBoR0dGTDc1RDhmMUZjbnNzLzVmcGVs?= =?utf-8?B?NFViaUw0RzgxV3g0TE9ZRVNLcDZSNWttNTlTc1ROR3FyejMzQjJqVUN6dG9T?= =?utf-8?B?ZkNmcVBvVXpJcFU3VjJGUXVTRHdKalcxS3RVbVMyaU52cjhIL09kdUZ2WnBj?= =?utf-8?B?ZlgxczVtZ0t6cnNhVWRQMUdJM2h1V3pRZkFSdHYvUll1eEozaWxhWTJBVzlv?= =?utf-8?B?bDFXZGFUYS9tMzlKeFdvaVIxSGU4MC93N0FDbXZkWi9EYlVXMDl3ck53aHpP?= =?utf-8?B?QlVyWEozcGUyaW1Fbm95cm9SOTltWmxEampTNGwyM3BSUEFvakRkS1UrcUkx?= =?utf-8?B?K2R2anBUZUIvNEtQaVl4VFc2bk16Y1hXWXNlUDJLbEdLWmo1K2p5MG1jbERH?= =?utf-8?B?QnU3SVdST1pXM0U0Rm5hQzN4T1MwZHRJTGlYYW5VcGowNFVzcDR5RWs1ek4w?= =?utf-8?B?c0ZZcWE1b0N0dG1sMUhJTmREWkRtZTZVazd2SG9QMFRuSFVLK1dUbk8yK2xr?= =?utf-8?B?S0d6WDhMU0xRNC9RZW9LVGthb09NN2ZrZVlWT0ZRUDZ4OXZoVmc1U29STkxF?= =?utf-8?B?UHFoUUt0dUxCWjZZWGxkMy9LNG94KzBzVzR2N084ZHJFWm9oR1JEd2N3T1JQ?= =?utf-8?B?eElPbkd6ZEo4alhjZG9VeCtrNHBvK2Z1ZHpaQm5QQnh2bFo5aGhGTTJ2dWpB?= =?utf-8?B?dlZPM2FvRWREcngwZEpaREhCYWxBaHpxOWZYSDkwc0YrUkJOS3NTb0MvQjQr?= =?utf-8?B?bHRna2FmNzBhTE9nYnFzK1poNmdSNzVvV3JoU1FNNXhBT2VGUDJZUWJzaGNK?= =?utf-8?B?UE43VVJBOUpYTGU0Q1JqWUlIajY0Vmh1YlcrRlBMeUlQV2xIaUE3SWQ5eDFh?= =?utf-8?B?US9pbVJqaUhhVnB1RlVyeTZMeGNUNi9URlBjVnFqRmFheVd4WHJOL0drYVNl?= =?utf-8?B?VVhHY2RPZ1dtVEVvMW9OZVZndFFqa2FjZ3dzWnNuZzBYYjd3Tzl2QndUb29Q?= =?utf-8?B?ZzY2Q3NPRjRGTzNiUEVsV2Y4dm5ZaEg0ZlZhUyt6L2JiM1JnOUdySnNQcGw4?= =?utf-8?B?Y2tYQzJGNkJUM1NDYVVlRk1YMGp6RHlRVXo0M2NRRkxCQ0F5c3BSa0lqcVhK?= =?utf-8?B?dDZLQ2xBNzFyZjRGbmRwVVIrdWNmWm1raG1tbGxlM2VGUjNPb2F4bmVQNm8x?= =?utf-8?B?NklLYk5YVVArN3RlemF1alZvUnp6S1dIU1h3NERpVTQ3L0IrSHA1OVBiSVI1?= =?utf-8?B?VEExcTQ3eDd1ZmxuMnlyQ1NoNHBnWmJTODJSMUhKTE4wQUhJVE9Qc3pVcnVz?= =?utf-8?B?S0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1921e5c0-fd88-46d0-71ff-08db1b8ea6eb X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 02:26:10.7185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WhCFp3jh8/iR6ELwe7yRK0Hshb9YVJd+Ds6suK1arFW40X3FjD8qTLgLAtJMnIoGD4iJrdIfOrYDQDA57+t6Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7496 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: rhi1tzixh914gmgqutoia4zm8qruxka9 X-Rspamd-Queue-Id: AA8BAC0003 X-HE-Tag: 1677810375-82860 X-HE-Meta: U2FsdGVkX1/HvA+J7x0cC1nT2MdFyQBIESODqlkbHB3uqQSxhiouFx1rhukiJyctqjdI9hqkVyKR97hVj8w1nGzcAcv9yMrCVr9uEtFxbd292FPjfnOt/BOSGAOO4/Lv6zQ+xOC93jUw7JBfT1uNVr0rkqX+hPbIQqb5qSK7dCq9iZbqkr3w9egp7YT4xDlvoDNuRBVqE4XvB3UPzP2ZrMGBguodKmXa7Ifwp+5CG3TVvJlQiuLjYm4si2gpW+zN21dEVIxgMn7NpYItsRdk7ngoIpxXsN+iTUQ0eMZjlp+hp7rEhW6JD3sgu50ix0OpvA1hPO3fQhZP+6iuAhTDY5wUvWdarql1T+OHXD6BNMVpHDlhCCq3P7gFYb2KrGDqpGDOTJKb4NyMdVPfbc90m5Vo/uu5/ookfMMZCPqqHSNUM9b09Smo7T9HUVlsczFpFpea2iX22+h3wt0/uGIgMT1eYd5lF+Quxm8lYJCQeybTaWxjHvIoTvX0v5THAlGZLYMoH5LBGxb9s6fgEkgjhjrOke7K3LSG4+yYEZSRx7OBG40YiKcYrwFMrqcb9gjTzMD8a3SJwTWU3WdK/WaIhW9uIlxPqriFt0q39a805lLhFrErz/A44u0ZChx88aWJQHsZsTJEYvea3oUiPUr3hna3ps7Z5voVwV7qtBu+TO9U4YioX1jh9hhhjPRKTT7YH/4eZOxBX2jctSJ9qCL1wSCpcIOd/xpWQ/y6hRZqxSDz2gVWaR1B1jq5a8DwjOuHH9rlPnKy5Bo9WVFBhoim8WTaZxg8ot3TOiNlhN6rqNdfrrDtkoUFEHOfJItzpsnuUZ01bimcqxVBw/hFTDGW+Psz08/k8qjPCZr2GJWHPf/WLfPU0zB0fFoSSEsnAkgC0c5ZlZtiP7DTnXej3qUndprjfwNyUI0XTb/coY7V2iR9Kcgs1GJloQX0JjgQotxCLMvE3qkeWWqO0xBssI0 fL2NqWN7 e+5ayYJ8RplrNBlBTss48YSlQiwW/fy0s1dOABCqbVreHmEiRtUyWv5pGn+d8ckkhTJQeVNwuCWXoYj4UQs40gsRbe8apgHpGaF6I0ouHm2P4g/VWOD23WPZhLjZ6icErmTrW0Gqrj8NYmuBERKZUBgtlPu4Gz3KQgdUVvWKfBFu5Rhbxdr8S1pvz+f5VFmW3GEf6NVjlYzWbFHp7iSJMJvQ7+0Cz2hTzs5/AvD1VraLLG9EkniFqAkyE0nYuotfzfoQed+A1wm0L1W3G9A8aj8Cw3Pr9qqVLhBspq9IIKzbmSCnW1OfmWVw2EmScxhiP22CCigqkHH846PQ2jAFGY5+jAR7YhWX7wUwrbYnliGjB2KrAOKy87LC/sLwdVKaG3Y8QfmPaVvB+PdB8tmU7jYF7Ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/2/2023 10:23 PM, David Hildenbrand wrote: > On 02.03.23 14:32, Yin, Fengwei wrote: >> >> >> On 3/2/2023 6:04 PM, David Hildenbrand wrote: >>> On 01.03.23 02:44, Yin, Fengwei wrote: >>>> On Tue, 2023-02-28 at 12:28 -0800, Andrew Morton wrote: >>>>> On Tue, 28 Feb 2023 20:23:03 +0800 Yin Fengwei >>>>> wrote: >>>>> >>>>>> Testing done with the V2 patchset in a qemu guest >>>>>> with 4G mem + 512M zram: >>>>>>     - kernel mm selftest to trigger vmscan() and final hit >>>>>>       try_to_unmap_one(). >>>>>>     - Inject hwpoison to hugetlb page to trigger try_to_unmap_one() >>>>>>       call against hugetlb. >>>>>>     - 8 hours stress testing: Firefox + kernel mm selftest + kernel >>>>>>       build. >>>>> >>>>> Was any performance testing done with these changes? >>>> I tried to collect the performance data. But found out that it's >>>> not easy to trigger try_to_unmap_one() path (the only one I noticed >>>> is to trigger page cache reclaim). And I am not aware of a workload >>>> can show it. Do you have some workloads suggsted to run? Thanks. >>> >>> If it happens barely, why care about performance and have a "398 insertions(+), 260 deletions(-)" ? >> I mean I can't find workload to trigger page cache reclaim and measure >> its performance. We can do "echo 1 > /proc/sys/vm/drop_caches" to reclaim >> page cache. But there is no obvious indicator which shows the advantage >> of this patchset. Maybe I could try eBPF to capture some statistic of >> try_to_unmap_one()? > > If no workload/benchmark is affected (or simply corner cases where nobody cares about performance), I hope you understand that it's hard to argue why we should care about such an optimization then. Yes. I understood this. > > I briefly thought that page migration could benefit, but it always uses try_to_migrate(). Yes. try_to_migrate() shared very similar logic with try_to_unmap_one(). Same batched operation apply to try_to_migrate() also. > > So I guess we're fairly limited to vmscan (memory failure is a corner cases). Agree. > > I recall that there are some performance-sensitive swap-to-nvdimm test cases. As an alternative, one could eventually write a microbenchmark that measures MADV_PAGEOUT performance -- it should also end up triggering vmscan, but only if the page is mapped exactly once (in which case, I assume batch removal doesn't really help ?). Yes. MADV_PAGEOUT can trigger vmscan. My understanding is that only one map also could benefit from the batched operation also. Let me try to have a microbenchmark based on MADV_PAGEOUT and see what we could get. Thanks. Regards Yin, Fengwei >