From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C804CD2A520 for ; Wed, 16 Oct 2024 14:46:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6623B6B0082; Wed, 16 Oct 2024 10:46:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 613006B0088; Wed, 16 Oct 2024 10:46:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 501436B0092; Wed, 16 Oct 2024 10:46:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 282056B0082 for ; Wed, 16 Oct 2024 10:46:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 27400ABB69 for ; Wed, 16 Oct 2024 14:46:02 +0000 (UTC) X-FDA: 82679740752.24.05F25E8 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id E76C940016 for ; Wed, 16 Oct 2024 14:46:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729089947; a=rsa-sha256; cv=none; b=bZA4lTNYL+6BZodbnwusIK8OwoapgbdPG+RAlZFUwIbv2PoY+MLYIXL1GwLC4FLVJJX95R GtqJ6HlcYM9iEr7Gm2iIjBvX5CKFgGTRBxyM+U9cp/rRMv1sf8t1w1oi9MuGPEqXKaVRYB 3b9yBcaYlLROgRUqTwJ8WzGtlYRugJM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729089947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gE16HBn92E+T84kpg1fvLexWOrEzAz+UTTnBAEOWf98=; b=zUbrAcYObXG3lLAvDEvBlvxCxVGwQN/eKG/vaRTOrO0pi2AlOb20mktrbCPbFD198vz2Ni DkBq31OwhjGO59xekABuYZn6SOiFbkuDS5Zsd/NhUFjtrEiFrpoo9bVvyB7G7cAuJKMvL1 tr2him4dqq/z/zo5nF4bsreUTagVkxU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 273EA1007; Wed, 16 Oct 2024 07:46:49 -0700 (PDT) Received: from [10.1.28.177] (XHFQ2J9959.cambridge.arm.com [10.1.28.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C949F3F71E; Wed, 16 Oct 2024 07:46:16 -0700 (PDT) Message-ID: <1bd243ce-12d6-46d7-89d3-816fb58a4c95@arm.com> Date: Wed, 16 Oct 2024 15:46:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 31/57] edac: Remove PAGE_SIZE compile-time constant assumption Content-Language: en-GB To: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-31-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: <20241014105912.3207374-31-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: yu6k994pnez3uzojrqhh4qb49ysr9bfc X-Rspamd-Queue-Id: E76C940016 X-Rspamd-Server: rspam02 X-HE-Tag: 1729089975-323561 X-HE-Meta: U2FsdGVkX1/Y4v0yCwhOt2Pn0fdUlnaFP5xC3YpFUUQ+yaIVjg95IJGb7F/5JWNE0Z6StezthKvLlTzghx/xDLZ9oOqL3vgswHGshsLTlvUcqU0K/8ggGf0IF/vOZbrj28UNvvTK3tX1jgCSq/vBeol7FAIn6OO98EWYu1YQUc779fBKgFVOS/2IREANtiuKDGyUikw1XkfoR86p1e7wfNugo+iYbFOqDE9EJH+L2Ly4DiGhFHRUGBL4h+jfw93YIyjI7zqvsZciIezB8cMIvlXIYVZOLUw6noRKid1oendAC/msSLsC7iFnhLh1X7uzJkDnVtziR64R6C08l0dXs5OhNtKqWNADmXvaR7+FFvWukOMvTNtW5kKtsUCtB6/LpHjppL5C8LhRS8Q8JYXG8Hm7HVhk06gD17txXruiClcngKTiNexYElh2enS/odKYh/30sdQApCzTYEvaJup6DcmJDmAn8f9Ii+pbT/o8svPMS14Evoz+h7QnIllfd/avPpf9SdByl9LuqYbdrg21VtmUOKn8uJD+ah3RFM6x/MTkqbAob6EXtbHhhzR16vj+ptJi+/7G2iT5WNAiDVnMU56qbuj+Boo2UyMk0KWfKpjNjhEz0ss+K6/nPIQlT0l3wyhqTJkfZ/a1yWo0UgEltvUMpgrqjJEr6qGqM8iE6aOAhGPw5XTQiywypKRnc5YUqT1XGrNawX2V7MCtbqqtLLpyakX1OsFdcLDgReu3cgeJxl+NQjEbYeP+lOWqpYvhhWArAu+9bsvHVi6tBikSpmrXGIZLEB3oepfwqRCAaeEe8INB/XfNJjEJCNJvGCJfoGmR0qqfGO9pjW0iNemnw7XyD6XpqA3dTlfsU+sux9dHOCQ0k2Ic3RcNteb3X+z5+QcLmqYTYcr1/gNuQhQrImf+bvyF3hXlWTUZ9f7dHdYctg9b8+EgnghKiUNqE2HtpHpmZPZwC2GchN+XP0O rYYyE57H 4mhrMUz/fBNIqnJ1gORcvRS2jmEL2pFKjraPApapWq54Jbvmh74FYBmrsWBBMMn9TUTOhnRUPf98HZZSlwMB3KpbeZ3zuufJ4wvB1FZBeGXgcsYqLJpUNB3O/KqytV1IiCj2PkJoV2dp1Ojf3cEz1hoMncohWg7dq5IShHNt4MdweTH4MsvpkSP2I8zx5tsyjcoin4OctbKbBZcGGiY0wrY1zT851HIsYFBZLxo+h7nY0bJxf4xMzhTG0NmZNQ1un14laRX/RexCwIPbeOSiIgTD+eQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + Borislav Petkov, Tony Luck This was a rather tricky series to get the recipients correct for and my script did not realize that "supporter" was a pseudonym for "maintainer" so you were missed off the original post. Appologies! More context in cover letter: https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ On 14/10/2024 11:58, Ryan Roberts wrote: > To prepare for supporting boot-time page size selection, refactor code > to remove assumptions about PAGE_SIZE being compile-time constant. Code > intended to be equivalent when compile-time page size is active. > > Convert PAGES_TO_MiB() and MiB_TO_PAGES() to use the ternary operator so > that they continue to work with boot-time page size; Boot-time page size > can't be used with CPP because it's value is not known at compile time. > For compile-time page size builds, the compiler will dead code strip for > the same result. > > Signed-off-by: Ryan Roberts > --- > > ***NOTE*** > Any confused maintainers may want to read the cover note here for context: > https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ > > drivers/edac/edac_mc.h | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/edac/edac_mc.h b/drivers/edac/edac_mc.h > index 881b00eadf7a5..22132ee86e953 100644 > --- a/drivers/edac/edac_mc.h > +++ b/drivers/edac/edac_mc.h > @@ -37,13 +37,12 @@ > #include > #include > > -#if PAGE_SHIFT < 20 > -#define PAGES_TO_MiB(pages) ((pages) >> (20 - PAGE_SHIFT)) > -#define MiB_TO_PAGES(mb) ((mb) << (20 - PAGE_SHIFT)) > -#else /* PAGE_SHIFT > 20 */ > -#define PAGES_TO_MiB(pages) ((pages) << (PAGE_SHIFT - 20)) > -#define MiB_TO_PAGES(mb) ((mb) >> (PAGE_SHIFT - 20)) > -#endif > +#define PAGES_TO_MiB(pages) (PAGE_SHIFT < 20 ? \ > + ((pages) >> (20 - PAGE_SHIFT)) :\ > + ((pages) << (PAGE_SHIFT - 20))) > +#define MiB_TO_PAGES(mb) (PAGE_SHIFT < 20 ? \ > + ((mb) << (20 - PAGE_SHIFT)) : \ > + ((mb) >> (PAGE_SHIFT - 20))) > > #define edac_printk(level, prefix, fmt, arg...) \ > printk(level "EDAC " prefix ": " fmt, ##arg)