From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD3EC04FFE for ; Wed, 8 May 2024 07:48:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 517A66B0096; Wed, 8 May 2024 03:48:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C7CE6B009C; Wed, 8 May 2024 03:48:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B6256B009D; Wed, 8 May 2024 03:48:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1EB426B0096 for ; Wed, 8 May 2024 03:48:04 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8F2A012101C for ; Wed, 8 May 2024 07:48:03 +0000 (UTC) X-FDA: 82094450046.01.AEFD79C Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf21.hostedemail.com (Postfix) with ESMTP id 6D4D01C0011 for ; Wed, 8 May 2024 07:47:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715154481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfzotuLsO2ka6XhWuVpF/P0kM8+dEViD92BTiGCBPS8=; b=5zFqAWCNdODMH7FzlIPZqJJWOrxFjqxpRhuL9sDr3qTHUjy2gh8jAAvWmESXnysHH8sQeb sgFfS15A8d/+scdrCEgv0pF2X52GUf03/a6KpIV0/CANSZ9HXghhgol5tjUuOLVnV9c6e0 VySIa/IUOjXTCfuXPIY6aC0OEOGQHEg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715154482; a=rsa-sha256; cv=none; b=BQCL7eFs9xex6GtArxhmcgncu3iYit3aWiBKAHwP71qhaMLg6Ti3OZod4JOdXmBMKLock7 2fdMevvEjXrT2icdeNV0r73Li70m+fRJOjua185CaHbNn0bUDr0M5+h23XC93012Z5MLng 79A091B9FYm0leH0j+2LOAEzMjUzjfs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4VZ6ch6wsyzNwRV; Wed, 8 May 2024 15:45:08 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 9119F1400FD; Wed, 8 May 2024 15:47:55 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 8 May 2024 15:47:55 +0800 Subject: Re: [PATCH 1/3] mm/memory-failure: try to send SIGBUS even if unmap failed To: Jane Chu , , , , References: <20240501232458.3919593-1-jane.chu@oracle.com> <20240501232458.3919593-2-jane.chu@oracle.com> From: Miaohe Lin Message-ID: <1bc8c5ff-1452-11d3-edee-9f45a87015a9@huawei.com> Date: Wed, 8 May 2024 15:47:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240501232458.3919593-2-jane.chu@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Queue-Id: 6D4D01C0011 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 35cfqf7nhkdafhrqmg3uu886btuf1prq X-HE-Tag: 1715154479-14819 X-HE-Meta: U2FsdGVkX1+2niAZ/IU6YdgCLKgbeZcPHAbOTEE4MRVfvnh2mHdjLK1uJdKMOyxa+MnBq8SDDapKy+niwRr92GMjtMkPoGKwMm+PE76o3HjqxWduzpo+U+l4KKi1Ja+GvrS/GppUAraGijtzv9MyL/NcxVqbFy3m2k2sN743XNJbid6xYiXew+ANNKly/xfMyZuxesVfJ1tsEDOI8yfF8Zz7zL3pEtCKEdk+BGvm5JRN1zJwA1WHHW3Hi0FN85BkgTht/4Wq2dFMw5CVwkjBbGY5OQHP7zMqIKcp90gFwZf6Qjclt50GShPrgPe8PyfjkvBvJP55tbN/5FTTnVfeZoLmkNLLyWvTgY8TMh8CF8sLcltukYDkMyHmV6jB5HElor9D+aiQGPxJQsb2U2miXs7Bi8cZ0Ti8dXfU0OTZIoUcg0jIw3MtpLkAOvpqtD1m/Mvj0Fw4m8ttIydn+Siv+YcS2qtxmQTGHG0FcQ+E3jFWmUh49rXA2Tu+OPKOtG7bHSutO2m3uceLn6o0+pJPwHE+FV2sKqZBGSlgUisYQN8vx/LYgZi9B/Z3GcpA2w0FZTKzz5fsKVLmJS2fWCkjGw2KTA1lC2ZjnvkVeHDOlzGoA3s1Zg+9OYgPVNK7xi2MrQaJ36PMZ+xyUItE2GjL6zBzUvl89QdyI06eKZ2jrrJGz9WLpoVjVwnfQeYRNBWH9g4WZpeb0KvCvbapU6+V6YsIHUsII3rwbT12Q8+0uzPRJncYaJ05Ri56M+VItvlQ2b9Q6jeO54o7ktig/Pa4OtlITNGDK7zqbXd+BasX+pQkmT+3kK+fyfWXn+9c5rv4leaknr8v7+boAB42qNelmtnTvP3438eDbKPj/Rudvod3J0JZl5flHDbui3oxLZ/mvDOnPfGQL8rmqQNu/QA44/ONSe+w+gDSbZ4EMYLDLOIuGE8uEaiP3du1syuT1Q9YIpeCsjSIMDt3WP1Yx86 4uxx2oik Ifc0P/SuP+SHIkXRqgKRzSSMGn4ELPdqihOlY6akbsC+7kYVqjDOpu1xyt1RfsYh+lwRR6YsS9VDFJGp+ERX3BrTDan8KqNV6t5BmtvJoTFRQBjES87fYXtjEwUHlM6A4PQEMBlYrfHaNPeVtp/O1sc5yEpHqdKnzcHG/gMsAMS4XhtHLDVBMFWy96yz1/PCa/uUxgC988vMY7GGw65KZSZDzZwRkTFoJq9cD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/2 7:24, Jane Chu wrote: > For years when it comes down to kill a process due to hwpoison, > a SIGBUS is delivered only if unmap has been successful. > Otherwise, a SIGKILL is delivered. And the reason for that is > to prevent the involved process from accessing the hwpoisoned > page again. > > Since then a lot has changed, a hwpoisoned page is marked and > upon being re-accessed, the process will be killed immediately. > So let's take out the '!unmap_success' factor and try to deliver > SIGBUS if possible. > > Signed-off-by: Jane Chu > --- > mm/memory-failure.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 9e62a00b46dd..7fcf182abb96 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -519,19 +519,14 @@ void add_to_kill_ksm(struct task_struct *tsk, struct page *p, > * Also when FAIL is set do a force kill because something went > * wrong earlier. Since @fail is removed, above comment should be removed too. Thanks. .