From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF09CC35274 for ; Mon, 18 Dec 2023 17:03:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7300E8D0002; Mon, 18 Dec 2023 12:03:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E0AE8D0001; Mon, 18 Dec 2023 12:03:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 580368D0002; Mon, 18 Dec 2023 12:03:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 465FB8D0001 for ; Mon, 18 Dec 2023 12:03:15 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F205FC072C for ; Mon, 18 Dec 2023 17:03:14 +0000 (UTC) X-FDA: 81580559508.09.7F4AB45 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 473B44002E for ; Mon, 18 Dec 2023 17:03:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LkHOpNPS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702918992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/1DYgIzwVVHIUTBZRQm0/j2Jm2pykqS7kpwFWrYvsHg=; b=ydRbUIfOaAyO0npEGX8XGbNo08DbsjqkUjgBYqPcDz4Mz82jJtvFTcknWGbexoF/gTHxpx oYdLCDzmImo7xmukSXSJf6rigQehQOt8CtUQqnXU3oiSivRNANoYzbdO8DurtNuCmnzjhK wzrB0JATLsMEJGUXEP0ViiJIzJ0Pj/8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LkHOpNPS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702918992; a=rsa-sha256; cv=none; b=S8GOYy2NHH0vepe9RjpRkjWo5Pl8EGrqh2dA8mcMalh/ACVvpUTigJFAxIxG1lSOQYe72P rGEm+vgFPD33kdv7PkqoyxdgEF33tdcEhU9CDp0sEtfs9U3+22yJcM9ygPfJdpaPlZ4ZJE EBSBI73t6EO0Ffwf1lkLOSHp/22KbjM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702918991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/1DYgIzwVVHIUTBZRQm0/j2Jm2pykqS7kpwFWrYvsHg=; b=LkHOpNPSh2T1dfVGyHNr19V7YHtPBrKNhAyCmMProc84Rj+DA2xHqQQXeEppibNw87yz97 edTPRowKcZRfnhUNHZevgEASvq+BKyedhdC1wgFQX27FAyiMD1hq6/m74KwaK2JLe6nYZz 6VGqdmQ41w58+iFQENUpqEggOu3G2FE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-YlglguMvNPKgn-gn3sQd_A-1; Mon, 18 Dec 2023 12:03:10 -0500 X-MC-Unique: YlglguMvNPKgn-gn3sQd_A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40c49cb08fcso25406965e9.2 for ; Mon, 18 Dec 2023 09:03:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702918989; x=1703523789; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/1DYgIzwVVHIUTBZRQm0/j2Jm2pykqS7kpwFWrYvsHg=; b=RGB4ChfvRe93mZUVS3qILf97lqc6zRP6BfyFLtW+aHBncZCoSq6wkRvyeKUTKC+/7t ct5qKj+kN75Nq0cv43KAOG0KcbW5xhnCE1xuCldpCorlVxTZudnDbO5i3m8MN4lB8QHG iD5RhBAOp3pVZKhQYj5J8nPRdew9FdUXbvvRw9RfshLHmAQrnA+EqI5SE7DEDVq71DTU KNDq4N3UUfxJ9N9huCscUCvK/2arvq5ATOrpzG/Rjc2u0t+Uee0euYIYa2ZDrzqHqFAO WBCQqq6IGZM347JXe1HP93T4bW/fJuxOE32RMc1V9kdmAFCB/G3hONTFq4GAi4P0xET8 +jew== X-Gm-Message-State: AOJu0YxUrTxORB8qPn4WVAiOQweg5bsmiTAXJb5T40Xunx2g6DbwRkSv 9RjWixfKL88Bosk56isYd3eBzjtcWuC/Fn9vLfupmtasQlf0JvgvFN2dCWyQo2v//JQy1veIM2n IXBVBRzeO7Qo= X-Received: by 2002:a05:600c:3556:b0:40b:5e1e:cf9 with SMTP id i22-20020a05600c355600b0040b5e1e0cf9mr8065257wmq.52.1702918955250; Mon, 18 Dec 2023 09:02:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdWKo7SLZ9qZLZpwhuUfjr9X4Fxt0ethpIWz8nctSstfE2W+h8Ym1LbLSHz0CF+7lqYWIz0g== X-Received: by 2002:a05:600c:3556:b0:40b:5e1e:cf9 with SMTP id i22-20020a05600c355600b0040b5e1e0cf9mr8065077wmq.52.1702918944886; Mon, 18 Dec 2023 09:02:24 -0800 (PST) Received: from ?IPV6:2003:cb:c72b:b500:b53e:6e32:1408:27ac? (p200300cbc72bb500b53e6e32140827ac.dip0.t-ipconnect.de. [2003:cb:c72b:b500:b53e:6e32:1408:27ac]) by smtp.gmail.com with ESMTPSA id e10-20020adfe7ca000000b003335ddce799sm13919144wrn.103.2023.12.18.09.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 09:02:24 -0800 (PST) Message-ID: <1bc53fc1-fdf0-4f4b-98ab-bab53384b765@redhat.com> Date: Mon, 18 Dec 2023 18:02:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 14/39] mm/rmap: introduce folio_add_anon_rmap_[pte|ptes|pmd]() To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231211155652.131054-1-david@redhat.com> <20231211155652.131054-15-david@redhat.com> <593c4eb0-e430-4186-a95c-9d2ebd91235c@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <593c4eb0-e430-4186-a95c-9d2ebd91235c@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 473B44002E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4ubezuzuimr1uxfeib85pqf8htukcndx X-HE-Tag: 1702918991-492989 X-HE-Meta: U2FsdGVkX1/MBS+7r1fsID6XSkMGv4xKHJRBqaga8CQSJ2PdUb0fdX/Ek6pawQbcN8mkX0UmR6diZqxs27RRH9RF5FfqVRi+18yXGESD7ydgo48edLNUR2/HpgCHqq/7lqnomV/iT9XXMw1cUaoXMp9fPVzYaQXdwMxmH2XWyvh10sY/TNr7ePuohY2Xl98+wZSr+tYWHd0355Ws8Of5uDvimCaLdbkX0hBeYgLbzJXbebdzVcda+oyfLhCLkdkea7z6Yuk/O11FvuH5oa4Mq50Lxe6E8zMiyzsjcyaccwIpEhBA+iRuHEm6otzuWsep+LaVZfDXq/SJg8uXMXHpi02IU2V7Ww1rx8EOaKCFcDwpOpGRBf9vMOWNnzGUXR+2QjjtcaY+MFgbMLy6zMt99wx/CUwqsaUGHWXdWrGWH5hLT1b1FYCJ81mgTXFqTg97rQrz+v6fOki4Johkzhg81QlkhLCNcJD6D3IvDSNt4Re/gykY7lW0ymEMx5IXGc3Vj00DkPwdjibH0ztoRAZLFLvbsr1gKT4ANXvHzP73uthGBVFPohrzwwONwyqbhrE9ZNa8NNdPDCUL9azHxkSWw3b8XviCz3dDxdPRzY/+Kq4um1BYImAMzZOeDVvllLvfKw+zMZzwW8ZPCSitI8413RJr9aBw1kT4TuJD/uDwZ8p5GA4wWqIiUcgIGggzaoaPgc+MwmnmmJBpbeNCjmrgoybzMaFEfyu7PSsYvkvElQS8cPJACwSJuFb/jFKSw+0SYJHVyk0QeHaOWUSFt3QlPz2Pkwm2Pn4rSBCZKyiO6NU/kHZTf3SeqcOJ6qnRFaTsJDCVwrN+M+iPJONlvGzsUzxoF5qn7gmwKQzssH3DkjTyalkjMZQVwzphw0/tmcSIx7wRWIkchrpr7pfKCkg1EFdoTeM6vS2THtYNkL3Y69BPWw5s0VazlYOVzlMYL7TJtKEx6rlUVM6bDxMdeU2 kyI99CXT jLVQbJG381XHbrDbAcm+2tZkVCvIhrxP81VBqscHExEY3T01KGf7B4AQ29YOwnMk25qdp5rBqgN3SN8dqc44VwUPCkn7DF52FOXLbHuNmvhYKFf7+QpSSoyd4LTfGyjC19tguCPt78ddPJscxK+AYBExVmy59dkVMpsGWT05KIhv15JA+Jw+QWkAPOjJytlxINtA9j5zjaCtM6BiNj78rPDeYdTWxpHfRUGhpufxIYPTN3M8VahfRzG8tQLfcQ82juLCi/hPC/vEWRhYywLM14dpBEXZXZs+5EU3XtQb7mlI8h3SrGKF/06VyFFh3pqZ43r53dAuBBrzITBx96rwI7GWubRLmi4+nHDChv3eyAolakVJjXHnVaGVcyST7TTOVxPDG7n9vlrzxJHwR+n4BAZ4Qocn1b0PmrJeq0WDLakipiQMAYK0QbGenbq1JfvC9BOlAtNLkZpjbXmN/ZSOeXvzs3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> - if (flags & RMAP_EXCLUSIVE) >> - SetPageAnonExclusive(page); >> - /* While PTE-mapping a THP we have a PMD and a PTE mapping. */ >> - VM_WARN_ON_FOLIO((atomic_read(&page->_mapcount) > 0 || >> - (folio_test_large(folio) && folio_entire_mapcount(folio) > 1)) && >> - PageAnonExclusive(page), folio); >> + >> + if (flags & RMAP_EXCLUSIVE) { >> + switch (mode) { >> + case RMAP_MODE_PTE: >> + for (i = 0; i < nr_pages; i++) >> + SetPageAnonExclusive(page + i); >> + break; >> + case RMAP_MODE_PMD: >> + SetPageAnonExclusive(page); > > Just to check; I suppose only setting this on the head is ok, because it's an > exclusive mapping and therefore by definition it can only be mapped by pmd? Yes. And when PTE-remapping, we will push the flag to all tail pages. No change in behavior :) -- Cheers, David / dhildenb