From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8CB8C48296 for ; Tue, 14 Nov 2023 20:19:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 059AA6B0312; Tue, 14 Nov 2023 15:19:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F24FD6B0314; Tue, 14 Nov 2023 15:19:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC5466B0315; Tue, 14 Nov 2023 15:19:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C98876B0312 for ; Tue, 14 Nov 2023 15:19:39 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9DACEA0297 for ; Tue, 14 Nov 2023 20:19:39 +0000 (UTC) X-FDA: 81457675278.20.B331ECD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf30.hostedemail.com (Postfix) with ESMTP id 33AFB80003 for ; Tue, 14 Nov 2023 20:19:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iu/6NjlV"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P7RIBxhu; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699993177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3thwfoQDfeifa7EY/gfWpuitk2l6esZhSluo1Ku2wH4=; b=Qjgk9dVeLSdXQwi292ePQbdAog3EMCYoWfyBiyvSPsWl3u2HQcsFRQlBAROt4joj3GEJyg UWMsiWjcEZJEZJYoYHrdXg2QapRmcm60idxGxrdk2t8SHGHpjkK4RGHGO51fn9V5PjlPON F0I+KNNajHzWZ4RARzud8XMHgol3Lps= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iu/6NjlV"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P7RIBxhu; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699993177; a=rsa-sha256; cv=none; b=ztyKlcigXWvd97MxOwhC2stq66sMqsOkvnnjG1TzpYbb7tM9J6C9TTa1eQqNsAwlWwBxuV Tu3rm2B0ETveJILb0UsmXmaJCbzuIn0HVK3llyUtq429hdtYcq1LCfoK6o/YEa4Rvfh3PA eCuHPxLtr+5KOT3koaBYXSyuvqvZjZI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D3FBE204B3; Tue, 14 Nov 2023 20:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1699993174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3thwfoQDfeifa7EY/gfWpuitk2l6esZhSluo1Ku2wH4=; b=iu/6NjlVN5NFSilQN7ZoYCJuLCC3uVthk+mX2QuFGTo0BmAGYlEQj4aln8tcDpKIT+k3zm v9HAotOdzG7LGEg/MA43shkitx2zL82zmSjNLu4chRkCCovphjzrQ5fmLdeaml0u1JZ3I+ mTDZM3fFmZEO+KgCT1Qt5j4LrI51LIs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1699993174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3thwfoQDfeifa7EY/gfWpuitk2l6esZhSluo1Ku2wH4=; b=P7RIBxhuxDjqiorpec9tzG+cqKzjTW8Zpdi03dqBmIoScedR1cQKItIwWfXg5+iIGHxZJ3 RXbxtXDF1YHa7IDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 86CDC13460; Tue, 14 Nov 2023 20:19:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rTEeIFbWU2VBXAAAMHmgww (envelope-from ); Tue, 14 Nov 2023 20:19:34 +0000 Message-ID: <1bbabb8a-02c8-7247-0084-776a32558130@suse.cz> Date: Tue, 14 Nov 2023 21:19:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 06/20] mm/slab: remove CONFIG_SLAB code from slab common code Content-Language: en-US To: Kees Cook Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-28-vbabka@suse.cz> <202311132024.80A0D5D58@keescook> From: Vlastimil Babka In-Reply-To: <202311132024.80A0D5D58@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 33AFB80003 X-Stat-Signature: 59xpiacw1895mhptigqd6e7f787kxxr8 X-HE-Tag: 1699993176-784843 X-HE-Meta: U2FsdGVkX1+UXcVSaZtYVip7P8CrwvgT4lEmjwbD68Z+rfoB0TwkdyMN/yL+qJIIta3eGyPTRW11q/Z8A7sqUMZL8Zsl9yC9tvfYTro8r4GPUFCTGjor6j2Cb9/81cfD6pmu4NBgSPxqF68LrlRXHFccxz67f+tWmkZpLabJufTOv+5DwihvjkiG38X9x5+FkKHOYPSD3lO7jNxvncPCgpENLWkMMnMnX69C74lyBWd1zfg/oVGzzUT3UxfWPowsfVHvPaJBj/PU0oJHAAaHokQuuWdKd7iG2OhPusjjlAEk8qusHdLfGRUYhnRORKOnVgsFDbzjEccyf8ynkms2YxtL+e2lZcznvLqtMZNSqwvNtkGMwt/kxrBL4g4NlRYXgntifNniDPsU5+k0MWD6YMNd0OFKZpmg0RCdE63zTpiarHaUYuuWxyN2mOUYyaydokdvcwmpxIoPmc99yC0jKXAao11z0GpthhMRcIDKRjLT4QxvBggl7nx1BYEZMKf0ZR7rZBwS5gJpkid6gdD2YCXYaaPvSPiUhL/XnxqQ3lLJov8oK4mvPhz72eTmnpHyQBMRcs2iAh6Pz6hEKlsrQBwcgx71IMDWL1ymn9O48Jcasrl9WGHsnv0UqX9/jvg7sZ5alROVSb8X7vI+dxDVDBO/8dQf2SlQj1QAjIS5BtcN6NUnRxZI5muiHYFOBs/ro/n/RKF2QMShBkCPEyvOzq44jbWxxr0R4oXxNkBt3eZGM3ztirkSClXTzB66knkiMdQvxzkLyhmTrJ/F4i9ArZkJnQYQ1OeXFLSryzns9LhO+wIyUhkVVk5lMuSUx3ZwUbaCKlDBUgq5lAqtRgMK8w2Hq5L/BFnwo7dhy8/sdtTguI1uzMG8OYnZg50cA6YhKJjjf475BpyhflHxJF0xt2Gz/SxIFjVn3qLpLKxnR0/4YktOy24CrxdxMfd29ZbsWQwywDUkxf8sNc383Qb 78O00EbM mu1LTdLcopcjaqEb7TPP8Pdf796sk40cPVLIrr/lTgAqTc5PWq+b2uh4jO9jsV4V4NWXRoqIY7zn+uGZBn94XerkCcleUWgQfw2bJsQxf4+HtP1+YNKaTi498915GL1u+Y0WQKUGWXQvlXv6c+L2WJBGIiTo8sqiS6d9FZ6LeoxKqXjf8vIHeKCqivwFLAZJOcaAiYBQYGlHv9V4zW7HmtlmZezhjALa1O5LkBGYKQnSa4E1uPQHsr/iDU9kZDI+tHTIyrOMdqRUz+4If0f3A5gL5GESYLOPnRKXt8GCJ8iF8CFaI4+xkfpRigGD0ed0QXOQaNvxewvrbW+I13MqZIxT8uWeBRMlOA2MlOMCR26/Mg4g2T/3HNix6Bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/14/23 05:30, Kees Cook wrote: > On Mon, Nov 13, 2023 at 08:13:47PM +0100, Vlastimil Babka wrote: >> In slab_common.c and slab.h headers, we can now remove all code behind >> CONFIG_SLAB and CONFIG_DEBUG_SLAB ifdefs, and remove all CONFIG_SLUB >> ifdefs. >> >> Signed-off-by: Vlastimil Babka >> --- >> include/linux/slab.h | 13 +-------- >> mm/slab.h | 69 ++++---------------------------------------- >> mm/slab_common.c | 22 ++------------ >> 3 files changed, 8 insertions(+), 96 deletions(-) >> >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index 34e43cddc520..90fb1f0d843a 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -24,7 +24,6 @@ >> >> /* >> * Flags to pass to kmem_cache_create(). >> - * The ones marked DEBUG are only valid if CONFIG_DEBUG_SLAB is set. > > I think this comment was wrong, yes? i.e. the "DEBUG" flags are also > used in SLUB? Hm yeah we could change it to CONFIG_SLUB_DEBUG. I deleted it because I didn't think "valid" was the right word, they are always valid (part of SLAB_FLAGS_PERMITTED thus not returning -EINVAL on cache creation), but they would be no-op (not part of CACHE_CREATE_MASK) without CONFIG_SLUB_DEBUG. So we coould change it to e.g. "The ones marked DEBUG are ignored unless CONFIG_SLUB_DEBUG is enabled" ? > Regardless: > > Reviewed-by: Kees Cook >