From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16EE1C3DA4A for ; Thu, 22 Aug 2024 17:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B4D280045; Thu, 22 Aug 2024 13:24:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9656F80044; Thu, 22 Aug 2024 13:24:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8068980045; Thu, 22 Aug 2024 13:24:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5F2AC80044 for ; Thu, 22 Aug 2024 13:24:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0DE1CC1667 for ; Thu, 22 Aug 2024 17:24:23 +0000 (UTC) X-FDA: 82480555206.24.7204A6A Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf01.hostedemail.com (Postfix) with ESMTP id 5976040009 for ; Thu, 22 Aug 2024 17:24:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=Sjtq0vYd; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf01.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724347443; a=rsa-sha256; cv=none; b=Fu9rbvX79YpvLvzJUf6XPjb3U5C3FXoEUKsvhcXLDTFoLDi59iij+E/g1qj7gZWmM/n2wT IYPt6mncZQEZq6zTe1fVGDt2xSqrQDgFDQn01NPKzUIuzNKrdxgvSxL4xxZGOqTSt2kCwX Oo5Viod/BMbJgVlbNEdJJb1IzNMtfdY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=Sjtq0vYd; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf01.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724347443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BqvlomoQuGgKcLCkJbBGkUc1aYljHC4hmHRvnjjGJ5c=; b=geKHDgWr7UF51BnaPPL+qXPkz03rPrPlJpfaMVytOPnO5KkK3xCjJ0V8MaGzQoh7mslQMH 4G6oAQBnRaF6p1L2Kv1Wq3ogxXc2vDUtJ/Gae/+V2W+pqJCxHRfUdVKSlf8r5VvwleWG9h y8eFHXQ65MZ/scdUc96wfRmAXAb4MuA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1724345969; bh=BqvlomoQuGgKcLCkJbBGkUc1aYljHC4hmHRvnjjGJ5c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Sjtq0vYdrH6sY8E4bhOw4s6ztKj182MKxE7+j3YsSroNcNgKrDasOntWEOmVg7N9y KJYxXsa3PvweT/g89KbTgypcSpgZF10BE+xSeR70U5HQqIPM3PhrCt+RTzYEV7eIJm lAZQEdnit1P9uHM3K0JqIIh8bsN4EurQrW737iVk= Received: by gentwo.org (Postfix, from userid 1003) id 1FF864035D; Thu, 22 Aug 2024 09:59:29 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 1ECD640253; Thu, 22 Aug 2024 09:59:29 -0700 (PDT) Date: Thu, 22 Aug 2024 09:59:29 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Yan Zhen cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1] mm:slab:use kmem_cache_free() to free In-Reply-To: <20240822022704.1195439-1-yanzhen@vivo.com> Message-ID: <1bb9fcbc-310a-ad36-9e96-61dc80681f12@gentwo.org> References: <20240822022704.1195439-1-yanzhen@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Queue-Id: 5976040009 X-Rspamd-Server: rspam01 X-Stat-Signature: rca9r44g198bd9qefudemmsz64k7gjpj X-HE-Tag: 1724347460-791665 X-HE-Meta: U2FsdGVkX1+aJCCh6xiND5iSC6wEtPRnpxpq1xAJSaI/HDtkGrLEMFuIneTpT79Z0UTnizvWE8qaHIry3KBuU7xIwKF+m951yTIH61bZI5ctWLqaAdw7rX8KoqKl0uuSc8sdszB/gLD4wsBIdQHX/LXSCrTBr8xmj4xWYKpYNUhQOaYiiCBw0a1ldZYJ7ImHTV4we5BoeKZi8y4TpCBT+q1iYDZA4x6E7QbAXfJEUs6NGOcOpIWmnwgM7J8mTlmCmcp+Kv06QTikzOkEla4BMnUCxFvPZhK51NnBuCY3wQhI0YKtydwg2YpjU8JdmNHSP1ZnQiAvpXuVPJl4Om8oJzPv/bDWFNw7GDQ6rg1ZNgUWHJr/URSg1QMbmw9zeDbkpPesFgJgCfsF3qkqwy+swzyZc0BoJNL67XVKzgPCQ/OULalkVYE+fajkSfRtu5TFmdtqH/boEy2mb/NDJFh4ClHfeen7ud3kr2EEKM+wsayAxfQ8H9wNktXHfOQ0TXHaVnGh8yZfG+rRwQtNptfuL+T4YuBgOhuId4782m8KPNFKgQkCxHY2ztSVR7khyL5i2krWRQZtWJyElixbTLZG+dpZWZTjThoun8jyGhdfkxTfMh31x57Qr1jv6NaNDY48Iy+0YjaSW7pq6DFhgA9yg7HtHcFT7dtmVTQfImmL2NFvp928Tq1HdL830PKK83IbhzDgXdYnQoYrurkier3OU6jzmA8pjcJ80TvyR/Dn6iiWyiV9Ux5Rez6U+y+rkazhgwrEL7MTi+d7Vs7on1ZUoAV36iJ4Rr3eorFWfKJyCxHWuoFqcKbQl56XFOu3Gu3dCoNGZzW4tplMVCyChIeOI7BNbfi53hkMgN4Vz1x6aIwN0S4D+gd94UprFrq6E9qFOA8c92sZgWUuglFGDGZ4S6CKAl+Vbr1f14Dv9XCTrFhNmXluKNS5JFFulJOGSQsKssSDvtTKut5UL33yuRY t/alXqCk Wf7NpCZEwxBUpi0kRlOEj5RJV42/bJB0N3oG+Rw2GvV0Dsd1lG+FF5ZHNic3X+yywPVaJE2LFqs1Xtf6ao1I7oFAWedStucAweSmhFkPdRWN86sjipe4utYLf0KihHiTQJgkK5hzw0YnUWv5QCg7yxU1N4xbKiN0qUj+esM5xT/gta80w8VK6aqofuDXK/6hROLuk0m1sPbLVDDJ+o4zaM/scldIrsPM4sgBoYGmOt2fYr1t8zqnGamej9cV8CcmlNnGaF47DuMazx3LY05tWsziyga2OvW3m6137MMHkeuEzn64w5ypVF+mQJHlmSCeJV3Kp3Rh6M+TSxVi6DCNT45Rzae6p7UOk30WC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 22 Aug 2024, Yan Zhen wrote: > The kmem_cache_alloc() is typically used to free memory allocated through > the kernel memory cache (slab allocator). Well yes but since we removed SLOB we can use kfree() on any slab object. > Using kmem_cache_free() for deallocation may be more reasonable. It is more symmetric and looks better. Reviewed-by: Christoph Lameter