From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCF62C25B75 for ; Mon, 3 Jun 2024 13:48:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A6786B007B; Mon, 3 Jun 2024 09:48:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42E836B0082; Mon, 3 Jun 2024 09:48:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D06B6B0083; Mon, 3 Jun 2024 09:48:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0EEBC6B007B for ; Mon, 3 Jun 2024 09:48:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B29BA1C06BB for ; Mon, 3 Jun 2024 13:48:58 +0000 (UTC) X-FDA: 82189708356.13.9C65088 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf29.hostedemail.com (Postfix) with ESMTP id 0B3E2120002 for ; Mon, 3 Jun 2024 13:48:54 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=t1dHQY3o; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717422535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jjNZ+oF/vjWCQ/HREQOc/k5mgT/wWmurTJZuPcpHueg=; b=Deiy7G3KtRHVEFCviZIH9uvmUA5bkk19jMg3p/pmBGAxuL2VTrCnYAE0gD/oX8zcyRJSk+ uP1NW+zYBb6gpivMIIA74Y5ZIsS4j1PJ5ojGU6Zbl/DgC/I8HFilO1baOCv/kH8d1qKLx+ vQ1nJULodEQ5i+79mmV5fAH3tZKKfIM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=t1dHQY3o; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717422535; a=rsa-sha256; cv=none; b=ne4hYJu1N33EhQdxEGm/6ekyii2Uu0xV1W6yUv4dTiwoStNzgldHTsIOQonVhlFEsj/AVp /0BHxuscqvDEQGWrFym7ft+AtXcBBhdgDrUD2c0vfSjTbJIkQPeeJ0o+EmuHf7GSSTFVNM d9s4NYoCl1pNK6zn2eImVTmUByxPmdQ= X-Envelope-To: willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717422532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jjNZ+oF/vjWCQ/HREQOc/k5mgT/wWmurTJZuPcpHueg=; b=t1dHQY3oVSv8A1WxxJWuZYzI/r63+xFoBv6byEKkCYOb7/4GqdqWiel8RgbTMYfGeEqX90 T2rtGURs5Nh6RQozkQumBbbjM7eznegFXWTdIjVTMygEhR2Sz+JV3+fKAaAFJkIPkHG09f S6JWNE+hSHu6BqQXI0vZx0B9+ufgU4M= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: rppt@kernel.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org MIME-Version: 1.0 Date: Mon, 03 Jun 2024 13:48:50 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: <1bb60f7db3a11e86e6f48c1eefe7f27d7d23019c@linux.dev> TLS-Required: No Subject: Re: [PATCH] mm: pass the pfn to set_pageblock_migratetype To: "Matthew Wilcox" Cc: akpm@linux-foundation.org, rppt@kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20240603124100.2834-1-yajun.deng@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0B3E2120002 X-Stat-Signature: aohebs7n6rdhc9t5p7rhmowafbab5oen X-HE-Tag: 1717422534-50085 X-HE-Meta: U2FsdGVkX19DzNjZICxPjPuohU8DESB/WQC4bs+0Co3SzN6VWti+oTpGG5aEfv+smogSkEP/1s3NVT1EpdQ1dp9TLmKJux2l4QPT/FM8iWeWUCJ0a57TuLHM55NvkVgldK9UtRe5UgLKN58Uup7SZqUCrLUa30u0tnJMyv1wKDwpKa2aeG3iXSpeoM23ThCkwSLiS9NkmaT1g6frhazMTt/VPyR6Fm1HlfEi+O5Q3pEtX/3scxWVW/fHEQ7U6zjKb9n5y5U2St7Tv5GJhdePcjWMp6eRvmTU30P63bXd/YJ2HQqu/FdprC8XMo7iJAgLKv49eHJBZm/CDF+EPMH84/E6NZ4QRpFwsqr1pcuUfOQEUCY2p2PW78PdbEJUwRm4ZveVvxCC1QuCgXzlr8crAFehJLG4s7bPY0wTsUypdcJdhgPmUZhOX6K0b2HA9pj4zfYKyYcU5cnSre8PtI+3pBf5EwZEPoBZNFFUhFHuyucXmCOwEu+hH9tIFmnnFGTC8Z34NLrFsIuotslfakWJ1tAHUg7FqTucfwifUnY4xQUrBeQvd3Hp07zZQZ7wsvsgmm9GQnF2GOPTc5ltzp5L2r5b8P7rHhM60qBi4AJdXeuLNcJyReJBr4kMzDO+lPhHNEdnyODwNzy8X43JbSv1+oNl+tH+e7OTAyN+NHjduqUh+SxIEttpA2KlyU4W9CwRujDPK3HxwPza0yVvVfIFRIxMnWEDS8Ehy+Xw60ZwcGr9abjMMb4P7dUEMaQXCqf1mZ0FFnEv94m7ltG0wQ0lHF7tT4FOC5nCHAiKihhaX6Q54bwBF+vXlBndPD4AxpUgdfEJDN0oCe7UX0ELYrvgiz6CuhdK7MJ31VTXjf8BG7zgNWw9zXw/XWd2jw19QepjQLxc5VS2TuVXHxrLvf0kX2IR98FkAeLpwgkykUBxRWobZwBVSETXxqThnwX1e57blIkr8KFm50GqPjRDzs8 FkuFrGI5 wbZlLpkvi3xcCSFwJk8Rev1Qoc5j4+kUGX+gKPh+3z9hwxOsna4QPaPHbo/6+U5626MKaSu9Od7L7ZVCVVej+atZ7Gqzrnggf5X4+im30GrFTToa69hkWz184894aH79kTVdl/1JZ3OTuLGUyP0Y1ANbfFkJMnQOj7vrsqEa+6bs8kI5pKnsbz7i+dZ/io4YS/jf8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: June 3, 2024 at 9:03 PM, "Matthew Wilcox" wrote: >=20 >=20On Mon, Jun 03, 2024 at 08:41:00PM +0800, Yajun Deng wrote: >=20 >=20>=20 >=20> It is necessary to calculate the pfn in the set_pageblock_migratety= pe(), > >=20 >=20> but most of the callers already have the pfn. > >=20 >=20>=20=20 >=20>=20 >=20> To reduce the calculation, pass the pfn to set_pageblock_migratety= pe(). > >=20 >=20 > It's not exactly a hard computation though. Have you done any >=20 >=20measurements that show this patch is an improvement? > No, just view the code. But some callers are in a for loop.