From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C7CEE7716B for ; Wed, 4 Dec 2024 10:39:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 075AC6B0092; Wed, 4 Dec 2024 05:39:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 024626B0093; Wed, 4 Dec 2024 05:39:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE0EF6B0095; Wed, 4 Dec 2024 05:39:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD7E76B0092 for ; Wed, 4 Dec 2024 05:39:10 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5C194140F03 for ; Wed, 4 Dec 2024 10:39:10 +0000 (UTC) X-FDA: 82856928924.05.2416A7F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 344EA40007 for ; Wed, 4 Dec 2024 10:38:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="s+/0WZCW"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YdgW8DaR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dAlY/txD"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MMyVC2fX; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733308741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kkNwq037Vd2UAD0UpSCAXRDCsNFOhUmUymoJpR+Dkpo=; b=CkriS895APA41s5UUAmWtuGJiIVjgnKXY24BUBLSgoArTyTXYx38vLU3JnALVSIU/Cf25u 70JYw3sccL515sg7pda+chaouiByiZFcxkoUfd1kME4VGv+JPysyMlRA6ofTuTVmpXEpHE +xUcv7IwOtzLRNZOWp6RW1rdYkVwmW0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="s+/0WZCW"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YdgW8DaR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dAlY/txD"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MMyVC2fX; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733308741; a=rsa-sha256; cv=none; b=RxFRhE/6C4Zd702MDPPO+LLh6hP4nVymf2jXijQllg8gzS20mPXS7c9CBZuDImmnAlnQJ3 Dd0tC5bH5kGI3Wtbof87hRTigi8Cj3UmPBZ9YS8r5bGYvK1Ip/AElYoZzgg3k3+EvoAbvG pn0sRIq9cyY+dlswwT99EKqzyPWT39w= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3F5021F38E; Wed, 4 Dec 2024 10:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kkNwq037Vd2UAD0UpSCAXRDCsNFOhUmUymoJpR+Dkpo=; b=s+/0WZCW9O7gFXI4xyjDgS0T8yZZmoi1tpWsBDwvdsP2gq+06f+RJsfZy67Q/TEHy7pqCU zA6PqSF0DGPBGE+STz3P4MBNxg2PsyjDJ0v7EHV/IhNPHdV3QaUKvpFzk10V8yWQmZwmG+ PwXkVcac+rghDVFGBQawECmazUQhWXA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kkNwq037Vd2UAD0UpSCAXRDCsNFOhUmUymoJpR+Dkpo=; b=YdgW8DaR3xKQsRfnJNYJQfLeUyvSgRzjRnKsz/xoI6FhA1wPTVI3RZQPaz0mrwmiq68SNH z0YBMswAv+RIhnDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308745; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kkNwq037Vd2UAD0UpSCAXRDCsNFOhUmUymoJpR+Dkpo=; b=dAlY/txDPlN2eDZoVfYcW4ev+yX8sX7iegbQwpUEqmYtIupWIONHydPJRBOo2/rJDPoYhI Kyb+TOSl1nB2SVbQHGHyNdg6AZnYTEoPROeaFMfiC9Eu2ljqHBzwUqUZDVhz+LdK/S6wJs jdI8dfiirv+b0ikLyxO6zB8oP+96+zE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308745; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kkNwq037Vd2UAD0UpSCAXRDCsNFOhUmUymoJpR+Dkpo=; b=MMyVC2fXuchE+BGeTdZBCrRYuaXYAU8sDMv6DMTkve62Fzgo0lTptIIGlPqpju4K2gbtNP K9XFN+3rsu7D9FBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 30BD413AD3; Wed, 4 Dec 2024 10:39:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vkh0C0kxUGcLBAAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 10:39:05 +0000 Message-ID: <1bb1b859-6faf-4b8c-9513-ba86295db522@suse.cz> Date: Wed, 4 Dec 2024 11:39:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/15] mm/page_alloc: Move set_page_refcounted() to callers of __alloc_pages_direct_compact() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-10-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20241125210149.2976098-10-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 344EA40007 X-Stat-Signature: 5u9um3ty7qqkdnkbrsfshfetquwnjrck X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733308736-111902 X-HE-Meta: U2FsdGVkX1+Co8XT3dGnnoqEfB1b5EVtamK94D+ZJps7FKFnWE7zfBVRJ3UPIZanm4cXGfHhpW4+EGCefON5NQpasvjM6JnI444nrC09xT7qcjvMc2Fx6uwJU1CfbfuHu4h9+ZziKv/HBAquuglIYf8mecc7XlaWY+p9idKo9I5pybwMLJEKB7ZdaXHyp22tJeZMSLuq8ysEGnarN85AKM51mAqm7wP5zf5vntXy/gi578ZKPgiIiXJ3JcFVPSX0duy4rnJclC20rTRmcnQcw363pB0BiaGi+4AMq/XRSoc9KnfPR9m0ACkx4vsfKzzmxhIxDlFebf4KymAbwSQVOcHDRh9Ac2/JIQE6PrGlkLEN+0/yaRA9KG4W9pGV3qXZ/A+OfnW5tZKEdizBx8DagwycXvMabFiMFoHycraAusb0qk7yJH8aXTZcAiTNcaDqfxIxNP3FSfG6qIt3UVEu6X5PCrKfCKeGleXhr2KDX0az9IhRwt/h5LUYAIy4jXp5S6SBHBB22qGhgMyiKfELEQKunEvEu4Mv1gDVydijxAkPYnVOzRmj45KyW32nSCWYanEyZm5dooHFzVm7rpaXYirOQvFjRe8qs7OHdmPBQ5QMML/0iCBTrmv4ChjXheoaEufimap4SxiaoIyrgEsiYqq7whS97mVy46jH0klV65GNt0rR2vkKDW2aV5iNp2GBmHWGrzr50/6xMpJkuL+IfpW8WJ2g83dh5eNgU7VKxfgpGaCQMAtmu6BZ+7g7QjQQ+c9+2dWmjP0TPeClNpKz1IpTyddUulYkGGZR2vivyACHxmjUG9l+ej6lQYVilo+U+Y1WQg7mNidPw5JbnrhCl65wCCVPyQjsFU990vvQG5z4oalo9a1RwH9DBXM467pOBYNuoJdxyZ3bVyFCETCru/EwJIfFHcJtdYXopTBOnu0lcsOHKfAEzAO/wV8Hz+q+ZAdWp9joVeWjSzwoDyv 2YRc+Ptf SZvX36bG50vvUYs8Pze9EjLmqQ49MiDXrLF7U8Ynq1ze1vwzMuA8sAWcYn0EbYCaHrcfc4OKYff5QgDWptZW3AWNiNlKY5Soetrhsb1E93rTQwWMQPxqgFuUMwp+Q3Dq4n+tJrJM636Z+uD1svySV2OKDR9W9LWzCenAisuPk5ujIOeie7Fcti8d794E2yucgBzQFWaRSJc+V0dno/g+Sd0a+YNokkEmzw+lbIywgRKN25w4kPy6EGjdWQr8zkMKza5+XAjd830/i1kLYkwAM3sBWCmjBo6saFD1oU921xXYsgTlGRexiDcT47uTYPcKCRFGQOONYLeO8AC1ZqSOaSqwC43jNApgYTv2ptnouCul+pE1qBqr/nkNLyXFeI48WBaT43GiBmkZJ43k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/25/24 22:01, Matthew Wilcox (Oracle) wrote: > In preparation for allocating frozen pages, stop initialising the page > refcount in __alloc_pages_direct_compact(). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 514994cd67b8..0f02cb253bf5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3740,7 +3740,6 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, > if (page) { > struct zone *zone = page_zone(page); > > - set_page_refcounted(page); > zone->compact_blockskip_flush = false; > compaction_defer_reset(zone, order, true); > count_vm_event(COMPACTSUCCESS); > @@ -4342,8 +4341,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > alloc_flags, ac, > INIT_COMPACT_PRIORITY, > &compact_result); > - if (page) > + if (page) { > + set_page_refcounted(page); > goto got_pg; > + } > > /* > * Checks for costly allocations with __GFP_NORETRY, which > @@ -4425,8 +4426,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > /* Try direct compaction and then allocating */ > page = __alloc_pages_direct_compact(gfp_mask, order, alloc_flags, ac, > compact_priority, &compact_result); > - if (page) > + if (page) { > + set_page_refcounted(page); > goto got_pg; > + } > > /* Do not loop if specifically requested */ > if (gfp_mask & __GFP_NORETRY)