From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41A7D0C5FB for ; Fri, 25 Oct 2024 10:23:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 572FE6B008A; Fri, 25 Oct 2024 06:23:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 523566B0092; Fri, 25 Oct 2024 06:23:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C3826B0093; Fri, 25 Oct 2024 06:23:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1F63F6B008A for ; Fri, 25 Oct 2024 06:23:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0EA8940772 for ; Fri, 25 Oct 2024 10:23:40 +0000 (UTC) X-FDA: 82711737822.27.A0A93E5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 4BE0114000F for ; Fri, 25 Oct 2024 10:23:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1ft/9aLx"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TIilYtnj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1ft/9aLx"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TIilYtnj; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729851673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nAV9mjB4DPI2AdA/wE735ZR7OX53csVYBdQgoDqS8hc=; b=JoKna7Br0mHwF6geojnCidUIxTNic9aA5M0NaV5JssZdocScTxD83EvUVZ8Yh7lkFRjLPq 8XEBZQDAjwoavZOkJ1HoGtby0NHpBpVeg4b4LxARPDSGARQOCOSaXyQgH7o0buuO8CmRuh tCe2Ka4yjqZo7wmegMuxHirLkb8I3Bc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729851673; a=rsa-sha256; cv=none; b=AKcwJyyS4PQMTfrfHV3nX9I2w0KTgFR+03tVnmdkxzYMxTQBfW26TXxFbzzx/kOP4fE8jN +srJwYZ2gWZZNiafqQnA7H0UjV3keK0ZxNt7vYljzuwjTWqe0t6HIS8zY7zFtmRtU2jEvI 2gDoZ7gLxNyrnqTAlAC5qNDNDCHienM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1ft/9aLx"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TIilYtnj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1ft/9aLx"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TIilYtnj; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 663FA21D9C; Fri, 25 Oct 2024 10:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729851826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nAV9mjB4DPI2AdA/wE735ZR7OX53csVYBdQgoDqS8hc=; b=1ft/9aLxBaJqHqAmRpfymZ5ecTAxA6tITijXbZCYT7P+1qgYQvsqFcrHrXTO4vAvrBUznh ezid7iEcsh+zhCVUVy35rZLBIqIiHZQ4e+oJKzjeOVXcgLNfNJxPB/MaYHmpBsFEakttQI Usj8ZzYD2Gz8H8cBQzLi7HNkdEAOwCg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729851826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nAV9mjB4DPI2AdA/wE735ZR7OX53csVYBdQgoDqS8hc=; b=TIilYtnjDkPEVL8G55QY3auqKvRSWy+73e+GdRtd/SUjmOihdTxNnA9jnzVznhLaGbS8fA 7Yg9dZ/wEQvRs2CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729851826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nAV9mjB4DPI2AdA/wE735ZR7OX53csVYBdQgoDqS8hc=; b=1ft/9aLxBaJqHqAmRpfymZ5ecTAxA6tITijXbZCYT7P+1qgYQvsqFcrHrXTO4vAvrBUznh ezid7iEcsh+zhCVUVy35rZLBIqIiHZQ4e+oJKzjeOVXcgLNfNJxPB/MaYHmpBsFEakttQI Usj8ZzYD2Gz8H8cBQzLi7HNkdEAOwCg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729851826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nAV9mjB4DPI2AdA/wE735ZR7OX53csVYBdQgoDqS8hc=; b=TIilYtnjDkPEVL8G55QY3auqKvRSWy+73e+GdRtd/SUjmOihdTxNnA9jnzVznhLaGbS8fA 7Yg9dZ/wEQvRs2CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 519E8132D3; Fri, 25 Oct 2024 10:23:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BsCCE7JxG2ePCgAAD6G6ig (envelope-from ); Fri, 25 Oct 2024 10:23:46 +0000 Message-ID: <1ba2aafb-468d-4f99-9a89-672581ff7e4c@suse.cz> Date: Fri, 25 Oct 2024 12:23:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/8] mm: refactor __mmap_region() Content-Language: en-US To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu References: <0b1da31b49d47ccb930d36f509d50d04c0422b73.1729715266.git.lorenzo.stoakes@oracle.com> <990f7ab6-ba06-4564-8d4c-baa5a3f3d8b0@lucifer.local> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <990f7ab6-ba06-4564-8d4c-baa5a3f3d8b0@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: 4pzq5w33h5d4exiurc63syj9sxc9r3xm X-Rspamd-Queue-Id: 4BE0114000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729851813-291875 X-HE-Meta: U2FsdGVkX1+vMqJa3W4l6MRA97NHJP4PUY/EvVVWNVjQcKplpk1C7DdB+iGq5c+s8Ay5oS5GKic7GOYLFi1zVaSO3gYxlE8uh+h7PXGs/F57aXhHSr6UzkjfQpxUDnegaSvWe4RqGF/z0vAeoS3KCmj75JEreAZuM8/eI+qRHZu89U5bCc+wuz0MxE6p9WQIp5+ulJFsNpD6PxH1RllW3rCZwUW583B0JT13zL3WmiB4r2HL5Ep/C8wbNV54JPdAJWihEcM7AAx7/yRO5qxHEL4yGf4dzrM6wVM+gQB+qiRgtdPn+PDG9FL6Fiy0fAyZ87NzoN3lZFy5hYK8i5GucROrkG2FjXIZPTlk8srWtmxY7hYHuF5iWP4PbZ6mkY7dpolCr2888C29ZCDz10LSyqFncQemB9ZnTnod3PjARmUOuf21n4Y1oTBNszpSh24esHvOEUey+ocb44KO83uSlQ+s5W7A0+2s4Xuob3LDc6b7T4WNha65RW6LjcT8G7c13k/Kxga39EL2T0zTdoloifGjtb2qBRBwyh9U/9+HV8Zcpn3relFpjWjEQx7c6Pkj3vmNb40AvA7wUp3uNJCNWyLJ/VA9rE7le2vIReSCKQ0ysWsSlTaObiolegZunf3QETEpOdZPDbCADRgsKRpMHct2IiyYj4U5PQP/q8WOqUHcfDFR2EM9dkbDhzfJ6cJmkdGvxS3fTrvVLfRiWSvtLpbRxcfakf+tDGI6qaODBcooMqq7LsLzCECsqpFEQKNQZE1SidBiN5PAj+Iu7Pss8NRchPvw85lPwXUubK9cbIY//sUVBvIbU1zjxdeIfYN5Iw4nHF2ul/I5ONgcigJGBXgRmQSgA15/E5NPVz34LKL1EfO42rWPP7JrRxf1ovDQGmXVqT+z4zV+YLXjuYi15MnuvUO/3I3WyqWf7/CJ/s8s/Td/CXiLDeiZqlI3c2l/ssrRqoCVWakT3ch1Yly TXwCBkLg R+Xs7/TGlj7oC3mSzYTBehuceNvcBtgaR63ITK5uH4SHguATJbPIYn0rAsR/ZcypQLGfoGQFdx1sIDf+cQCTA2GmVto01efAb2PWLPDrLFZ3rvGGkTyj6JVB9F8O5aWnXg/MesHTHH4rR4xnFyNyTW5e+8WIg0ZRfGtK27rWyhYe3ODFhgcms9MhBO3ePKlG5ki2Z7Y6htMEAiSOdannDu3EJXW1PpGgmusAOof2w87UeEnzmO/4K4NuRc0vTFsvLFiuae/eSp8tDzvBePEiTxGNzXCOuUsctVw2Ipnj8r1QA02gfuy9qi9hmQQHFWTvHZbUYpdGWsG7xX3M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/25/24 12:19, Lorenzo Stoakes wrote: > On Fri, Oct 25, 2024 at 10:35:20AM +0200, Vlastimil Babka wrote: >> > >> > /* Lock the VMA since it is modified after insertion into VMA tree */ >> > vma_start_write(vma); >> > - vma_iter_store(&vmi, vma); >> > - mm->map_count++; >> > + vma_iter_store(vmi, vma); >> > + map->mm->map_count++; >> > vma_link_file(vma); >> > >> > /* >> > * vma_merge_new_range() calls khugepaged_enter_vma() too, the below >> > * call covers the non-merge case. >> > */ >> > - khugepaged_enter_vma(vma, vma->vm_flags); >> > + khugepaged_enter_vma(vma, map->flags); >> > >> > file_expanded: >> > - file = vma->vm_file; >> > ksm_add_vma(vma); >> >> I'm wondering if this could go to the "non file expanded" region above. If >> we expanded a vma, it was either in ksm and stays in ksm, or it was not >> eligible and that couldn't have changed by expanding? > > We could change this, but the next commit removes the need for this :) Yeah, no need to change here then.