From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FC7E7719E for ; Mon, 13 Jan 2025 10:08:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67B476B008C; Mon, 13 Jan 2025 05:08:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62BF06B0092; Mon, 13 Jan 2025 05:08:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CB8D6B0095; Mon, 13 Jan 2025 05:08:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2FA5C6B008C for ; Mon, 13 Jan 2025 05:08:44 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D75D31C915F for ; Mon, 13 Jan 2025 10:08:43 +0000 (UTC) X-FDA: 83002004526.05.0DEEBB1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 121AAC001E for ; Mon, 13 Jan 2025 10:08:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I1m50Btb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736762912; a=rsa-sha256; cv=none; b=OD8hUUfI4ybCaJz1i4hBL5jtOBF1orTf+Cdz+Wh3m+CW/Cg03MxdDVBPKzDsbrWkR3fnSY MWuuPA9fjbKwPVwNrxXioSpTy3NqMJfdmgJ6c4N++Irsy1KxuzWY51726Ap10uTeWYde1/ 1oMGM5jPZ2gCgPgEL/j1pP9LUbVQLC4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I1m50Btb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736762912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w9g1LslBk3KnkNcF/p4M2vlNVEzNEkixwrIJc+UAHcc=; b=bJdE3WD8M0krz0UEtC9L7jyXySwFdevT/jFN3iiEkQ+/zCc+qe0BJPXf4cTe9FUkD1UwCz QKccbgs7ktbjcyx14f0FdNs/xDbyxxqeoStY5uNzjeSyBhwIJshfFpItrrJtO8SqECMkR1 QVozhnqOfJTDAA7d0zDk5gsCGBuD1Ro= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736762911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w9g1LslBk3KnkNcF/p4M2vlNVEzNEkixwrIJc+UAHcc=; b=I1m50BtbnHJ6lW0fiz9TdQNYA2nNklMFwW/M0cB7kkqqzJF12cNV5K8L1+V3jO8HFFlFAC dJpP1+HXDJ9OxZYjZ7rxkjapadayVbXGW2mWk6QWsNaPwTHcQ1BdR0qcAxGm1vgQUuK8Oa s0SySFaxODheEKqe5pZFEGIdknP0CO0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-ialEmS0DPtizKWRLXLNW9w-1; Mon, 13 Jan 2025 05:08:30 -0500 X-MC-Unique: ialEmS0DPtizKWRLXLNW9w-1 X-Mimecast-MFC-AGG-ID: ialEmS0DPtizKWRLXLNW9w Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3862f3ccf4fso1438875f8f.0 for ; Mon, 13 Jan 2025 02:08:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736762909; x=1737367709; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=w9g1LslBk3KnkNcF/p4M2vlNVEzNEkixwrIJc+UAHcc=; b=Zi7j+6yh+oVaoCUqMLXOoks5h1C84SDmuIEqY/CvtP6GWS9F0I+6G0JpUUv7yCXV38 JnLeqrKatX5BjS8y5uhhe8LN/C77uba8sBPqW3pr5ALhaxEwMBOpp1hxWfu9cCgXSi/n FqTjCSBNJZOaE148ZaDAVjK6Lw0y5U1F8M6t2g+s7QRlLRtc5RWOz/ZEt2Xejbpz1xqZ 8R1PEGNVypsqTcUIvmOuIyBISR/5k2dbF9yONw46xItbuu7Tl6ul55CPTk2P1Pfv/XGc nAPeKN92tY4uqDjDrswvR0u4eLQcOVgTnRi5tfjilZVvCCE+4G8YWVBkYVSArJkvY7HZ 5+Mg== X-Forwarded-Encrypted: i=1; AJvYcCW4gz6Dc3e0mM4ogu84SQKvJ13kII37y3SiezWuEQdWwO+PoXCtrVIFkuaekt9sCBoeS4Kh5uZwlA==@kvack.org X-Gm-Message-State: AOJu0Yyr8jJkYEhy6LIHqrhQnIOmLEK80ynH5vXl5KxJ8PGXwpCjOarY 5HT+dVGKz7ZXL7eF9CBV7VGzlySFgDduvsjef5giGzL6P+GwhznmywnqLgjhn15EPEA8iZrVDTd oaNpJ92DAy3y21cQg24PTVZ+oOPxqpt4hCKmGJWZPKuaqLXwu X-Gm-Gg: ASbGnctVwgoebU/gVygvM9jd4e3Fyqkayela4llXIwyhTos6CnYNWqAdPY7sZeA1WoY c4RdeehfQ1/ROfbZcRrTR2waNGSqJi5tKlBVHraUWF4casExiLop7pMEyCBvod2M9arxoj2DENH eOnL8JJBCrVnApfifnOmyOZLgCbNgg/e4z3BL4G0CQS3O0XnFvjyBobNuG7DRviu/C6YgoON4OO jPUknAZEajRjY8IwrhsFHKAxbRXKqLJmu5ZuDuT187EyeJBd7OSnTYj8M5jRyQWTGSbH5LtQoST 3GZ1WLEvSmupoLs= X-Received: by 2002:adf:ab0c:0:b0:38a:8888:c0ef with SMTP id ffacd0b85a97d-38a8888c2eemr11512945f8f.52.1736762908852; Mon, 13 Jan 2025 02:08:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZaJWGDGSA+V3h2fBword2TX3it3Iw21VUBChJlSgVAPvtBC3cixWVuRKOu8C8idzCDyAMpQ== X-Received: by 2002:adf:ab0c:0:b0:38a:8888:c0ef with SMTP id ffacd0b85a97d-38a8888c2eemr11512915f8f.52.1736762908489; Mon, 13 Jan 2025 02:08:28 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2da6271sm172066975e9.9.2025.01.13.02.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 02:08:27 -0800 (PST) Message-ID: <1ba00ad0-bb75-476d-a0cc-e3e6029774be@redhat.com> Date: Mon, 13 Jan 2025 11:08:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] mm/vmscan: Use PG_dropbehind instead of PG_reclaim in shrink_folio_list() To: "Kirill A. Shutemov" , Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe Cc: "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-7-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250113093453.1932083-7-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _KAbOq-Y-F1-rvwYq87f1d58Kx-m62QSlczdR3wvteU_1736762909 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: iicj5ixj1yz3t6ika13jdecm6epa15oa X-Rspam-User: X-Rspamd-Queue-Id: 121AAC001E X-Rspamd-Server: rspam08 X-HE-Tag: 1736762911-422191 X-HE-Meta: U2FsdGVkX1/pnxXVyYFWx1HqTboi0ZfTEQechbMyoxES+StskYG79wsWAv+U4lY9uiHhtCileI7eC9iTQWSWRRFTy5NQk46EBgTUhiRDw2Ln1tIxkaLCPBwOBKyr2ovaxGGDKn/yaOHk5Cmx/y+X+iZmNVYorw0nPh/JH/NEej+msmuYIa+IAKkW13SAt4GFd+xR7QB6VhHVlbPPdw6o1gLqn2+1p4iUm/kv1z4y6cpZnM0K9NE/jcknFaA+JXRZhOfFtvReArmR8kA62Yrr8oZcdQClwXhtivYCJCVjISaWbvPCLldnxFVDa61t85QZnXUgi+JdBhYRh0YlsbaPbegOMBWDgxFElubwaDMWkhHV5uEcZp5m2C9hZT8/cWgYrHN5+fJbzX3sHuxy8Az89j0cV+SGF19vIJtK2ZqRydbDgpVno2sIaP+dVAM0KxDfTtw040ZgpUspAyaAWMJ14JJBux00UFJhmt7ZKI+wwXxISiGjcnf2ag8Is0YyXeWPG3Ej0rnvwn6aGwLmyxtPV14HevqSoX+rrIuNxrk6rjYG6MNLGxDua+4SUs/ERGdgy238MyEBe2FVBrK0Bl/IZWOUSSwEMWvVAZWTKF0MIe7dAks6Tz7seNE24A4QBTXsFfur4vzXVYGIkG6CisAGvqO7pruHTM/yfm+ChObo0XcKaZwXMZSaNyVvXPLQoXN9AVN6z5JXTDdBexAPRGRUrcEMBUI7OFh9kVvrmFveiiu69o8bZSankD1L1ThPQoHGmRcY1LE7SNYhY4RjYxEVb+Kl/C8uUbpHh4FjkZ/xDnLXvCMHOldttSXJE1yDymB4ytJv5KkcStUgbhmu/bkC9bUQodGOYQKMipZXvBj2UlaBv9FyaiZOnAhhgFuoFcypsWToaKzLCiWFzs1T30oOFQ9RH19jvzFcjolqNvz0ni4s0BTWSV3FBsDopgZk/nXSPrRYPUigNdGl5rDL6q4 CPbp40u8 QcHbyjOy1T97geNzkcIsfinAizX6BdSp7MkYZ3S1rOvn2jG9xUAHgdxRnZeDUrnMKqAcmtEgXEZe0+lIdLOq/C7Fy252Y4U62sLIzXwkim99golscunXn1d23xmL/bAkxu3KcnT1le5dVdoy7qOjEb8g/WPGuKSUsZDBy9hzEbDTHuyaYA0MqRWjXNAwMUTEvN/PyniNpvcQTGBYWesQdtt89+a1URcw+Z7qXPuPczU/l9fj2+8jvyJWA7fAUT+6WWSsWfOD0nt6petpvgm96JKsFyTIYv2hYwJa7B4ogDtIuWncVzhOAj6Rijz0Mv3ZJ1A9C+bouRZWsWZbCUpejnOQMqa03gOFdNFPGGmiRwAPsB3pFMfffnnEaANaqLC5A/Y1cWujWFu5b/uq7mVRolxdRFI0Lk86grQne+6ovJUrvbhhCjb+ss3cCTSOIByjmOhb9wtrdzJroyf3Ly1fpyuGq+z27onECznrk9UnF+An7+8RbbSW2bQhVqAqeqa0rkijmDv9w7LevkBk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.01.25 10:34, Kirill A. Shutemov wrote: > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > Instead of using folio_set_reclaim(), use folio_set_dropbehind() in > shrink_folio_list(). > > It is safe to leave PG_dropbehind on the folio if, for some reason > (bug?), the folio is not in a writeback state after ->writepage(). > In these cases, the kernel had to clear PG_reclaim as it shared a page > flag bit with PG_readahead. > > Also use PG_dropbehind instead PG_reclaim to detect I/O congestion. > > Signed-off-by: Kirill A. Shutemov > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb