From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C29C6FD1F for ; Tue, 26 Mar 2024 15:06:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DA6B6B00A1; Tue, 26 Mar 2024 11:06:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 362676B00A6; Tue, 26 Mar 2024 11:06:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 229FB6B00A5; Tue, 26 Mar 2024 11:06:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 13ACD6B007B for ; Tue, 26 Mar 2024 11:06:17 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2C57A021A for ; Tue, 26 Mar 2024 15:06:16 +0000 (UTC) X-FDA: 81939515952.20.01639E7 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by imf27.hostedemail.com (Postfix) with ESMTP id 80B004001A for ; Tue, 26 Mar 2024 15:06:13 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=Z1dniA31; spf=pass (imf27.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711465573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b+6K4b9S76Ab2/ngd1mwoc6s0B1aFx0F1dzGraTAPTo=; b=d1cWkTnHD1ZiFhti0Wcq+iUpNMsoSNM+k2vI//MMNqPVLtslB3FJDVmX+c7Mglq8rZyVgu iXL28HzrB4vVeFUOE1Z5gkBE+nazbVhXI/EJ653PmCtFZZbeSxv4ldzg8RA+X9OyaYGnhP BxZYtXNfS2i8FBQkisZhEAzDlkfywFU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711465573; a=rsa-sha256; cv=none; b=laWLUvfUqXAdY0BYds8wyqqPt31EU1d9POtChJ+J6+3XXOLGf/3FxOl3ospPaiUQ5ZbY8y 8t6YkA6217dsSNGAZgUi3r5Mno+FWMaSdJuYkpXDNFz8/b3z4ZX4ISCX9xe1dK55Bp13sw /EO3h5Xe37omTwQ3OBDOUJ8sB5+NT+A= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=Z1dniA31; spf=pass (imf27.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4V3tRP2bGRz9sp7; Tue, 26 Mar 2024 16:06:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1711465569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b+6K4b9S76Ab2/ngd1mwoc6s0B1aFx0F1dzGraTAPTo=; b=Z1dniA31y8YJOkfxRBC/wzJxbGe3+dlDsJzHmNtsHPD9XoCv00T3xKLOTp5Amc00d0HCPd DhEP8NmzCSEjd5SJcG5i27AzDDXVCMLkeLhxt/KuFHbsixMk1sHXmFz4arVxvqRtSle0gF 00LVx0BNQYJLokqADG41AaT0NnCWAXdFc6Lh0zQIYXPb8a9WaNZEU0+BooPjrxV5RrLYvN 7EUKVlI9Fek3Naga9sYuZR1InqWPxiDz3Gq5p9mqn+UxfZE/DN6+B2gPyHSgPDlNq2jw49 pQ9wpBlRyXsoygLRXNCUTUtc+uv2uNBIROhm67MepXW5gYfsHzsG9PLh/ilhZA== Message-ID: <1b99068c-ac1b-4121-93f4-23ba4863b8b0@pankajraghav.com> Date: Tue, 26 Mar 2024 16:06:02 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v3 00/11] enable bs > ps in XFS Content-Language: en-US To: Hannes Reinecke , Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, chandan.babu@oracle.com, mcgrof@kernel.org, djwong@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@fromorbit.com, akpm@linux-foundation.org, Pankaj Raghav References: <20240313170253.2324812-1-kernel@pankajraghav.com> <2508c03b-c26c-42ce-872d-3c5107a4d8a0@suse.de> From: Pankaj Raghav In-Reply-To: <2508c03b-c26c-42ce-872d-3c5107a4d8a0@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: ah8aw6jzj683x5d3bfto4jrmoa6s6sdq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 80B004001A X-Rspam-User: X-HE-Tag: 1711465573-769054 X-HE-Meta: U2FsdGVkX1/PArq3YFbR3pQ2JWQ1gLMpa1pCBrrKnOnSUa1bs9gYzbQ35+8hMBsx4ltgLfcZDDQQhyChd7Iaw1W/+V6kG+9sWdJpOlzgGBLxT57i03yHt1RUDcAtWUf9LPCaBdWafHGAMDYYR0es6AwYfHQ2xreisJcOVdQgIEfUgJwPzRgQW+xXHMPTnObO3+P4lNm0d1q9ryu6z6hsqGf5c5K2AL4UPBMHeLCjwvRh4CqBhiBlqBG/aIY+QTkvictgFCaMSvTxzesEfaV5elbYV9cMQjELxdpPs+kDqTjF43iE0LjUjnHImzR4XT2nzjmNcLu7Vg68QhgovlriEEptogcRVtaaGVqD/dT8Rmk956WVp0ErMWJ2leHKVvIBCPO/iFIskzeiibkjf3pWWreeC/HvPSNBAxLbMCcLz+j0Frg08SeZFXMYErBQsP7UWGP4D1D0sAAmp/L/hpkcyQ/jFFBg0vQFL0suoCsawzpiSsarCXgVaimQ8zwAv1dXxieTHjRshk7fdj3vhridF6IGVC9V3L/A7i7XYmshsBavE3SiMrZtHHdsb92LxkjpZT57T4SRP9xLpPq6KIu+dhAqYUwj6ETq7SPM+VsO+FjztFZNAaq/uyFssMa81WVQoVf0wrVbBGFH7AweyPrfggNa/pCkzkFpjIJ/8X+793LcAhKjE5JJ2vIM1+9iJhwRBRBF5EB6Z/MmpypuUeR4crnsnKx7b0Cl0tJK5/NLqdnKAlvm/BTSOoUWKybg2EjhR7VtH2Yb98lAL74Gvrnp7UR4KIhiDpcb1OBR3EIqDilctZ57wy1nUvtF02RAig/bV0frMmEiGlDgyMq7sV5i8sp+MSsRCqDoZYbjoHW4nzVL8X5AiYEuEcE7Bfqyl0YuFEwW7fM9n+wR/uHBTbeeNxyW8o1KANx6Nf7aRhvgW4gN1gnmXpbfPzEue2BBaaYGLDt7zl1ISFW1ltbEcIN Acwy7pjL fMxfVnSqpxooldYxTpzzTMs4CkBzB2Mo/XnRaj/qh0nZU7e14sXhLLwHWBWvZwbcIj2L1ThMa737EMmjw912GasQYVO+BXgYO9emytJO2o+K1I7KOxcWX8Q88uTpWQrch3RlxSi7zHICngcHxoO1SRATNLc+F1MC1psHx73lUEjFVGDWyd6QqWWzoeUdwR3o9j4JGEqLlW5VepB6e2LdGXwekpCXdpmjAuWeGIFLq+NZRuEBVaaEhI6XW3azLYvqL6py8YQwbnf5nyaBBS4JZsysg0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/03/2024 10:53, Hannes Reinecke wrote: > On 3/25/24 20:19, Matthew Wilcox wrote: >> On Wed, Mar 13, 2024 at 06:02:42PM +0100, Pankaj Raghav (Samsung) wrote: >>> This is the third version of the series that enables block size > page size >>> (Large Block Size) in XFS. The context and motivation can be seen in cover >>> letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], >>> if someone would like more context on this effort. >> >> Thank you.  This is a lot better. >> >> I'm still trying to understand your opinion on the contents of the >> file_ra_state.  Is it supposed to be properly aligned at all times, or >> do we work with it in the terms of "desired number of pages" and then >> force it to conform to the minimum-block-size reality right at the end? >> Because you seem to be doing both at various points. > > Guess what, that's what I had been pondering, too. > Each way has its benefits, I guess. > > Question really is do we keep the readahead iterator in units of pages, > and convert the result, or do we modify the readahead iterator to work > on folios, and convert the inputs. > > Doesn't really matter much, but we need to decide. The former is probably easier on the caller, and > the latter is easier on the consumer. > Take your pick; I really don't mind. > > But we should document the result :-) > Having experimented both approaches, I prefer the latter as it looks more consistent and contain the changes to few functions. > Cheers, > > Hannes >