From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F96C52D6F for ; Tue, 6 Aug 2024 09:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4148F6B007B; Tue, 6 Aug 2024 05:29:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C4356B0082; Tue, 6 Aug 2024 05:29:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23D4C6B0083; Tue, 6 Aug 2024 05:29:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 074936B007B for ; Tue, 6 Aug 2024 05:29:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 671D6A832F for ; Tue, 6 Aug 2024 09:29:12 +0000 (UTC) X-FDA: 82421296944.12.B8428A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 0D9D1180010 for ; Tue, 6 Aug 2024 09:29:09 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="cWyG/+SG"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722936504; a=rsa-sha256; cv=none; b=L+mQErTsZgSVmWQeUNBGIJL5DBX4p7+FJmu7tiUE7Rlzxo0r5R005EEBgIKu32mfU3qyUH sL+yoywMKPomQniADEqEoAhSKu2xQMxo7iq8mrNW5Y4pvPCY0tNIXrGTimnVomZi98q+aS f4ludOWYIxlvH7bq8Cg2/c4LbU6e3tw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="cWyG/+SG"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722936504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OqxRMfE9zvjyMZP932e3JoYT/KCgjTra9hkk5E5nEI8=; b=WVSW+LnmEa36sJ6r/1OejJf2cqqPELr5MePCSFgk45GPkWpbZpO6yBBoQ84ykPNUAFTlOl 8gEasK9vxrwhhTh6h/R8lMVKxIwk6/GFKyR3cM1pXJ+FFYI18Uml2+S7FbSjPAHhtDfy1K neyP37JU1s0DH7C7+8YskzJltvfnwf8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722936549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OqxRMfE9zvjyMZP932e3JoYT/KCgjTra9hkk5E5nEI8=; b=cWyG/+SG80RTmkj5uUqQvTpadSDSwIfXnwwn3eeq+zSWiu6ymxqw1DVLK9cvwtY5dVctRc q9beIA8W8A08xJUGdcH7NDG9CRDjNAZV2VQeJg/IUm1TMs1EYnTlU/rIaV64YsfbQmhkhs A3gFjSgKqSFJcc6Hz351UOZxTikS2oQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-T2RV8PavNAiqNzT_mIraSA-1; Tue, 06 Aug 2024 05:29:07 -0400 X-MC-Unique: T2RV8PavNAiqNzT_mIraSA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ef23b417bcso5112011fa.0 for ; Tue, 06 Aug 2024 02:29:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722936546; x=1723541346; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OqxRMfE9zvjyMZP932e3JoYT/KCgjTra9hkk5E5nEI8=; b=iIFJ5kNpvbUmPM80xWMe2HQ07nzzCdnLnWmJe+uf44lANNOfe1/E/X5Ivus+QbWv7I QXqWnBGekbxHDATNKh95PHziijJCEL7e7+r298iFFZIaCLP3H4ljXNYSlP+4R5l8sEG+ qW9ZQK6w6O1NmAw3mL3p8RKaeCKeP4uaffGkPsKoEj+YRRgnlYnVc6Vyjr6dwRUhgMCe MI0v7zALRbKlyRc/uiPBx6TnEs6YB59FIg80aBaiNwlQwvWRd0gI4ihB+IZdefvubW3a Y12pvtEoyjylqHi6b1yvazKa2FVLky/agLm213RtHR1MBoZxtd+BUtY6NKbbywbq/Hal l8XA== X-Forwarded-Encrypted: i=1; AJvYcCVInOafcOLmAdiMGsGjpjy+ulKsq2vq1Z9b+JCdMrEVLITDX4wu+15s0gsppTcDEHc2U+KyDdOEJ9jz9NaAMXM4ai0= X-Gm-Message-State: AOJu0YwnpiKYgJRgoaaiDV8GJOUvbeOvGRm7PSIK9xUbLZqudQPcls1C 4e8UTtoU8XEnhR9oRXFBTHl78DDMqiSjKX2YY09Zv2RvF2evO19Wjhgx53VDCqwonQDAHGoQ1kQ O4tVz/GDgoWaBC+NR1UE5G2c/3d7c1hQ5Y1ymCDeQLu6806BU X-Received: by 2002:a2e:bea1:0:b0:2f1:6821:d163 with SMTP id 38308e7fff4ca-2f16821d287mr81326871fa.21.1722936545960; Tue, 06 Aug 2024 02:29:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEz3lUZ1fTL8JnQz5j/jaiSZqjJxN7PoSnSo7YrX7zK4xpsdCU03Qi/84F6KvrH/YUuLAZhQg== X-Received: by 2002:a2e:bea1:0:b0:2f1:6821:d163 with SMTP id 38308e7fff4ca-2f16821d287mr81326611fa.21.1722936545377; Tue, 06 Aug 2024 02:29:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:8500:f83c:3602:5300:88af? (p200300cbc73f8500f83c3602530088af.dip0.t-ipconnect.de. [2003:cb:c73f:8500:f83c:3602:5300:88af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbd169697sm12347435f8f.107.2024.08.06.02.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 02:29:04 -0700 (PDT) Message-ID: <1b77117e-e1ff-4d14-8135-09ea9beda5b8@redhat.com> Date: Tue, 6 Aug 2024 11:29:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240725011647.1306045-1-wangkefeng.wang@huawei.com> <20240725011647.1306045-3-wangkefeng.wang@huawei.com> <56b9a389-4c36-4892-962d-b45878f30f4d@huawei.com> <68067a56-4b9c-4636-9d07-41fee371d80c@redhat.com> <05520370-6390-4b08-8fcb-01f255deecbc@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <05520370-6390-4b08-8fcb-01f255deecbc@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0D9D1180010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ssd8qyntcden8rbrmz1iuwewfhmm5ira X-HE-Tag: 1722936549-118782 X-HE-Meta: U2FsdGVkX1/OiuBYJB9Dj7TUYcehJrgsR82pT/O7nGf0kXkQulY5/5nKDPdSJFm40mEOoaPp9rOFjOssmcmFLviARV3PerTdYzvC4X0unq5D5hEmGGLD6CAorFW05DnYiVyPrl3FtCGZUX7N+9CZ6ZB+UW4IIN+sPfa9h41IwcL9ZvWOeVdEfiHHkQJycsZoLpP1hjm4BkOrFPs6ZrVEGq5hWlBdlD1pv5jWGTHFHy3zS2QdeyefIFtYWpojpRObzETgpniP7ktx2nV/25Kh7hTZgtHNkWS1ZGfSb3vNy76PhcykKDLDvE2SfWsfn+vIFgcoTXUM+OqaTyNJSzrPIfIzzghpIbxcVxiOqHxxssi5yaBIRysqK4SOKhdJcICChV4lzh2yV/fWZ4ooV9DQE8UT5YA2lVjOGED22PALAydk7jsJx1UB0tGTKw1OJq93Bzc8J4rmW8u2NzajaINCglW7wJmNckLOOXSspUpkgaRmsBasc0Oq8sskzHarq18CAHaFbrGhJmu+bWTQ3lQ881YdYyrR+qlJcV4TdN27cyjijTAdDZpdwVVd3GY6E5iY2XfI3dNYQBsEqYGF28muJC+Jh5neSURPEw4FBx3hKhNn4ptDFLbgMP2Q+fzXGbb8DgoCkauIHNOJlbCO4FSAckkR9I9x6EnZ1lI/q7kINPr4nQUwbd1SdUqyu6J8Rv5QYVza0tWlJLyF9iJ1ZjdtqjgaJ0hBYuI6TWqQBJUPtNVxuI4P88JBgKtMKC2KfZeKxVAex5ptVCGyJCoikII5G/Wmjwq6MJHqEihvWGowXbw+e1QUDEMQ1oJC9q15JcQlwTBmetGugpiBQVM+/9new98Krw6Te1mfyawjTkw39kP0sfmtvMC++mRXRphAYk9LOej7XbM1Zh9CuJdANBfNqCryHBZoqo82IuHDFpOFwQk85UPLRRqpNMOYbqdlbYirAkG8NFFEZdbBCAsf7uw XPTuriEY hgZyY3nI26iFJFsyjd3tq4B05PSWvbV8KfOaOaPCAK6llYeXLd4ABQexze/2+Umowa41aNgUQSjaYfiD/h1LU2CZ1bTWLG38kLKHB4HxLV7qWVa4pB3ptHBfIl1MTS6UPbZyKryXE5sb7guy7CF5IDJOByJliOVmiclwxDODZseSV5HVa5fBCwEgjNY2hbmB+h5HmNSHAPIz2V8JuujTNFgJjnomzbBbS25SXCchUYDOhZI+hOD4XkOKZRKh5m0BcKYqX/KQ8KMYMun/j263mGr7ISjzOqJMr5wp6EQcdrCTB5BxmhH6mwPz4fsaSOp/GJOOjJGHM791jE/oXayn1TEU+M/TaElKYV4Wgyn+3ksukr1WFOn/y3DFng6UV9vscftlOHvTCIY6Uj3w8hytT/S3PMBN1KydB6tcC9ZFwC6uIBW1OF/PjHUOB65YxsYwx0M4EZG/yBKjm3VtVN8Ru2O6coH3VBR+0uoD897Fth/IGJDo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.08.24 09:50, Kefeng Wang wrote: > > > On 2024/8/2 4:10, David Hildenbrand wrote: >> >>>> >>>> We're not checking the head page here, will this work reliably for >>>> hugetlb? (I recall some difference in per-page hwpoison handling between >>>> hugetlb and THP due to the vmemmap optimization) >>> >>> Before this changes, the hwposioned hugetlb page won't try to unmap in >>> do_migrate_range(), we hope it already unmapped in memory_failure(), as >>> mentioned from comments, there maybe fail to unmap, so a new safeguard >>> to try to unmap it again here, but we don't need to guarantee it. >> >> Thanks for clarifying! >> >> But I do wonder if the PageHWPoison() is the right thing to do for hugetlb. >> >> IIUC, hugetlb requires folio_test_hwpoison() -- testing the head page >> not the subpage. Reason is that due to the vmemmap optimization we might >> not be able to modify subpages to set hwpoison. > > Yes, HVO is special(only head page with hwpoison), since we always want > to check head page here (next pfn = head_pfn + nr), so it might be > enough to only use PageHWpoison, but just in case, adding hwpoison check > for the head page, > > if (unlikely(PageHWPoison(page) || folio_test_hwpoison(folio))) I also do wonder if we have to check for large folios folio_test_has_hwpoison(): if any subpage is poisoned, not just the current page. I don't think folio_set_has_hwpoisoned() is used for hugetlb. What a mess. -- Cheers, David / dhildenb