From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9745CC83F03 for ; Thu, 3 Jul 2025 14:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33FDC8E0008; Thu, 3 Jul 2025 10:32:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 316A38E0005; Thu, 3 Jul 2025 10:32:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22CAE8E0008; Thu, 3 Jul 2025 10:32:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 145D18E0005 for ; Thu, 3 Jul 2025 10:32:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8EC0A1D3766 for ; Thu, 3 Jul 2025 14:32:02 +0000 (UTC) X-FDA: 83623192884.25.6A03DC5 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf27.hostedemail.com (Postfix) with ESMTP id C63DA40004 for ; Thu, 3 Jul 2025 14:31:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=olvR6EZ1; spf=pass (imf27.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751553120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eRsY50z3YQA/nIb5B7MZxVRcf3v888DImdHoogzEoUQ=; b=OexUJ89GrAOXI5uC04LpIo9P+ETjxURQErWXwxvlTkoZ+N+1E7b4xckIWB00kmi171RkgR hCHkPnvf+J87Jb3JUPm1pNyFQa0+l3gGTPS3LDiMBPfetwbMSZqGBGwiiB6EuJrIBRYMGb 99gkviCOvv8AtO6Jl+PedWMwRwwJGno= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=olvR6EZ1; spf=pass (imf27.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751553120; a=rsa-sha256; cv=none; b=8CNEUtGZ4q2OOQ0JHA2bi+xoLJ+38r76eyxZCno7j004q5qcIuBl3CKDkhVBHz2Te9QiCL 7xzG5Cz3k+FzyKFRYr+0kVqzrpasWnjsHzfw3loy8p2HIqRRXmx1sxo5ePLrUzAdwLBen8 NtVWpdOQjscEaS6Fcws+PdCAFdVuc9s= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 563BMWSQ028339; Thu, 3 Jul 2025 14:31:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=eRsY50 z3YQA/nIb5B7MZxVRcf3v888DImdHoogzEoUQ=; b=olvR6EZ1PllwopurFL2+/8 dR6wYnsRvXeR85ieEdT4QRwMgXmQcY06rtq9noa2M59NrPqMUI2vlsOUDv8b5ANP dqmS9FAQRK2fR0cLI7kwDohOyY58cdhmZXOI0JRi4r2mpEs9qvAXAv8+Xl9NRoG3 4lS/qr31alc4o7UAOU4yKPbuIz/f59Rki8OFA1VDzMKh4QKEaYueYzuuQC9lOwGi Sx5LD7HNOrmeklleMV5nC2pjSlq4TbcnYqa3EjhAUje64+cBb0q+9FhCLlaX4igq jDW3F7zs1eR5dUBMRlmEAaneMKTpFJQ64JQVUgWp4CplG9H7kqErYApWPrbxtODQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dmf88-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 14:31:54 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 563ELTeZ013840; Thu, 3 Jul 2025 14:31:53 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j84dmf85-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 14:31:53 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 563BZBHI021354; Thu, 3 Jul 2025 14:31:52 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jwe3n28u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 14:31:52 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 563EVqoC25952908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 14:31:52 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BC5358043; Thu, 3 Jul 2025 14:31:52 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DBAE758059; Thu, 3 Jul 2025 14:31:46 +0000 (GMT) Received: from [9.109.245.113] (unknown [9.109.245.113]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 14:31:46 +0000 (GMT) Message-ID: <1b6e8526-59cb-4de0-bd82-8b0964cb6233@linux.ibm.com> Date: Thu, 3 Jul 2025 20:01:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] selftests/mm: Fix child process exit codes in ksm_functional_tests To: David Hildenbrand , Aboorva Devarajan , akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, ritesh.list@gmail.com References: <20250703060656.54345-1-aboorvad@linux.ibm.com> <20250703060656.54345-6-aboorvad@linux.ibm.com> <9586f8ff-3b34-4613-853b-0c808fcbb9d2@redhat.com> <7b78974b-6841-4280-89c1-01bd835d4f27@linux.ibm.com> <42c0135a-dbd9-47e1-9b9e-c36c147a2315@redhat.com> Content-Language: en-US From: Donet Tom In-Reply-To: <42c0135a-dbd9-47e1-9b9e-c36c147a2315@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mlj0ZM2IlX8Yno1D-kOeHnHdVJh9pEwN X-Proofpoint-GUID: jKPDFIyjEgTEYq_-UPmCyt1NWA0zHq5I X-Authority-Analysis: v=2.4 cv=Ib6HWXqa c=1 sm=1 tr=0 ts=6866945a cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=wdEVuivgXQAh7QcTvTEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDEyMCBTYWx0ZWRfX3u28tBnifZBA NgQcSJcGDE5fQh1ikDPw0BVHJVirVRARwJXc7caBlMeSOKmcQLYTXpFcEajWhW/eYGxViOl8tr5 tXyJh1Pv+M0MopBB8Qd0l7SF/mEkkXctLVFZ/SjLu6aFtpr/uZfm6fOsnCBeRHFRrRI5T8rs20n F0Vz1owkzLQWEcaK37zlDeHo8eHuxS7T5jc9G2LCwcynPbqgtN6HLRWSPzuNDHI36XBVP+LWvL9 X8pOB9Sp4m3HMvMZ3GO1hipcfoQaUPQ3i3uTLpw8iIPvKLW1Y4u3W1iyufk+XdZWGTEBBCnRxex 5o704DHbL5dIDV7kUpoBxAKKmQN49HiQQVdgwCUFoaqC0pF8SszqR/XqztC3reZWYkLpyPZEpik VXPPvI4zLl4QRee6TgisnNk6Dm+xeTJHT/xMcIVrql4kyh+exUeRvd5/4inOhvi0ljMT+oWY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_04,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030120 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C63DA40004 X-Stat-Signature: dyx49ekeaq3wbyjubzbgi1t7sfb9husp X-HE-Tag: 1751553119-828304 X-HE-Meta: U2FsdGVkX1/CAQNxH7KGm8HY0JN/ZP2oMuIo0076JI5cfKTCB4xh8qWkG8Qc0wzy95C/sqg5RmpSXAMV4hndAEAR2nWG/EXYebv1KzU0MB9JD1qBvcpSzHXysTg5eHJs0EiQlUotWcraYljH5fDo0UJzHg2GdIRUJ5rcRGfc21xrlWMlTPWElXHZPSfMtYuUGdpssihNlt0dh7DGNyCuatfHjG/dyDZVFFX6sYV2hl+xgeMJAk7mva+2oSA14WxA0+HOTdhLng3nVzrUnvIyfz3dv4tr3RGTwnj+QassPJKNeV27eb3AmjxHf+F/KVKXyVjzPFiNDLZyP21G7kDQC3nKceR2iDfLBVk/eJvjGlKPUIv1PgAMQUYJogr17s6ebgEdaMVkwyvSGN9KXCp0AWX2eKPhixU8L3UhWYHNsmn/v2NVH2xauFi0YfhwNjP7Toan9kR2+D/O+FfvqLo3mn2af/7iSaGkv1ZZ3/n1OAwi81Kd74p4uuT/8I2iERZZOQy7LthLv4pPQv304pWD0yesBzXt13yCehV8nK+Ha9jPgZZy0WIpSwOXHV/RaPG91BG6cvBHD0GhqAkEpp0kBnANEahBxeu868OaRDfuZALXXK5Elpyfdbhsi7MadroaVbRImHCJSObWxq5tTC+FkJIk60om2vJ90vmUN2K94OgAXUL+WCGl/Of3r7wbw5z9t4U9No416a4xN8gJCB0TQ5P0Qx9uAK7Jbf1Worwtqm4aA7x91ff0RPSaI4dYDTgzS9qpulc4YTSjO+BrHhqmSUJd/xfoLE7hw6j/nVZTG7lU0e5JFD2ivjIR1x9KMEMtxVcDjH9OBZ6kJkClH+cjm/ev56FBryu/2uklxm1J9GJTOeR6OWd6BwOtdIJJalobwMAcyChYZoS7b6t0JKUQn8/A6Gxs4rgoDn0JEs6R9ZrM6VtiwYXdYvLryhHp8OC2dtQTJevkb/6wrH805v1 HPyZm2PZ LtqzARJPJ+dObKAyAyInmcsorPS9m3QWjaSZRgU2A6k07znU47SWWxxlKs3RWwITExcTvtEdGlTU4S6zSk+aqp95mVEuWq9coOFJo+fz6bvM5BSwsYtHfCpZMh1Ful8D3xJewkXRfgksXTmZT6KDUJUpc+m8HvKfPwIGVWkcFDa8vBwkpJeYRPiRUcNGbVDTON6MC6jokzMp7x7tM7d0o9gBCbZnTk6S7kGuVYf0fbODGFXJW2/9X6OjJI0UdDLYvWIhsb8gJ5bI3fAdSkWmnTQMmut6TxFnepFYXsr6V3JpwLL0qmBHz8cm+yDGhyQGQ3KRdpWpjrjwwwoRtVFk59DXRtsIKUlB8vIgiDEDh7NIBM0TDpthhQVgkrAMAPEW2ukNb3NLAm1Dv54CiaZT2BCQR3DNR0wi6X/0DuJy/OMEca/Km/hffQwXS/eJImGt7QzOXQ6GmJsoTVO9yR8rBv3d/hkEPv28bdpje4F9ppp49Zl8i9yoKjIuiuaX4WgFEQdvWYnAxfBmMqeOV/eBWmP9ssb8QrXaz6ZkFIDgWRxBiT6o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/3/25 2:44 PM, David Hildenbrand wrote: > On 03.07.25 10:51, Donet Tom wrote: >> Hi David >> >> On 7/3/25 2:03 PM, David Hildenbrand wrote: >>> On 03.07.25 08:06, Aboorva Devarajan wrote: >>>> In ksm_functional_tests, test_child_ksm() returned negative values >>>> to indicate errors. However, when passed to exit(), these were >>>> interpreted as large unsigned values (e.g, -2 became 254), leading to >>>> incorrect handling in the parent process. As a result, some tests >>>> appeared to be skipped or silently failed. >>>> >>>> This patch changes test_child_ksm() to return positive error codes >>>> (1, 2, 3) and updates test_child_ksm_err() to interpret them >>>> correctly. >>>> This ensures the parent accurately detects and reports child process >>>> failures. >>>> >>>> -------------- >>>> Before patch: >>>> -------------- >>>> - [RUN] test_unmerge >>>> ok 1 Pages were unmerged >>>> ... >>>> - [RUN] test_prctl_fork >>>> - No pages got merged >>>> - [RUN] test_prctl_fork_exec >>>> ok 7 PR_SET_MEMORY_MERGE value is inherited >>>> ... >>>> Bail out! 1 out of 8 tests failed >>>> - Planned tests != run tests (9 != 8) >>>> - Totals: pass:7 fail:1 xfail:0 xpass:0 skip:0 error:0 >>>> >>>> -------------- >>>> After patch: >>>> -------------- >>>> - [RUN] test_unmerge >>>> ok 1 Pages were unmerged >>>> ... >>>> - [RUN] test_prctl_fork >>>> - No pages got merged >>>> not ok 7 Merge in child failed >>>> - [RUN] test_prctl_fork_exec >>>> ok 8 PR_SET_MEMORY_MERGE value is inherited >>>> ... >>>> Bail out! 2 out of 9 tests failed >>>> - Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0 >>>> >>>> Fixes: 6c47de3be3a0 ("selftest/mm: ksm_functional_tests: extend test >>>> case for ksm fork/exec") >>>> Signed-off-by: Aboorva Devarajan >>> >>> BTW, when I run the test, I get this weird output >>> >>> TAP version 13 >>> 1..9 >>> # [RUN] test_unmerge >>> ok 1 Pages were unmerged >>> # [RUN] test_unmerge_zero_pages >>> ok 2 KSM zero pages were unmerged >>> # [RUN] test_unmerge_discarded >>> ok 3 Pages were unmerged >>> # [RUN] test_unmerge_uffd_wp >>> ok 4 Pages were unmerged >>> # [RUN] test_prot_none >>> ok 5 Pages were unmerged >>> # [RUN] test_prctl >>> ok 6 Setting/clearing PR_SET_MEMORY_MERGE works >>> # [RUN] test_prctl_fork >>> ok 7 PR_SET_MEMORY_MERGE value is inherited >>> # [RUN] test_prctl_fork_exec >>> >>> ^ where is the test? >>> >>> # [RUN] test_prctl_unmerge >>> ok 8 Pages were unmerged >>> # Planned tests != run tests (9 != 8) >>> # Totals: pass:8 fail:0 xfail:0 xpass:0 skip:0 error:0 >>> >>> ^ what? >>> >>> ok 8 PR_SET_MEMORY_MERGE value is inherited >>> # [RUN] test_prctl_unmerge >>> ok 9 Pages were unmerged >>> # Totals: pass:9 fail:0 xfail:0 xpass:0 skip:0 error:0 >>> >>> ^ huh, what now? >>> >> >> The problem with the exec test is that it uses its own binary to exec. >> >>           } else if (child_pid == 0) { >>                   char *prg_name = "./ksm_functional_tests"; >>                   char *argv_for_program[] = { prg_name, >> FORK_EXEC_CHILD_PRG_NAME, NULL }; >> >>                   execv(prg_name, argv_for_program); >>                   return; >>           } > > > So we should run it on the same directory where the binary present. > > So, I assume the execv fails. We should handle that, and figure out > why it fails. > > diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c > b/tools/testing/selftests/mm/ksm_functional_tests.c > index d8bd1911dfc0a..0ddbb390df33b 100644 > --- a/tools/testing/selftests/mm/ksm_functional_tests.c > +++ b/tools/testing/selftests/mm/ksm_functional_tests.c > @@ -527,6 +527,8 @@ static void test_child_ksm_err(int status) >                 ksft_test_result_fail("Merge in child failed\n"); >         else if (status == -3) >                 ksft_test_result_skip("Merge in child skipped\n"); > +       else if (status == 4) > +               ksft_test_result_fail("Binary not found\n"); >  } > >  /* Verify that prctl ksm flag is inherited. */ > @@ -598,7 +600,7 @@ static void test_prctl_fork_exec(void) >                 char *argv_for_program[] = { prg_name, > FORK_EXEC_CHILD_PRG_NAME }; > >                 execv(prg_name, argv_for_program); > -               return; > +               exit(4); >         } > >         if (waitpid(child_pid, &status, 0) > 0) { > > results in > > TAP version 13 > 1..9 > # [RUN] test_unmerge > ok 1 Pages were unmerged > # [RUN] test_unmerge_zero_pages > ok 2 KSM zero pages were unmerged > # [RUN] test_unmerge_discarded > ok 3 Pages were unmerged > # [RUN] test_unmerge_uffd_wp > ok 4 Pages were unmerged > # [RUN] test_prot_none > ok 5 Pages were unmerged > # [RUN] test_prctl > ok 6 Setting/clearing PR_SET_MEMORY_MERGE works > # [RUN] test_prctl_fork > ok 7 PR_SET_MEMORY_MERGE value is inherited > # [RUN] test_prctl_fork_exec > not ok 8 Binary not found > # [RUN] test_prctl_unmerge > ok 9 Pages were unmerged > Bail out! 1 out of 9 tests failed > # Totals: pass:8 fail:1 xfail:0 xpass:0 skip:0 error:0 Thanks David. We will add this in next version. > >