From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB08C48BC3 for ; Tue, 20 Feb 2024 04:19:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00DCA6B0078; Mon, 19 Feb 2024 23:19:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFFEE6B007E; Mon, 19 Feb 2024 23:19:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA07E6B0089; Mon, 19 Feb 2024 23:19:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C5D3E6B0078 for ; Mon, 19 Feb 2024 23:19:38 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7D1AE160430 for ; Tue, 20 Feb 2024 04:19:38 +0000 (UTC) X-FDA: 81810878436.13.6D64160 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf27.hostedemail.com (Postfix) with ESMTP id B255240018 for ; Tue, 20 Feb 2024 04:19:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o8S7ZH0H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of hughd@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708402776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3yDTHFJxr+VS+XvRM1ueMsEzg0lq2wm5Qn+rrB+igcw=; b=HTrsWl4uoyensaORaCP9FU3a4q9JOdLlNqv92SJJlrt4HqvJQYWvIl+XmB8htHgBM4VcRK eENmZiqCqI+iJ1QRx9BCJ95SRUFyUv9qysJXnrp3dLfnXupdPP8AbX3rfqpLGWiEVQSp9U R7HQoNNcZwxfU6SWcnRZo9gRoomrx0Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o8S7ZH0H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of hughd@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708402776; a=rsa-sha256; cv=none; b=dcCSaUXltDT/53yLIoVyPg/SO1B5SkDPnxDJ0L6+6+ECho3N4+rtnFK/kiySNmMlDHgQnW X6FF/4XorE8prz7m8cMZ6G0nOw76+1LASZNXPrYMwMZnJiEsF+rHBBm7E4M20vyg7x10OT 6UqXGLIN1S8Mc0MK/2ni6lRtFrFZyTU= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-607cd210962so42485657b3.2 for ; Mon, 19 Feb 2024 20:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708402776; x=1709007576; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=3yDTHFJxr+VS+XvRM1ueMsEzg0lq2wm5Qn+rrB+igcw=; b=o8S7ZH0H7gvYKHyo6MCCcYcZRWj/Ml79rqlz10uC06uupbpFYDLTqHv+2Q1ZwBOUM5 UouCwN9Rwf9FwPaAJ5eEvAUW/H7UK/x1xIfIk0nAzQvv8DBDjfPX0VEDGZn8S/Z1Fuer h0kIqwEJknYRpybBVeQWFZAfA92zlif3qDCXvgd/I/d4URI+RBwctldFBmg6fBYUVyzf NDOE5FFdtrvOOgwFxEJRoZBa8ThEMQAVM2QOUQ/29n1n93tWkLjdmSZD5p0bBZlRqsaq 1zAiXJZe809vce62MPiS+ihcIXOMgehrDdghkhg+EL8BAOxnIrxo6hvavsH7T93xNMG+ od2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708402776; x=1709007576; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3yDTHFJxr+VS+XvRM1ueMsEzg0lq2wm5Qn+rrB+igcw=; b=pf85sWDp6W3R289QeUCt/GDJ0mvtuYBTVKtscVIUH7hEeou3XSBUNrpWyZHXL8h3qG Ar+b0Na0Ew6ArYqJA9fv4fqKAkMDh9++AQ8tBKGczWT6ksAyO8youojhbuMQ0rT6pu68 IjxKeYsvf2r1YacjODSu3uMU3c30XB6VgzL1GZ10eT48NGuSXITlnYzuNo9cjQfS/mTc hNGz2pAglOWF4hflWRLwJUy7NQYzfNbJ+MYne/7O43n/eIRffIE0CLnDNmwWEFZ6fTxX ctzsq860VA46onjgwzAnwO6p0aUv/qTHjUQ4VdBXfJJoXOo1mjS1pZl619Y/7NSlkW3W xlFw== X-Forwarded-Encrypted: i=1; AJvYcCXndx1G32Fb2VdHmjGx3cWC+3xX8daXC7hVIC8OuqIVt/JFozORkhac3cUSzzjNz8pjO/Rv6CK89d99SolwPd+7IrM= X-Gm-Message-State: AOJu0Yx9VPbb6xydJdpkHuC5h+r/rq531Zd60IzS4/67RC7+cZqvxAim e67ANYZ1Pseaw4jh+faiuTQxpnEFAweooS4qCrNuVMKAbIgu9iEEzyDNcPtG0iXwh6YNRynJtJo QzQ== X-Google-Smtp-Source: AGHT+IEO6mWRsxjymRnjsFPE2nZTsN9w9jjs50eAVbYKF4nxMQS0Gs/JUrBqUkJANqBpkHPzkl+7tQ== X-Received: by 2002:a05:690c:3513:b0:608:3cab:a01a with SMTP id fq19-20020a05690c351300b006083caba01amr4929744ywb.17.1708402775627; Mon, 19 Feb 2024 20:19:35 -0800 (PST) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id a125-20020a818a83000000b006040f198d3esm1917030ywg.142.2024.02.19.20.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 20:19:34 -0800 (PST) Date: Mon, 19 Feb 2024 20:19:24 -0800 (PST) From: Hugh Dickins To: Andrew Morton cc: Carlos Maiolino , Jan Kara , Hugh Dickins , linux-mm@kvack.org Subject: Re: [PATCH] shmem: Properly report quota mount options In-Reply-To: <3uyerhrmrt2hqaq6j44aiefatlf6iitnh3eqgmonaahy22twa4@rqf6wj3yvfle> Message-ID: <1b6944c9-d27b-79bf-d0ff-5dad5c65b1b1@google.com> References: <20240129120131.21145-1-jack@suse.cz> <3uyerhrmrt2hqaq6j44aiefatlf6iitnh3eqgmonaahy22twa4@rqf6wj3yvfle> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B255240018 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7gj8mwm6uwa47nrmgqm5mni4cs55s5ym X-HE-Tag: 1708402776-842846 X-HE-Meta: U2FsdGVkX1/cXPNIzJEwvXdDLQ9Usd3A1NFxQkhNKW6Y6En6KkUYtuXAJVPYCrFYXBrx1qZRfr7uM1TmMFzldnpqBjSRLgmC8qhDTwCrpNU7F6DeUIbImdPoZ4f+IiRlc1QarQVg+bM4ElBpGhabO/IavDBFn/gaAGkv+JuQvDcKm9KnSJZDHh8C1onhduSXQHRv9RJCuDLf55HhYTNc6u6yVYG9aNa4BOooclHGEE0/0Fyfi9B/IBH+IiDBUj/npq0jB8/s9I2SLHHQMJvPh3/YfB6+1qICFfFJzIElvkJzZbBHOf83nedL/3NVYpK1AmZosL9sQwGT+raclklpWzF95gCuPYZ8K4VR7zW/y9j9n7D2BTmP4HPEAjTxiPxrS5LL/3oz0Z8E0Gi0bBcdek9hxfsdVA1qUs4QJpuUhbMnq6c4U7RKVIanjBqFptHoKFie4x9H6Cec8BIf7P3fsG8OX2bvZ1LIiVKivdN+6xvpu8FurgyxRdfciquihWVwmHn0Vu4cUIXlHsfY7DZCtTXBgIWrewOM4NiuZUBuQxCgf5BCosFiahf/nwCZlgnZv0o4xu+/PjhVDGQIin0u5MRjlbl+8FHUxdK+NhX/5kfviYTfYrAYH/bCQhrBDnQ1I0AF1p1Xm1R2z3+Q9Z0bxZEARejlUW7BGmWbxo33/pWpwqRtszeoaHOQE+BWxjnddjHAZgJXZIV01B2ImrY9vF1WgxennQcFnxKquj5eSfsemWOFF/AO85wsdClSs2LZREsabTBEu9XbQVK2BbHOJ2NtAiDuY7i8jfCDfOI9Dzizwob8LPdz5YrQADzyDlVjLFHQUEscNXjCC7+Qvlv0AjKTPc+SfHZdSg3QlvW1ydMWh6xOF5tjmu/i2IrPCbfFqKLAIAGG9fF7HbZO5XbjPxt+MPJjwoxy6ZqOL/53WiNf5r8ZqnVLn76qf1w2mQ6VRGxonzm0N08D3mTpy8g 1HBiHdAp uurYc1G1POs1ys/czIfQbTAo33GLOoEi0mRcg8t9MalNZKG83MAhHN8Hu+SgFOtjbKC7H4uQOcKIQObcx9H3Y/JROpRyXyREjEkCHulP7qZs1FXDmawBWf6OcH4b0SCrxi9NOTV5h3dpeNA/6k8/DR5/RfMchK7uo8tPf8wVkpNbTeJwGJoqwh9khBuyKuQ2iME63zIn+nh7ke+5TIfWQvH6JkegkgIJ/hO49gBk4QmYOOqqfFvxR6L12Bs4d9ZcZOkn0ZsSymW2fDIBn3htpuF73w5iq4YBJyDVDge85JQWWIenoxOsK/c+0y2k/FPCxQh3CkhD5R2YQnlhxGX9R/ixtmsc+qtVgsVtJUY4G/Ebq/IO8toMWS8LElw4MZaO0+b4lB7U9RPCKUruav3tWFcAlr7O0IZAItE3pE8xB5muLGk5jjeLcLWnO1Jan7cJ3rv6hT9Zt+rBqOcWPWJ3LJ2hefQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 Feb 2024, Carlos Maiolino wrote: > On Mon, Jan 29, 2024 at 01:01:31PM +0100, Jan Kara wrote: > > Report quota options among the set of mount options. This allows proper > > user visibility into whether quotas are enabled or not. > > > > Fixes: e09764cff44b ("shmem: quota support") > > Signed-off-by: Jan Kara > > --- > > mm/shmem.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > I've noticed this omission when testing quota-tools support for tmpfs... > > > > diff --git a/mm/shmem.c b/mm/shmem.c > > index d7c84ff62186..30c9dc862505 100644 > > --- a/mm/shmem.c > > +++ b/mm/shmem.c > > @@ -4265,6 +4265,24 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root) > > mpol_put(mpol); > > if (sbinfo->noswap) > > seq_printf(seq, ",noswap"); > > +#ifdef CONFIG_TMPFS_QUOTA > > + if (sb_has_quota_active(root->d_sb, USRQUOTA)) > > + seq_printf(seq, ",usrquota"); > > + if (sb_has_quota_active(root->d_sb, GRPQUOTA)) > > + seq_printf(seq, ",grpquota"); > > + if (sbinfo->qlimits.usrquota_bhardlimit) > > + seq_printf(seq, ",usrquota_block_hardlimit=%lld", > > + sbinfo->qlimits.usrquota_bhardlimit); > > + if (sbinfo->qlimits.grpquota_bhardlimit) > > + seq_printf(seq, ",grpquota_block_hardlimit=%lld", > > + sbinfo->qlimits.grpquota_bhardlimit); > > + if (sbinfo->qlimits.usrquota_ihardlimit) > > + seq_printf(seq, ",usrquota_inode_hardlimit=%lld", > > + sbinfo->qlimits.usrquota_ihardlimit); > > + if (sbinfo->qlimits.grpquota_ihardlimit) > > + seq_printf(seq, ",grpquota_inode_hardlimit=%lld", > > + sbinfo->qlimits.grpquota_ihardlimit); > > +#endif > > return 0; > >a } > > Looks good, thanks Honza. > > Reviewed-by: Carlos Maiolino Acked-by: Hugh Dickins Andrew, you were not on the Cc when Jan posted this, and I have been dilatory: but please pick it up now for mm-unstable. Original is at https://lore.kernel.org/linux-mm/20240129120131.21145-1-jack@suse.cz/ with Carlos' reviewed-by to be appended. Many thanks for looking after it all while I'm preoccupied (and even when I'm not), Hugh