From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02AA0C04A6A for ; Thu, 10 Aug 2023 19:03:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53E6C6B0075; Thu, 10 Aug 2023 15:03:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EDE66B0078; Thu, 10 Aug 2023 15:03:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B5B26B007B; Thu, 10 Aug 2023 15:03:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2B3596B0075 for ; Thu, 10 Aug 2023 15:03:05 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8CCC3121118 for ; Thu, 10 Aug 2023 19:03:04 +0000 (UTC) X-FDA: 81109117488.25.3F89C71 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 76442100005 for ; Thu, 10 Aug 2023 19:03:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691694182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iq9xatht8bNqRDHtDODXQKgF7aRWEuTRd1QCXb+gRF4=; b=1b2QqGrKf1iTDErIzfH+1N/MVwdeXJe7hoqApCqLdihN9FK/2RWAE1lf6yfQ09IcMRlfuI QZTMvB6d6EfvwsgJJL6gC+OR41Ji6ZRnOE4kXBBdwNsgk0g7tKIqti5QFmiloUJXx0e+lL Nps/z2kOeWlMc2ad+JByki2wN6dNluY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691694182; a=rsa-sha256; cv=none; b=Ljg0NbMrAFx+XQmjZO9WTt0yzt+7PBjtbnO5QcaA/ureFBC5xUPqkNG0gxG4Ju4Bt1YO+w rJAy6V7jN6iiGqOY6q2FMgz27milVra2YHDjyEO+ZzegVkojIPxS6LVGRaA6rixzxAjS7p rm8E5U5XjWloil2VQUXMvQIWS/x/M3s= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A228D75; Thu, 10 Aug 2023 12:03:44 -0700 (PDT) Received: from [192.168.0.23] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1517F3F6C4; Thu, 10 Aug 2023 12:02:59 -0700 (PDT) Message-ID: <1b68f3fd-54d8-4bcd-a986-c84ec2219b9c@arm.com> Date: Thu, 10 Aug 2023 20:02:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v1] mm: add a total mapcount for large folios Content-Language: en-GB To: David Hildenbrand , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Andrew Morton , Jonathan Corbet , Mike Kravetz , Hugh Dickins , "Matthew Wilcox (Oracle)" , Yin Fengwei , Yang Shi , Zi Yan References: <20230809083256.699513-1-david@redhat.com> <155bd03e-b75c-4d2d-a89d-a12271ada71b@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 64ucc6piqo1z37h7dcst4sk37xtg6dkt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 76442100005 X-HE-Tag: 1691694182-253469 X-HE-Meta: U2FsdGVkX1/hOM7c8G+hROCvK42Gv7Si//vYpceYYo40Re/mLcQKEvVtnid4Q+v79L1+BvqVWiU5zLHJ4+kVOkDNZTHSXb/9CBHUTNDT/wqfTm2bWQ2SLPqFmgTTGaGGEeYfBmwKvQs0xM3l4MUqPocuEhxY7K8MHmJaIIhHjyC09pB0ef6EVix98CJ1QUhbNF5m1QY/1E4BAkk2REb5+FHpvKUJQuY2Ac5NRkqU/dqu5A+b9XHEWxRm0I66m5b9o7BiIzH6tQiWoTbi7ayzBCbSF6YN5j4dvvATTIdWbZXtHmLh9AaKqBK/AS9+rlm6pjtcf61df1HrW0RKiGd8DYP2wrc+Cz+pwVSkfBlM5yp/BI+37iGnEKbj2h2X0iZQteWY2Q0mnh1lm6yQzkI9wfouxaJpZK82I9chbhQ8Tl0mf/DmYeJQ8htn2u7KsV0nPA4QzsYSrZGVZwF9YwQ6fNZj8ugnfQv8xAS7mBJLPOksxekiihP8p/RNVhcTQfOH3/IFH7ULVCtc8JVP8qwjViAuzoFJxKgYXKspZoo+UKIcPVR/yT5BBhyK14LQAajrxnZo7/R5csukeZvCI0aC3JdOX1RBeNocd0/EhpjPI2WVmme7kJxeXUSKq4mR8x+mHUBXzA7XuaU1KDfIFeajNQF8inUYlmnrAxD8o30ihGZuEPxj7V4Upyo/EL+kYx6Yl5ofcPSrS3tCP5Av6D4Fjad+Ksivy2mmWoemrofttVlDbGrQgzAYl65Kkat9iMYn6O81XBADOm518v7zRnOU5HZ/b9NQX0z9bzNBmtcLDH2eafcCZOBq/SmbfgFR+FDQ4U6rLwZGDY1IgDsZgC6O3TmDeIkXzZbu4V5aM7yWCtwfwO6kUSNVSPpGP0lvCb58w5elDWsg+qKN253Ok8I1c58jvRmhp3zYmipFJSpsym/R6UBUneaN/dRn5woaTiQF/mwEKXBDf5OlA7skb6Z KrP+Bt7S SP1yg7Twy3Mf3qEKbWztW7nk0nmXWl3JyoV8Y4RVfnnScc5if79qZnzJrZgsdpyVIdDhstACWsdWhziYnBKmJ+eAxOp/S7cPllnkqN/eW2YWZA7sP9iGS0muHWZUle3u97mntDVNQBNMxXiM3mTlqDNrADRP11pWD3yu6QhA+vtoV50zN9Vp7N1L3nXGKgjpPWn1CbYhOhSc2mI6oBw3W1m0kC+p96oyc6Oqdi97dBurkn4JG9Ihc9zCzOXPXULu4edK9XEqQX0Mmdcc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/08/2023 18:47, David Hildenbrand wrote: > On 10.08.23 19:15, Peter Xu wrote: >> On Thu, Aug 10, 2023 at 11:48:27AM +0100, Ryan Roberts wrote: >>>> For PTE-mapped THP, it might be a bit bigger noise, although I doubt it is >>>> really significant (judging from my experience on managing PageAnonExclusive >>>> using set_bit/test_bit/clear_bit when (un)mapping anon pages). >>>> >>>> As folio_add_file_rmap_range() indicates, for PTE-mapped THPs we should be >>>> batching where possible (and Ryan is working on some more rmap batching). >>> >>> Yes, I've just posted [1] which batches the rmap removal. That would allow you >>> to convert the per-page atomic_dec() into a (usually) single per-large-folio >>> atomic_sub(). >>> >>> [1] >>> https://lore.kernel.org/linux-mm/20230810103332.3062143-1-ryan.roberts@arm.com/ >> >> Right, that'll definitely make more sense, thanks for the link; I'd be very >> happy to read more later (finally I got some free time recently..).  But >> then does it mean David's patch can be attached at the end instead of >> proposed separately and early? > > Not in my opinion. Batching rmap makes sense even without this change, and this > change makes sense even without batching. FWIW, I agree that my series and David's series should be treated independently. There is independent value in both. It's also worth pointing out that with my series, the amount of batching you see in practice still depends on large folios being mapped, which isn't quite the common case yet.