From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0727C433EF for ; Thu, 24 Feb 2022 19:23:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3FEE8D0002; Thu, 24 Feb 2022 14:23:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DEE858D0001; Thu, 24 Feb 2022 14:23:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB7BF8D0002; Thu, 24 Feb 2022 14:23:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id BCFE08D0001 for ; Thu, 24 Feb 2022 14:23:17 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 799677D3A4 for ; Thu, 24 Feb 2022 19:23:17 +0000 (UTC) X-FDA: 79178646834.18.2CEB60C Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf17.hostedemail.com (Postfix) with ESMTP id 1C63340002 for ; Thu, 24 Feb 2022 19:23:16 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id i1so2697700plr.2 for ; Thu, 24 Feb 2022 11:23:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=clEmBoE5acfF2gaQU5Wymn1ivohsrBcp66owW0vTwCw=; b=LNrYxtpkyVVfVMoICJScMFXUo0rHwiaINcVDZUnigMYd+H/xLqwwqvMhzFk4Ipgyom 5vMfg9P17OZ4Pk2VDFT3Y8lofLf3PrgZlHInDxlWu9viEuYmAk1+6JPjXAiCE0LlMP4t kHQKVVaZJLdToGcuaJa/jr1Af7G3SyRzHwWHJXdvToLFfLBxcHwRYSKo7oRPcBKfC/vW NtHZE90IMf+MO5SMgEXJ4OGksP0g2mzy/4X4lbZaB54fe0zxiq6WyYBRpIwhfbcjWgwf XvfoY+jd1balbv2X7M6KxzJdzqKe4uXM5NrjDYhzohpkOsSke1nogWbG+i2BCd6+H3MN aHig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=clEmBoE5acfF2gaQU5Wymn1ivohsrBcp66owW0vTwCw=; b=YHexniuzP/50gwKc6H/ioZC7nX+QXYSpwBJjEPnuGP4aEfSkoDfp1sbqADnwTaHPfU KCkwxh9zolEKei/LsW9YGd0vMwbCZpAQMQUotTcRHB5xE0BafVllUxhYoi1V56DlSf31 tN6FqFJ56JVz8idsqWf03UTvcNwoZrUdVwtPLHOglCzxpVNKsLvWpQFkp2wTTkg2zfI6 3sWaGSxzyVN9d5UVdQ8FfDI4LOHWDkaAGtq9uziHE6yUJDiWEUpcIDOPYhXJyBNwsige U6N6cTquONSgFsG8r7utvoI9IC8gS5vDIaH5fev7afe6joNG3a73/w6rg8pxsMcTzTzS 6hgA== X-Gm-Message-State: AOAM530609Bbi7aBT5txVhSKXRcradtIQ8X9LiLfF8CTr77P/Qxu2kfq vRVyWlHMDxtdaNlDUuPWAUSbGbrYDVVs9w== X-Google-Smtp-Source: ABdhPJzYNSr+DxP6f/PRS3isytin7hYe3mJ0SSeq4b82nW2GIJ39fHj2ZGGu/uq2IAwDm0mbt6+KHw== X-Received: by 2002:a17:90a:aa98:b0:1b8:5adb:e35f with SMTP id l24-20020a17090aaa9800b001b85adbe35fmr4223123pjq.192.1645730595880; Thu, 24 Feb 2022 11:23:15 -0800 (PST) Received: from [2620:15c:29:204:e8e6:cf42:a32d:384e] ([2620:15c:29:204:e8e6:cf42:a32d:384e]) by smtp.gmail.com with ESMTPSA id y39-20020a056a00182700b004e19980d6cbsm211760pfa.210.2022.02.24.11.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 11:23:15 -0800 (PST) Date: Thu, 24 Feb 2022 11:23:14 -0800 (PST) From: David Rientjes To: Miaohe Lin cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check In-Reply-To: <20220224115933.20154-1-linmiaohe@huawei.com> Message-ID: <1b625d1f-96eb-5535-1fd3-4e5ffa7d6c3e@google.com> References: <20220224115933.20154-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 1C63340002 X-Stat-Signature: 44z7ih8h3huim93ck8k17emqrkectfki Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LNrYxtpk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=rientjes@google.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1645730596-193255 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000148, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 24 Feb 2022, Miaohe Lin wrote: > oom_cpuset_eligible is always called when !is_memcg_oom. Remove this > unnecessary check. > > Signed-off-by: Miaohe Lin Acked-by: David Rientjes This keeps oom_cpuset_eligible() only in the nodemask eligibility business and memcg criteria remains isolated in its own function.