From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403D1C02196 for ; Fri, 7 Feb 2025 07:51:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BA046B0083; Fri, 7 Feb 2025 02:51:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 667BE6B0085; Fri, 7 Feb 2025 02:51:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5565B6B0088; Fri, 7 Feb 2025 02:51:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 372DF6B0083 for ; Fri, 7 Feb 2025 02:51:20 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC701A177A for ; Fri, 7 Feb 2025 07:51:19 +0000 (UTC) X-FDA: 83092378278.12.92D0208 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf08.hostedemail.com (Postfix) with ESMTP id EEB65160002 for ; Fri, 7 Feb 2025 07:51:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738914677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVkowqxFt8bYO/7HMkzo3s7+Eznv/Urk0whfAB48IVo=; b=FMB3HoiVNDUT8gv3h+44eIa3bs/qoscl4PTsk1sYNPkVjkiLz0jnM/Zt4FhTONKKJwxd8r zc3A/d6XU6ypQO7lslorgQ2B/3W9JK1MxQEPl7kJtFQsXt/pqM/cQDOn9rgnaT5FZl/FbL /+3ZeP0Lbk1odEGbZ+6r+LUCa1Ns0EQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738914677; a=rsa-sha256; cv=none; b=1t4xtj5Vfn1cThQbyyHTzboepQGUZvHsNQyRKxlkEE8jYLk3+V+2fsdMLXDROuSll1P7U6 Bgat3XjuJ2o+Ngb2GDOksNeicES3YE9dS4s0OPftp0hQlqjHF4zDSAqVBg99G6VtfyBduN EEd4mvoU2U9sspRDPWNJUuI3O2OVKyI= X-UUID: 4b311c22e52811efa216b1d71e6e1362-20250207 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:2b91d666-3be3-4bd3-a863-acd9e749915a,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:2b91d666-3be3-4bd3-a863-acd9e749915a,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:cc5e5b58d7cdf6f0a1fc14d7143cf5bb,BulkI D:250207144718WD2CAVF2,BulkQuantity:1,Recheck:0,SF:17|19|64|66|78|80|81|82 |83|102|841,TC:nil,Content:0|52,EDM:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:4 0,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE :0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_SNR X-UUID: 4b311c22e52811efa216b1d71e6e1362-20250207 X-User: liuye@kylinos.cn Received: from [172.30.70.73] [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_128_GCM_SHA256 128/128) with ESMTP id 935327732; Fri, 07 Feb 2025 15:51:09 +0800 Message-ID: <1b58ede7-062a-49fe-bea8-e99b3dd7b2b1@kylinos.cn> Date: Fri, 7 Feb 2025 15:51:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: liuye Subject: Re: [PATCH] mm/mempool: Use kmalloc_array_node to replace kmalloc_array To: "Harry (Hyeonggon) Yoo" <42.hyeyoo@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250207055213.141890-1-liuye@kylinos.cn> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: EEB65160002 X-Stat-Signature: emjzxgkbzwwdnsgh43bowiw45fcmbqbi X-Rspamd-Server: rspam03 X-HE-Tag: 1738914676-157330 X-HE-Meta: U2FsdGVkX18E9j0fh1q2vU/oUo+6G1hbDetFU95HpOdn7N56+ljrKQwPx3+OxokG216WBWsKI5/db5GHfm09eLl/4ialYpPqJynOJugqt8EZxLMoLpCzbTxohbv66uaWc+eciDUP6baXVtpDVB6fk1+rl1ih+92rTbfbA3wHrg9kWv7y5iBo0BEUiNaacWbpN+yjR6/4qnrDtq5lOtLp/Zd5BCwJm6lUolo7mI/qotFBX7nogn3X1Mgfk1x9vFwHuM1o7tSCvCrsL7OJ1rBpax4lKiwzoFkpmDC6E7z4Lfko1ie6gSOXIoojU7K2Xh4xAxDDsenIpuCRlWWwhK8tCWd5imoosCzudK2LNSyQjBQ1YRVd9L7mLOurDic/y+MVhyVq1AkQr/JjCu1oNDQ8IXHGodtoB46+j0yTolaDxZX+O9RrLMdFS30b50Irb24EdsG1Vx4taMfoqpq+5Gl4dIoeHpLH/FT0ztb5wDyIENG83Jazj86WTOSv28YZYmJDehFQKm137As/ZJHn+eN0PTtZZIp8PPxMt7NHxT+/qhJLH+FGP5rWmhG2zTe1PDvI829KL5xJVDVsiJ6jGPM99AW/Un6WzeuGkYiCtvv2x4Xv3yWcIVAzwrB9A7gFTsi8o59R3GknQRmQYoMrx4tuD70Jfr4C1UrpA/JCcJSHoHiebBapvNCcjw0XbI9n/kERtipEsaNH3mM9rHbjmFfkHImIYtIUtMZ+UuSiVQbAKfsKDbtbq7otxP18ujJiRYsLD8kpsn5EM82sGPOgut6WKY6OZdlKtXnZA0VP5Vtenab+ZaXy81Hu1wMcKrKpGH8Y1nMVenwpH0h1iaOpJVOMsG7npeevRNQ55xUBhN9eJ+2y/A7jlNMi0BTUj257KQM+GMN6EFeksAnKQapdX5e/bockDaLuIiLlKw82x5uaMkHX/JbulWdJUmTYRWTRvyhwu2tmYwhmoecwq1zzWdJ n7uB/pM5 U54RaV5MJVWwJx1s6LsjUmzbpGax13ldODqb4AXp8PflFkwLJDWmjk0wsBeOOItTplnZ9Qe4LrhloIxEu+9aqJTXECRIhE6AiQuLRgTv0IFYOeLNiVgIzjxZZrBhTCZ5uPfVYZdL6ZhHgUM3yYZM1ULbxncVqY5MCibBPmX3MuIPU21dnpNF+gnsjeIFfgv9xnCjDcB5CmTLYbjso9R/bLdMHNo/OGSf4jmga X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/7 14:47, Harry (Hyeonggon) Yoo 写道: > On Fri, Feb 07, 2025 at 01:52:13PM +0800, Liu Ye wrote: >> The kmalloc_array call could be replaced with kmalloc_array_node >> to allocate memory on a specific NUMA node. > > Why is it useful to replace kmalloc_array() with kmalloc_array_node() > in the code? > >> Signed-off-by: Liu Ye >> --- >> mm/mempool.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/mempool.c b/mm/mempool.c >> index 3223337135d0..51eabcc87177 100644 >> --- a/mm/mempool.c >> +++ b/mm/mempool.c >> @@ -328,8 +328,8 @@ int mempool_resize(mempool_t *pool, int new_min_nr) >> spin_unlock_irqrestore(&pool->lock, flags); >> >> /* Grow the pool */ >> - new_elements = kmalloc_array(new_min_nr, sizeof(*new_elements), >> - GFP_KERNEL); >> + new_elements = kmalloc_array_node(new_min_nr, sizeof(*new_elements), >> + GFP_KERNEL, NUMA_NO_NODE); > > What do you mean by 'allocate memory on a specific NUMA node' > when you pass NUMA_NO_NODE? > It's essentially the same as what kmalloc_array() does. > Yeah, my brain short-circuited. Discard this patch.