From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07687C369CB for ; Sun, 20 Apr 2025 02:47:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C74B6B00AF; Sat, 19 Apr 2025 22:46:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177CC6B00B0; Sat, 19 Apr 2025 22:46:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 016E46B00B1; Sat, 19 Apr 2025 22:46:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D62906B00AF for ; Sat, 19 Apr 2025 22:46:57 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E3700160B84 for ; Sun, 20 Apr 2025 02:46:58 +0000 (UTC) X-FDA: 83352884916.07.736B398 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 22F24A0003 for ; Sun, 20 Apr 2025 02:46:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=j0WHheN8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of rientjes@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745117217; a=rsa-sha256; cv=none; b=EgeXyIW6nZDIlYSXrNqeSb2SnCGeZHt1rL0R+txik1ZGhMGF1g5/yxrVVj9WACPgvOE90V UJ9Al094jW1QtTb6R1ifGY0ZjaYzE+DJWK/NOvgbaFVtzpUyTci073eo4WzJ/3zlemozCH LP9XHk8iOUAyUZ7tbVDncOLdOEwggDU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=j0WHheN8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of rientjes@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745117217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g3AbfIt9FSCD7UR2vpfZ4Tlq1YzE8cazt4gjeig26RE=; b=0ufJ0lxadgpg5Xg4qWMZAfZLDl30FqS7hkhQxxBnoVxpqtjeNHLnhMZUMkC0hofjSuQSR5 gh5Vx2/DG4+EgR/WGhDAXm76ms17RzUeFk9WQZQAetHcanltcqEhPfMH1NHSWRHs340sk/ 3lFAmf0eBn61QimekyvMs226hGlUE24= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2240aad70f2so442575ad.0 for ; Sat, 19 Apr 2025 19:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745117216; x=1745722016; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=g3AbfIt9FSCD7UR2vpfZ4Tlq1YzE8cazt4gjeig26RE=; b=j0WHheN8bYkgLU1T5R6nqAPAtvqoKhkqxUdULIbMKMRAt01JWvthqvxIiHyvJ4f6CX MIxa5o5Q/AfVuvrRxdv2GX9uAQiTd1wdYF5DZ9tiWGorkBB94qFU57Jih42KcmOM7YR9 5Okb90TM7EfwJYmC0vGZWsaPVKk1Eku12F272hoG+engE1+Bh7QBe23HR5jiLMFCI7S6 fQE+SjtIGnZJkJEL7fAsK1RabuavP6kDypQFQDev2YFB5vLYPrxfrPHsymxtdLddaA4r r9t6R2XxpwTr1jr70mJuwCE2dn3g31HSWpwhfFseY8ojk5Z+TOggoeAG/99RHILOrz/R d/qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745117216; x=1745722016; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g3AbfIt9FSCD7UR2vpfZ4Tlq1YzE8cazt4gjeig26RE=; b=wmm5TTMhiVWNMTcCRPTfCBTdoPqEEfReqv27MUgWq5MXZKXaNJVECByTuT81me6OV/ 27etAPJkOGj25+cuWW2ojpkb6UAQJsIFIa3LS1BbSW877LFgsreOMKzRMOjX7Rww6cK+ pkzOE4OuvViHQN3rVIvivz9jq1oFmaK9BZSMlLuUhrHrDRuEocLKf4CroJ7Zu2WDlJRs Tf3ZJJ90/mJJQNIRnLcKL73UzXg5SiZVDTxmR4UWmTtWJdY+TYfxEIE7baL8iS8sOZai n6P39seRV1BjjLMw0lFuHyzBs6KMTabwpxVYAI5Z734Cm9lc5cImoTC652YO09VbcPul CMkQ== X-Forwarded-Encrypted: i=1; AJvYcCWC53N251cJsk32Z2hFrK42pB9tsbOaf1G7/CGXQPoAp2izTlq1EG7pS9eydT/UB47mAZdTVinUXA==@kvack.org X-Gm-Message-State: AOJu0Yy1cjvmoq0NzNtHM6gdewjn/lRH85yflZzdDRN0EuGLfiZ/viG/ yapLuNPBH4nQE/dEdaO/tyhXEjMg3aT7t+RhaDz1qDuQKrI+Fq6+/j6tWB6Q1g== X-Gm-Gg: ASbGncs2GUsCmzaP7EStXYeMhdoUXBMwhd7BssDZvf0HKogsUr0R9lV1Fk1Kr55gNsT bnK+AIk9+eiLkE9tW2mQzEHvvOgjod0P9dK5IdNy/cJNu6ZP3UmNEDVHcgTErrhyn91Lb0Kjywd hTEd41uaOxz9HeNqmtjNpj802JKamqffEuai27y8X6kavao8qSUanybYX60qaVblTQNBmdXWwdm fYvImQ2T8ygvNN1MVEBvzL12tW7fquAJIOQnqKX80/ArgCYi44wwZfMOHV+DwRKm2Aq43047Xy+ 2w0Lhdd9IrInO/JFJVY0SUSdk1+DxV6M8/9Za5iua4dsfkWi3uwFa14r+vMh0qwqbCnbc+U084t BY7PaXZEOwSayTPJFxxYvArTUbAhCPB2LVC4= X-Google-Smtp-Source: AGHT+IEB1MivelMqBg7qBRIjgszdRZKSAAXNwNwBAgpJqNtqVqVuwjKnA+G2zTtSG4iwngyXa2WwIw== X-Received: by 2002:a17:903:3d0d:b0:224:6c8:8d84 with SMTP id d9443c01a7336-22c529e6033mr4798395ad.4.1745117215563; Sat, 19 Apr 2025 19:46:55 -0700 (PDT) Received: from [2a00:79e0:2eb0:8:3e8e:d566:514d:339b] ([2a00:79e0:2eb0:8:3e8e:d566:514d:339b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3087df4e15asm3841408a91.36.2025.04.19.19.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Apr 2025 19:46:54 -0700 (PDT) Date: Sat, 19 Apr 2025 19:46:54 -0700 (PDT) From: David Rientjes To: Zhenhua Huang cc: cl@linux.com, vbabka@suse.cz, roman.gushchin@linux.dev, harry.yoo@oracle.com, surenb@google.com, pasha.tatashin@soleen.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com Subject: Re: [PATCH] mm, slab: clean up slab->obj_exts always In-Reply-To: <20250418061459.3898802-1-quic_zhenhuah@quicinc.com> Message-ID: <1b517fe3-635c-6785-886b-6ad38f4de11a@google.com> References: <20250418061459.3898802-1-quic_zhenhuah@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 22F24A0003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: dq1btgis99roid3193p3x7w1udt3zzft X-HE-Tag: 1745117216-441590 X-HE-Meta: U2FsdGVkX1/7GbP2/V4xcoaPKADroofMNHlzzmRb/mswWUHvxz3NWvK27TeC3bcECxUDH5LTPHAnqP6HO3q9jvuaILYNkSzBxst14gfwn8ZvHoCGzxJTib62VrZOstd+IEETkgA2fISqUOYSmuZviU1UuUnuGqNva40Y4s/usGXrZ/uSad5zxZCx14/lUJVhHOt+3yZ7jdozuOLdtKkbRj8jiWFS8adRvkuBj2KfXskY/jaSuCd2uDBGLKgO9Nd+ye1Kt6Yjs9hxQaXDyJRT/kw3Oz8mPTKoo8vXvmEF2aYRarFoAhpc7soCn+R9V8Vts8wUhmnfwhfqzUvzfr4+VyEqp4uSayP8snB4PrbULFPK/nQ3GmL95Ci1er0avs8dlKLsf3DVKwFiXNYbOaCKXdsrYKhSrJGgPhQp2YZ5xdiPv4sc5adHTTAQOyes4A7GTJzsEhWHA8+T6PKLrPb4aOVu40Od0g6OOmxBnXfjNpJA54py6YJ7ylSGXTP9EUBytIXtgEv+pa2lHQFu3lYHYfHepDc+38U01UAj9K/lcBh7fO1Y0DmAgXMzm8VHyCwMhMqH4uHpiSBXHbT9q0YVdFxOcnfItOYQAAtAyr0lyL7XSSv4rgWXuJLuBM+4ctM9waOIzg0ZVQrH7by9WjcBXji3ZOzOmTX2LGOa3it3PntcsVwWiirTrbdlJWdYPc7Vs4mvu/xOUtxurhlnmV69hYTrKRkaM/8x9C73yLcIKh168yCtrMWuCNbtSPEzlYlbujnXfLRqjlJzbAjrNfYd8BF25gYTHEa3ZHyWThvPa75k5qR0202gLhK886Qm+vRjN37AhFP1Jrfydljf3WMA60CTVhLBxc4wzgs13t3ng3lQjlvC+rFNVCgLq4J/eFsDdlbygn47Mz9mTeoyqXFlu5aenYb6h8hNBk+g+ucw16kSaRJCQnlQ0Ug24ixCHaJAVU1z51fbfMLeuWvIS/w NNodUCCo jqLoVZ0BaUBC1H2vKsl1kob+scDmTY0e0AKcE95fwSI/TTpNlLxpR+qA8Qa/BK2qTEQHBFOevNC7Zn6eWWlOUArGWb+71h6TrrrcGdNbqMve7BQydfNzhehwnSvHv3tYguFdQca09SOD8G0pUCX5t7SX3Y6JsMz0EfJfyvfS3wC4jG5tUvkbDyaXq1OhGzO3fCtOuTrQ0Q6TI7XK7qLQUqg4XXAYrRIO/XBpaKRxqEdUQ4wyJmpLHRuiqdsNRWDQ+iU7KdctReaRAnbTBPl3YYTlaLWabbbmCGjfTx6iOJCPZBuW8FWjD7qGcS6yhvWVAuy31LUJCEvz2+klgHb2lhEe+2CCkH/++nM+O0XCabPWyty0dHFge2dFt0RQXQF0xaTTICvFDkqWGliCCD3579WwMP4o5qhp6aiKB05BTBdyCpshp4ZWe9gn82VUmnXsPjQGsL2ICNo6ilRS31AQNFNC1tQxiHCCidTksCniWqTtUqA8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 18 Apr 2025, Zhenhua Huang wrote: > When memory allocation profiling is disabled at runtime or due to an > error, shutdown_mem_profiling() is called: slab->obj_exts which > previously allocated remains. > It won't be cleared by unaccount_slab() because of > mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts > should always be cleaned up in unaccount_slab() to avoid following error: > > [...]BUG: Bad page state in process... > .. > [...]page dumped because: page still charged to cgroup > > Fixes: 21c690a349baa ("mm: introduce slabobj_ext to support slab object extensions") > Signed-off-by: Zhenhua Huang Acked-by: David Rientjes