From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 5DE346B0003 for ; Mon, 9 Apr 2018 14:59:48 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id t4-v6so7538027plo.9 for ; Mon, 09 Apr 2018 11:59:48 -0700 (PDT) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0058.outbound.protection.outlook.com. [104.47.40.58]) by mx.google.com with ESMTPS id k75si692452pfk.4.2018.04.09.11.59.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Apr 2018 11:59:47 -0700 (PDT) Subject: Re: [PATCH 00/11] [v5] Use global pages with PTI References: <20180406205501.24A1A4E7@viggo.jf.intel.com> From: Tom Lendacky Message-ID: <1b45ffd1-99bb-4ac1-fb65-0de3e42c1c0a@amd.com> Date: Mon, 9 Apr 2018 13:59:33 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, aarcange@redhat.com, luto@kernel.org, torvalds@linux-foundation.org, keescook@google.com, hughd@google.com, jgross@suse.com, x86@kernel.org, namit@vmware.com On 4/9/2018 1:17 PM, Dave Hansen wrote: > On 04/09/2018 11:04 AM, Tom Lendacky wrote: >> On 4/6/2018 3:55 PM, Dave Hansen wrote: >>> Changes from v4 >>> * Fix compile error reported by Tom Lendacky >> This built with CONFIG_RANDOMIZE_BASE=y, but failed to boot successfully. >> I think you're missing the initialization of __default_kernel_pte_mask in >> kaslr.c. > > This should be simple to fix (just add a -1 instead of 0), but let me > double-check and actually boot the fix. Yup, added an "= ~0" and everything is good. Thanks, Tom >