From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9691DC6379F for ; Tue, 21 Feb 2023 10:08:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A03E6B0071; Tue, 21 Feb 2023 05:08:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14F9B6B0072; Tue, 21 Feb 2023 05:08:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F31EB6B0073; Tue, 21 Feb 2023 05:08:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E05EE6B0071 for ; Tue, 21 Feb 2023 05:08:45 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B023FAB5C9 for ; Tue, 21 Feb 2023 10:08:45 +0000 (UTC) X-FDA: 80490875010.01.6211CD6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 6A0A8A0007 for ; Tue, 21 Feb 2023 10:08:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LXYefHCv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676974123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bQngTxIAa7bq5F++Qt1+J5qF8M9CFcFTXwihCMqwxiU=; b=6hkgdzeW8mjKtbQN45ZU1opwF/0r7n6TJoSyGcmar4i1Ak0NAOPafRWNCysM5jlvBswaNZ wK3y6U5Jj6JsrWW5yUC92EN/bYp4rs3F/1/NiW65OLYEJ32FicN9CKODXjkP/7elzw6vgV kZDU8PKwRYKaLr26DWJKs9ckeaRuRKQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LXYefHCv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676974123; a=rsa-sha256; cv=none; b=P6udVv/GmSzS0UCjkVM9hBJIxY8Xlb+qAh0urPrADo2v31mv+wNpczBIuwdfloH6zIcYm5 KbNJPiMHKB1lC462mE8ijsOxc+BFYFqeh6zXF1HFQG/vjG965M4kC6oZasZC+wKEBZKT9/ V4xl6lLf2RfyycxRACsBvJbIDiwYChY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676974122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bQngTxIAa7bq5F++Qt1+J5qF8M9CFcFTXwihCMqwxiU=; b=LXYefHCvgn3T8u3hrl1REa7QUrtDqiQN2MhHNZEmr5+d09NFedHeB4dxMuHYax3B2t15tA FjFGWRIrdGJfBoov4P8YzRtcuPtrHVdKuStcmh1ys/uWi6N0HRVdpJmdYdz/mfGPJNN+6x unOX0OwkZ8+AjeIQrx4r5VmTL1N0J+0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-642-z973mzQyPZumXpYyF_E-6g-1; Tue, 21 Feb 2023 05:08:41 -0500 X-MC-Unique: z973mzQyPZumXpYyF_E-6g-1 Received: by mail-wr1-f71.google.com with SMTP id z6-20020a5d4c86000000b002c54ce46094so809496wrs.17 for ; Tue, 21 Feb 2023 02:08:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bQngTxIAa7bq5F++Qt1+J5qF8M9CFcFTXwihCMqwxiU=; b=EJhw+r4FnEMqju3WxCkl6WuCmBHjK1azlu/+gPBMVCuEznMU+Zkn/VJzaFUZf42FKU w0KzkzbXFsMDE9xAeOAQhTznjQuxJqCG2E0yik+DTdx3FUVouba4Az75E8YSikGjx8Ua sWrgSv6hRri64gAl60FoOHUCCMNNoznkihgXMQVm2CcTZQSSefs8sEkFpCuqeGzRiiRA FUk8B6XLFi/WRmnhmRFeLtk++z1XxiqJ824F/y1C/D2D7sSaSQrAsz4q0mq9o6xH1jKU PbxD4k+psG/6K3HvgAO2Y9+Yt0XByhlYiw3XjRGZis4a7O68kHhWp8vaIdu2iNd5x741 UG3g== X-Gm-Message-State: AO0yUKUhAFvtFGUjUkbfGrvTcMhPXQhCrNYZIBMwOcMcRLR9VVDD2ml7 8GTgWmxRoihdYueygbTk1j716vfy8ZVp3Qem8LDQ2kAKx6P4qzq8XbzE7yPVTNZL/SKhOZ5L5uD KuaLVDXuKepc= X-Received: by 2002:adf:fbc8:0:b0:2c5:5ff8:93e5 with SMTP id d8-20020adffbc8000000b002c55ff893e5mr3060442wrs.44.1676974120108; Tue, 21 Feb 2023 02:08:40 -0800 (PST) X-Google-Smtp-Source: AK7set+yvZn9hxlDINT7LN34Sejar7rKnrWklRGP11gcX16WuW5/FXenaqtVUV1kKpqHEv+TURtHBg== X-Received: by 2002:adf:fbc8:0:b0:2c5:5ff8:93e5 with SMTP id d8-20020adffbc8000000b002c55ff893e5mr3060418wrs.44.1676974119708; Tue, 21 Feb 2023 02:08:39 -0800 (PST) Received: from ?IPV6:2003:cb:c707:4800:aecc:dadb:40a8:ce81? (p200300cbc7074800aeccdadb40a8ce81.dip0.t-ipconnect.de. [2003:cb:c707:4800:aecc:dadb:40a8:ce81]) by smtp.gmail.com with ESMTPSA id f21-20020a7bcc15000000b003dfdeb57027sm3086701wmh.38.2023.02.21.02.08.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 02:08:39 -0800 (PST) Message-ID: <1b3e8e88-ed5c-7302-553f-4ddb3400d466@redhat.com> Date: Tue, 21 Feb 2023 11:08:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Andrew Yang , SeongJae Park , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno Cc: wsd_upstream@mediatek.com, casper.lin@mediatek.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230221090313.15396-1-andrew.yang@mediatek.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] mm/damon/paddr: fix pin page problem In-Reply-To: <20230221090313.15396-1-andrew.yang@mediatek.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6A0A8A0007 X-Stat-Signature: ocqjdfhxojn5yxbqe38gh3x4kph1gjed X-HE-Tag: 1676974123-857667 X-HE-Meta: U2FsdGVkX1/qmePNKVJ7XWbNev0hBMs+Cn9nV26rviuTNdwUvvHa0FJ+5oSM5RkHs4DI9jJ4g2WCOWa8Bc17/trxSTjuw2FavLbcMKsoN3mviHTLyG2YhC5QgwKMwLw5lODnDNZv2Vm07bmJrRMjh9ulEOmt8YY3nDVMeK3cLtMEW+HC5mkRIl4lgLXWuX5GjSHSGI9iGeU51VFHnQHSLq+9rsrbLlc/YS7P0oSfwd6yEgxhvgHCLaR4czGTthpw/jSYVn8OSZXxTv0g1Wz4JQp0pGh+XQ1nL2bRafgp8nf+YSUCocxJut8nyv1/CRLOeQCVoBMp2vz5YwCwJ7t8a5AAIBX5dVcfvHZNvQnknQIZmXmWwGnKtHV5sDXkqvigH2/608OjZ807GxFcYil442gS2zlaXnI3XDxlfHvbrmODgC3ldIznNsU2SxF8D2L1qKN8qgCIrYswYlV5G0Mpo7UyoJP02tznlp7aj6RLCCJVuHoCLdZdVJQYyPBjUGAXB5/NRP6R3zk9dHQ366kPvju1ULa+eH0qXdERds5ahUpSaebTWrWgQGMKksU/6kg7LmC0WtVMSLqksmnMZ0HoTzJdX9hgXv4VG7P6eX8toFr5crcG8qvIlmUIOvcR7pf5SZj64gbi/g8SFrGfvPADjIn7hYrc6Fqoz6l68macLWq5VnjyU+OJE5S9kfYWsBIrAXCmCB256z1PFbHvYZAG6WJCKhnCgH9Oa5yiLS+Xu+SHu1G28ZxToPcQsK3TIFUDchmwOEcusy5MN51N898GM5rK6NVIu4G2K22HBUErKNTuIMuzg8ymzbghSxfItbzHQeP43TTgLNn01s7xrM2jZbdwO6PC2hh8uowVKffo+jKGUrh6UR4oOOsKx288ottb+XuH5ev/cO1QpLIdEVmpzA0V6m1Tcl5/cimEr7kJ1CeUdYLcMN2SY7B77VsPdvGEQrcycZIhNWImePR2jTq Bq0XS2bv A1YBjyyZywDljNk/Rxj4GtrMG9y85TsO+za41vgmqjRZGlU2DQXsmfweLB7OBcwv6wFRbpOWiZY6dDeT6S+kirYhn2kemJBP9jWa2aHsyKpVH8l+/ePmeKmMuQeyPmXSPJMG5NbMuOEJ2+mCiejeLaCuomggdFS4EbX5DsWCnjWHgqH0alAYhtka56TyRp0skzqm8bClOuPDbKozYOhcyqfWdY3UGUQALfVmKhFuJ4/m8rNV5SCuIngkd97WvN3LD9mG4b4BuTRhp3/nakmwz0Y4XsAG6684T1ltFdIIRpwRd3HadwixYBg2ur51FhEJw53uFJpZOLoIffbaSIogPdqoHkS34RajDGBByeiXYj0Y3us1cI9qE13ysSZnxRx8t7YJdzvkUscbt0TDnETDruMKvWfjG7xmNh9dHowvHZeITDMqFqiI8OiRHNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.02.23 10:03, Andrew Yang wrote: > From: "andrew.yang" Nit: I'd suggest a different subject "mm/damon/paddr: fix missing put_page()" Fixes: ? Cc: stable ? I think a patch from Willy is queued that converts this code into folios. > > damon_get_page() would always increase page _refcount and > isolate_lru_page() would increase page _refcount if the page's lru > flag is set. > > If a unevictable page isolated successfully, there will be two more > _refcount. The one from isolate_lru_page() will be decreased in > putback_lru_page(), but the other one from damon_get_page() will be > left behind. This causes a pin page. > > Whatever the case, the _refcount from damon_get_page() should be > decreased. > > Signed-off-by: andrew.yang > --- > mm/damon/paddr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index e1a4315c4be6..56d8abd08fb1 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -223,8 +223,8 @@ static unsigned long damon_pa_pageout(struct damon_region *r) > putback_lru_page(page); > } else { > list_add(&page->lru, &page_list); > - put_page(page); > } > + put_page(page); > } > applied = reclaim_pages(&page_list); > cond_resched(); -- Thanks, David / dhildenb