From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCB0C433DB for ; Tue, 12 Jan 2021 11:00:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 89DFC2310B for ; Tue, 12 Jan 2021 11:00:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89DFC2310B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E12D68D0092; Tue, 12 Jan 2021 06:00:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC1C18D0090; Tue, 12 Jan 2021 06:00:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C633A8D0092; Tue, 12 Jan 2021 06:00:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id B0F778D0090 for ; Tue, 12 Jan 2021 06:00:13 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5814D824805A for ; Tue, 12 Jan 2021 11:00:13 +0000 (UTC) X-FDA: 77696828706.25.base52_5e0fa6d27514 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id EE91C1804E3AD for ; Tue, 12 Jan 2021 11:00:12 +0000 (UTC) X-HE-Tag: base52_5e0fa6d27514 X-Filterd-Recvd-Size: 3675 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 11:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610449211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TwmTniM+7kVYyugXIEZJDHDJkrnveOX+TbTjK+S1Icw=; b=fvsqB41Ts3y8JTra6DfxQPun/0WPpFKlcM76B1jGm86sJ86phMcij5LlXmpaUIqUzjEmmT +U8aebWU+I9CMfPVDf7slNdQhyPhrQFQyGEtmBSf2qRo5z9Q+cvAkAqJIew4U0KkFe9Lqk C+CI8JmnbDYy/jGFeG6Ysu8jaNnF0So= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-1IS5DurONPK7Lnj9-DmAZA-1; Tue, 12 Jan 2021 06:00:07 -0500 X-MC-Unique: 1IS5DurONPK7Lnj9-DmAZA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4708118C89E0; Tue, 12 Jan 2021 11:00:06 +0000 (UTC) Received: from [10.36.115.140] (ovpn-115-140.ams2.redhat.com [10.36.115.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id D589F5D9CD; Tue, 12 Jan 2021 11:00:03 +0000 (UTC) Subject: Re: [PATCH v3 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one To: Muchun Song , mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi References: <20210110124017.86750-1-songmuchun@bytedance.com> <20210110124017.86750-2-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <1b39d654-0b8c-de3a-55d1-6ab8c2b2e0ba@redhat.com> Date: Tue, 12 Jan 2021 12:00:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210110124017.86750-2-songmuchun@bytedance.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.01.21 13:40, Muchun Song wrote: > If the refcount is one when it is migrated, it means that the page > was freed from under us. So we are done and do not need to migrate. > > This optimization is consistent with the regular pages, just like > unmap_and_move() does. > > Signed-off-by: Muchun Song > Reviewed-by: Mike Kravetz > Acked-by: Yang Shi > --- > mm/migrate.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 4385f2fb5d18..a6631c4eb6a6 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1279,6 +1279,12 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > return -ENOSYS; > } > > + if (page_count(hpage) == 1) { > + /* page was freed from under us. So we are done. */ > + putback_active_hugepage(hpage); > + return MIGRATEPAGE_SUCCESS; > + } > + > new_hpage = get_new_page(hpage, private); > if (!new_hpage) > return -ENOMEM; > Question: What if called via alloc_contig_range() where we even want to "migrate" free pages, meaning, relocate it? -- Thanks, David / dhildenb