From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987A4C3DA4A for ; Mon, 19 Aug 2024 10:05:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2936D6B0088; Mon, 19 Aug 2024 06:05:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 243DC6B0089; Mon, 19 Aug 2024 06:05:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10CEF6B008A; Mon, 19 Aug 2024 06:05:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E4C346B0088 for ; Mon, 19 Aug 2024 06:05:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A040E1A1162 for ; Mon, 19 Aug 2024 10:05:33 +0000 (UTC) X-FDA: 82468562946.25.8D63DDE Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf12.hostedemail.com (Postfix) with ESMTP id 881E040005 for ; Mon, 19 Aug 2024 10:05:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=QFQNtX6z; spf=pass (imf12.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724061870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=clWg1cFDvmBXHk5ECX33rfzkJ2REgKM2jV0tZFYmIeQ=; b=GMpefLFFLKkB5dB/AllYn/4G0rf+1w3u0uk9Xk834njNcw0Tgv/cc/EL79yvfJOr7jrj/b lx5zM/VkbPOgXW22FTfQoHo/68tA/Po+xf2DyXo96oXEr1L2m0Zz5tUHJkOcgeSva9h+Oy OjMW0ysI9Te3kb8Knem63V1B3j4Yod4= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=QFQNtX6z; spf=pass (imf12.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724061870; a=rsa-sha256; cv=pass; b=skdzfvn5xF3BK7e64A1wyk297dk7pxKuhTuXLEaEeJe5gzVwx2nqG6CV9mcgPEIa4faMgd mrFQZinJp31Iild0hfsOEz64+ibgsHoUfTUzX0jqdr2IYvkq9tWcr8oFNNa4/nf/dh+6T5 62tmb+OWzTF5uZ06iGJaXLYFKMtZfv4= ARC-Seal: i=1; a=rsa-sha256; t=1724061921; cv=none; d=zohomail.com; s=zohoarc; b=MXOhc7NLEDPDr/iPpz6LDk+OKmaWGNi608mPfY3+G8aMooSY4q1YtJlBkTErvALqkiJB36Evfe3+xm5KMlBjUUTuMEaHw+dfpepIghc9za9DvnI0Bz/4DR0dTATzX5UTsxCgz2VFiQLOJnehAK/RryheLGuF5psEDjud0LbaY3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1724061921; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=clWg1cFDvmBXHk5ECX33rfzkJ2REgKM2jV0tZFYmIeQ=; b=PUlR2JI/qzO2k81FjM2m5k5QxwrKZ9omUh/3J+0lC+Mwx+1OiPktwnoi1g3JtYdyFWX9oOnQD8nsBzUJAbXP1ISIWPuDsikRTqIadvYWwWh6t5DXjEmxY7eZsymgSCKZh3NSJWTK5fBD3zLLV0hqpKLAguhZThbpmBtLJjRu0Dk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1724061921; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=clWg1cFDvmBXHk5ECX33rfzkJ2REgKM2jV0tZFYmIeQ=; b=QFQNtX6zd8MeGg+ZTXgH2wzzY9xNeJKd5YubWcapTV7m5lk9rX13WKKixaCfjLPY xVrvQjc0GOdi0gTl0msRIJwR5ePxQKYjV/6x1rlG+eya7C4oUl3s2ItFgMYLiZXHrkI eLBRGE4NmrGShGj6+dhZv88676r6cOD0rW38Oasw= Received: by mx.zohomail.com with SMTPS id 1724061920204590.2573152825611; Mon, 19 Aug 2024 03:05:20 -0700 (PDT) Message-ID: <1b36ba43-60a4-441c-981f-9b62f366aa95@collabora.com> Date: Mon, 19 Aug 2024 15:05:07 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, Andrew Morton , Shuah Khan , Kees Cook , "Liam R. Howlett" , kernel@collabora.com, stable@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: mm: Fix build errors on armhf To: Jeff Xu References: <20240809082511.497266-1-usama.anjum@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Stat-Signature: 4f8j8kubo6gpndryxzcoukezk7tom3dx X-Rspam-User: X-Rspamd-Queue-Id: 881E040005 X-Rspamd-Server: rspam02 X-HE-Tag: 1724061931-729452 X-HE-Meta: U2FsdGVkX1+eVVyASl8NIFHf5AfplzHQ2EgnNYKYWxEHLclU9u5sMQglQUA8McgkPpVoy514OQmDRI3k7jMeLTu41m17rpBxE5MpwmL///NlaWm9dIq3n6RljKjH9J4B2SDwKQ7AwSkZx667RACGvTeiYL9UYHv51H9Ny0E8a1ZYZ3pqFOO4vjgCjyPsbMQjTY5jUnjFjFG9FLoNWECA3oGDvT63ViC+YlMh6L61syims2Wi4gakxqt5KHR0ruw9G0PYSNVXhLQMuUuZpR6Ck/qfsUPVASNsW54LEOsCdpSyu67uQiol7dQBxnBIaKYN6v5ypeqFOcTITM4t/7h+UsoC0ZLSBApT38asSKqi2jrB1MtCYBoFOyBHfSD3teIa6jArkVhFgsKZUkdDxHEoNXWCYSibE1svhQnAgr/V1v3bXUURn++Kb9iTpkdL/xkTuQmss+PmsIs6CWPSCUN61du+h/mfhO/wSevPozcouJCR/p2OsDJHIiB3oiuWuh8WE0clazMZ3R/2+m3YWXucqocXQpd8fIsOKI8ozIvrNzml2lQq730pFGJSryJz4CaO/RKZ2VqqTFgU07xCxxf9NnF8tLaSSLcaVY82Xpd+cfSdOuNbTaJrGFYf4s1CP6cqoXZp0xbjCB4u/qTDF0XM2T1HvHDEll0vvlSuqEbHTgiueG3VBqDfRsaAhxcE8L5tK/Epoh2fIl54WrATD134+Lf+b1Qg/I0060Yw0abiw+DXBT7yKxTbJPfC75JVz3q3G5yB0XzaV0QQlrUdlUsbAM1x0oM8o+LF+H6IK2C09NSLAApzSiZXknpuuQLfDk3qbRJimCwW2epBMWUD6ws5Hu2nVAD0wN3ZrZIQuBKh51V2xvx4FL3jajZLd/7K/1LS1boUOuiasNSRTf8jWsfeaVxwVjD3nzkV4ACXqQ8B6FpH9mDJnyrgmOAi+Ox52eGLf8v0h7+7w2cSbN13k7l fB3CgQDt p1Jk2ceyvNCKcBb0RcbjyfTe/UfNobaaZglhp3sF4QE6O8e/sU4Jkta6YQAYQyzPnn0Xpk4gtmeuFUB/Z5ysItoq5ixLjJug7CphrqlhJeY94zEJu7A6IuBLqzHNUUxwt9yV0xcY1EhUl4rXtip4MoFROQf2b1iiZNMqlnSU6M3O9bJthZbCFKWxMbffx3jn8pOAxlviD0rQEAZ+VSGiwlhGQHnbItrXuw7vnLtLjvI3xR8qNoJwxfuyvqZ3uHxutgwnrzcnis8i73S+dYL/ycTYzxOLr6JMZqqo9CZhZqkHPMfjq2mQnoDyaM1oah6U0/ACW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/14/24 3:29 AM, Jeff Xu wrote: > Hi Muhammad > > On Fri, Aug 9, 2024 at 1:25 AM Muhammad Usama Anjum > wrote: >> >> The __NR_mmap isn't found on armhf. The mmap() is commonly available >> system call and its wrapper is presnet on all architectures. So it >> should be used directly. It solves problem for armhf and doesn't create >> problem for architectures as well. Remove sys_mmap() functions as they >> aren't doing anything else other than calling mmap(). There is no need >> to set errno = 0 manually as glibc always resets it. >> > The mseal_test should't have dependency on libc, and mmap() is > implemented by glibc, right ? > > I just fixed a bug to switch mremap() to sys_mremap to address an > issue that different glibc version's behavior is slightly different > for mremap(). > > What is the reason that __NR_mmap not available in armhf ? (maybe it > is another name ?) there must be a way to call syscall directly on > armhf, can we use that instead ? It seems __NR_mmap syscall is deprecated for arm. Found this comment in arch/arm/include/asm/unistd.h: /* * The following syscalls are obsolete and no longer available for EABI: * __NR_time * __NR_umount * __NR_stime * __NR_alarm * __NR_utime * __NR_getrlimit * __NR_select * __NR_readdir * __NR_mmap * __NR_socketcall * __NR_syscall * __NR_ipc */ The glibc mmap() calls mmap2() these days by adjusting the parameters internally. From man mmap: C library/kernel differences: This page describes the interface provided by the glibc mmap() wrapper function. Originally, this function invoked a system call of the same name. Since Linux 2.4, that system call has been superseded by mmap2(2), and nowadays the glibc mmap() wrapper function invokes mmap2(2) with a suitably adjusted value for offset. I'm not sure if behaviour of glibc mmap() and syscall mmap2() would be same, but we should use glibc at most places which accounts for different architectures correctly. Maybe the differences were only present in case of mremap(). -- BR, Muhammad Usama Anjum