From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8227C001DD for ; Thu, 13 Jul 2023 14:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22332900032; Thu, 13 Jul 2023 10:45:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D39B90001C; Thu, 13 Jul 2023 10:45:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09BD1900032; Thu, 13 Jul 2023 10:45:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EF0C590001C for ; Thu, 13 Jul 2023 10:45:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2E2AA029C for ; Thu, 13 Jul 2023 14:45:43 +0000 (UTC) X-FDA: 81006862566.11.865FB73 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id A69971C000D for ; Thu, 13 Jul 2023 14:45:41 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fb+lbr3r; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689259541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IMP7cj7qfPl/Rl+jEMqVrTJOFquw2Vmdts/6xtQeKw0=; b=w4731elfes1hEltSISEVHUmKARsogFLei1SMhCuDOfEYK4hv8t1n1pthOZvm4MkVcyCZj1 ui56/PSU9KSoF0taYkVwYr5VN4wpUwZLukkYQN4AUdCv7b4fxdzcJrWhx9ccbifQ73yg5h zy8ScTjJdC7Fqpm6wBHYe8a9S5EIogM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fb+lbr3r; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689259541; a=rsa-sha256; cv=none; b=vyIpSR+2ZLVEDwKFH19X7bSlcxiFWHe+5VFM+bQ42rco9mxY97sS7DggXDUhH2dIV0IyGJ uPQERi22beo+Ee5fut1cDDk4z7byIdi5WQOv+r4eutnv66WV7kIWhdb/ExjbhXk9WTDhvf V+WTcO2KbGEKkD+qe9sdAkMca6B5vRA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B7C7661545; Thu, 13 Jul 2023 14:45:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C950CC433C8; Thu, 13 Jul 2023 14:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689259540; bh=9x2+cvi+3bTenkv1neM15nfVBtvEgjl998KUiR4iaaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fb+lbr3rXs6mQK6vDdOoMi9PbVJLhx7gakT+qkYxDpktn9DlvXCe4dUTbSXjrK/3o ITsy53hn3nBDsHjuWRvIHyLxHDdMDEnGn65XqdzzaOsDi6slhDIBjK8T++wmcSGQPK yAqthuJHPgmk8zmOPBf/Vck1vfkSUD5IPF+RQxE3TXnW5FKwIZNKpagx35sU9ndB5c FVoYKzhltVJBFARZ8rXRKxjyx0QsDNl6xBsXdcZtoWUsljFIrIhl7hAwT6dHLo4jPx cPZUpejuonWkiSOhXt7qpxgW2q+Qv19Xhl/mSWT0hCf9MlHDgpUgPfON/W8pe1zwQI /9mLX7/Ab2TKA== Date: Thu, 13 Jul 2023 15:45:34 +0100 From: Mark Brown To: Ryan Roberts Cc: Andrew Morton , Shuah Khan , =?iso-8859-1?B?Suly9G1l?= Glisse , David Hildenbrand , John Hubbard , Florent Revest , "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/9] selftests: Line buffer test program's stdout Message-ID: <1b33e341-e86d-4647-bcbe-38d2667cb891@sirena.org.uk> References: <20230713135440.3651409-1-ryan.roberts@arm.com> <20230713135440.3651409-2-ryan.roberts@arm.com> <8a8d077c-55bd-4710-9dfd-1cbb1a9170a8@sirena.org.uk> <1e560ea5-3eb2-40a8-33aa-514eb026de3a@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="opkr7b0grNXS+tLU" Content-Disposition: inline In-Reply-To: <1e560ea5-3eb2-40a8-33aa-514eb026de3a@arm.com> X-Cookie: MOUNT TAPE U1439 ON B3, NO RING X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A69971C000D X-Stat-Signature: a63f6my14p34dy1e6hkukgxpk95w3qdq X-Rspam-User: X-HE-Tag: 1689259541-669790 X-HE-Meta: U2FsdGVkX1+S+pBtLpAsbZw3CwCRqk1fSNdU2B/PMNTmqe2Ne8YBymFZq1guTchuCTBLRRp0bpnZRzkNbyfIINnWXh/qXb6MHheE85EzLNge4YRNQE5vGV9kmxmm7HID05fO8xPgDYmkM6Od66AiEdWXsBmMImdFp2RgwextU/dT8gzcr5R73suzaxExGk7xk28WmBM6blZ2VaS7w/XdsQS9CC42HysqbdkvjMT0AD4vlgvHTnSgVbIcNgDwAUW9QCV7530TseXc41e/vEEsvEQ5u0yivcUeLApJVgTgcCoHsZMKSWNFjAQ+ttHMDnobFz5pDshxlDNmA7ex0/hr9L1AmE+tZwvdTGbC8NMVIxTywIRQo+PzqU8JfkfAboqMev1B2NVx33X4X2AZ2U87C9aqZ6Kt4t7AIWfQf5T2TXu9OezhRgzeZQFpB5ZEJBuINElcQnyOh7HPS9itZAkhvhXBmOu1jdduiB8kP2rpCDwgq4ehRLYligs6cowotF1jO8uGdPYL+kPhTLKcMBXrr3tHvh5JgJ7inR6+wmAOZ+dTj0JbPtb/9Vc8GtxVinJrFT3Oc8ZP5BgTcVS0nqlKes18YzyK2ORXtvmQ/PRvsjx9I+Gbr4C4fkYBL0VNqQOQMkibCZ18iavY5bAKl9vG5udGBrxJ/lWuuP0aKVk5lWJLNhCIHoX4RU7vJoDBy6r2AVTa62SDeEA0QSxg2Cn2xVmojbi70ZZH6Uamd4UPL1qhGRZowcbwkHqGB4dngIwc6DQjzzQQxyIFoxIReY7QknXVd4ivsitbWtBbf8yqHzg85cLZ7fdBciavsWUT8wfTu5f66XNMMHpk9YCnK1ezYnw7OYlpmAt4uEXysbNUfWn8awRA9YoX/JppDavDq9qdUPArr6wNSrQVCRGw9S255NrSUmwi690Jwe4siZFij+iVgMSA3RDRjZ8Apl+VdMhV2uB8eCWWD/YbpkMXoWu go5NghcH lUI+hAbTD7d7HKBMXYj2IFSc4mBJNAC8jAvElbKPGqUVgr6MTPhkJlaQhm8nY72XWnjWJMmSVjHoCq1qL/CYw3qF3rih2L4f4FCeGe8UNN2yOCizRFs4xwO1ol96bevmvg4B2mC6AfcdPfqG8CGa06Zn3x+gN4Y7I65JRMdDEqXkpWBde4c/yw5AU8fpGk4yZo8En3kkl/PknBNkiF6Mr1kEkMwh4guPG26Fv/X9tv+eNUHbeSsSe9lbAu57fsIaIsjNo0qQ+o6Y3tROMd2C1CjM/jV0SyfhLpMSg1M6Lh0pDLQ+cMZVBaZatcOlHtL1cCT19jZNhdtfFr9Blb2+YTX6UML6M3DCWedgo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --opkr7b0grNXS+tLU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 13, 2023 at 03:32:19PM +0100, Ryan Roberts wrote: > On 13/07/2023 15:16, Mark Brown wrote: > > so that if setbuf > > isn't installed on the target system or the tests are run standalone we > > don't run into issues there. Even if the test isn't corrupting data > > having things unbuffered is going to be good for making sure we don't > > drop any output if the test dies. > Note that currently I've set stdbuf to encourage line buffering rather than no > buffering. Are you saying no buffering is preferred? I took the view that line > buffering is a good middle ground, and and aligns with what people see when > developing and running the program manually in the terminal. TBH with the way KTAP is specified line buffered and unbuffered are probably equivalent, I was just defaulting to unbuffered since it's the more conservative (if less performant for lots of I/O) option. --opkr7b0grNXS+tLU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSwDg0ACgkQJNaLcl1U h9BjVQf/TDjeTXyfVia9mY7E3G3glN1Oxz4ObsUpvF6whyd5D7AjlDAjrB41x6xs S2dLRBFeHLXa2DABIRYUs0oNpoaI7QnBdIurIHO1JdsDWhiPhgIthBDOoYnOzKy0 QB4aJOcg/MfYbbdcqxL9CpiZU0dvFJA2Ge4sEC3gBJxLzj4nW9y7eSI+Aro9RYxD WZsPeOqGrxlzRplEf6ENdoiPxFvfx/wog2pc+dpgfXxYo6JMeJreShHPbHvIguGA 4eeLtN5whg3nZ6R2gAFBkqmbCrBDf+K713xaO1a3WPWVyr6Guqbee/uTwA00CHkV 7XtoMJ0hi9IE7KeQ8BRYKcym5LjPpw== =yLQw -----END PGP SIGNATURE----- --opkr7b0grNXS+tLU--