From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81C0EB64DD for ; Mon, 31 Jul 2023 03:13:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 289A2280014; Sun, 30 Jul 2023 23:13:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21287280012; Sun, 30 Jul 2023 23:13:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD7E280014; Sun, 30 Jul 2023 23:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ED7D5280012 for ; Sun, 30 Jul 2023 23:13:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B70EC120A01 for ; Mon, 31 Jul 2023 03:13:03 +0000 (UTC) X-FDA: 81070435446.25.96FAD82 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf15.hostedemail.com (Postfix) with ESMTP id 5FE1CA0004 for ; Mon, 31 Jul 2023 03:12:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690773181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bai6/CmUJoCp4N4wsJxtVUuPpf4IyEqmZPoSrGpuo/g=; b=GRrREWwFoaOaQguVVcrNRJe4Z7cjRolRlI/5UDWNZ54lwx8hZwolnP0HGO1ZO+a3VxnDek 4rHu/8c6K0Bm7FC/x8kRu5vmgDuGSUgfESLpp1pG3dXrTk0dulB8yOGN7lRDQTJ9q248Wt WKx3Ap2Xvqsjmg9GaZJw4il0Ww8/JKg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690773181; a=rsa-sha256; cv=none; b=mzF41OsJmVl7zwnME94DstOoi2pIC8qeDNE8SG6o9QVFPYkvssBVu0xF5dHP/xElLHcShj OJmAaAuUBJgR/hkoH7Am9LNN8bu62Bq1OL9rjiB+LPULV8+Tc2BQf2keDLGTOJJG68QdIq xRPFxXUEysBM2QLNbxtFLCME9d1salw= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VoXPAnl_1690773174; Received: from 30.97.48.66(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VoXPAnl_1690773174) by smtp.aliyun-inc.com; Mon, 31 Jul 2023 11:12:54 +0800 Message-ID: <1b30056e-0208-841e-9174-4a977dbba309@linux.alibaba.com> Date: Mon, 31 Jul 2023 11:13:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] mm/compaction: correct comment of candidate pfn in fast_isolate_freepages To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230721150957.2058634-1-shikemeng@huawei.com> <20230721150957.2058634-2-shikemeng@huawei.com> From: Baolin Wang In-Reply-To: <20230721150957.2058634-2-shikemeng@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5FE1CA0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wrty8dq8zrio48ogn3gqc3obwr5rasg3 X-HE-Tag: 1690773178-620367 X-HE-Meta: U2FsdGVkX18NkSHyHBM66rgsHf3pnOdW1YPPR9wRELbMvzd5JkiodUyH7LQV7ZojYuTx7LS0r1BMluiN8G0iGIJDfiMr/FG6ouWlemxNXG3G8jxqkJz+N4PvWGdQ9z93K/ELgdRma63tlUOe+A1pokieGRDoJlZDSDBrfOUEtUx7pgY3ZnNEAYZM/sxbSg7kp5VnXXWWlwqr0xmPZzcnFwl45w+6vesj0rjpXsycbIfURMWDe+hic650XwcT1Ph9C4gwuMW5Lsfvi4DKi+bq0mtIz8sT2raKkIcNmu8snvcNrLEwo2+6meUciupoBTTckPvAynww1aoP1uiifdEAkZ1DNdZ6Hi0H1C882bnTFHmiJGz0NpPgKbJzz24wntTLKxbS6A5Spzn/goZT+S8ZDKE2O0rRF+vLraBpyvdgG0CPE/CZjRAsidoSvzKhwv5dDAlRpoR4fK73nCxhjG6eBOyEZrsKqXbf6o6bZmcHwIdiF7VTsTTeS3kF4W0h6V+9F3DquPi+JUoDsHmYqJfX9uIKcwig+OBbmPU9nuCLZsEEv0esLylqP9EfptPV3ssdB11/9ZkFquSoR25LczhjCN4kYT9jXrPQjZBnYWYxVXIslFl7qsEVfgq+3bEsE2tUBfiZJZ7EPbcJWwvVjvegkUhCT2K8LJgGyKGlh9rnzc9mEcCuNUSV/rIhgBI3SfNEiwRims+MPQHcgQ/b1Au42dWA0x+DpxFH5Hr8bM7LMvBcQFFFXXFzTTmtONochKoabgElyUcFVOwsGs9JMVx1jhJ2GmN77mQp2JxUtXO0QwxQ5DudTbsTSPgEkvFjEw1vGdvq4/xt9lzv7c7DKV2LOOOvgfld0kVJvnSuY9V6EGraPflKuf9Z6iVc8WD7MV4Qnvm3nQZLDP+FJhOOVl20AlkhiGdWnfK/xRZfDEXbeTd1K5VKQ4NVzKmw2FUzVY/nfHGx89mur/j8sLtgzYt c6LU/Qn9 7PM/GTsUTTbN2Vrltq/aZwDcviXB18k5BSJjNzRbjjnwJWkruKIsGUDhyIL5hLjHddOfV7pMTHhycrZ8zCJka9C31/m5tq//k3yqNIiZKRV8SYNcdci6MPtabxU4ntBNTGb1ZxoH+Em3jd4+moe0fda4nV6KAdbhv9xEZr7HGAZf3BX8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/21/2023 11:09 PM, Kemeng Shi wrote: > If no preferred one was not found, we will use candidate page with maximum > pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum > candidate" in comment. > > Signed-off-by: Kemeng Shi Yes, the 'minimum' can be confused. At least to me, it looks good. Reviewed-by: Baolin Wang > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index eb1d3d9a422c..c0d8d08fc163 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc) > break; > } > > - /* Use a minimum pfn if a preferred one was not found */ > + /* Use a maximum candidate pfn if a preferred one was not found */ > if (!page && high_pfn) { > page = pfn_to_page(high_pfn); >