* Re: [PATCH] mm/mprotect: Fix do_mprotect_pkey() limit check
[not found] <20230606182912.586576-1-Liam.Howlett@oracle.com>
@ 2023-06-07 7:43 ` David Hildenbrand
2023-06-07 7:46 ` Vlastimil Babka
1 sibling, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2023-06-07 7:43 UTC (permalink / raw)
To: Liam R. Howlett, Andrew Morton
Cc: linux-mm, linux-kernel, Lorenzo Stoakes, Vlastimil Babka,
Jeff Xu, stable
On 06.06.23 20:29, Liam R. Howlett wrote:
> The return of do_mprotect_pkey() can still be incorrectly returned as
> success if there is a gap that spans to or beyond the end address passed
> in. Update the check to ensure that the end address has indeed been
> seen.
>
> Link: https://lore.kernel.org/all/CABi2SkXjN+5iFoBhxk71t3cmunTk-s=rB4T7qo0UQRh17s49PQ@mail.gmail.com/
> Fixes: 82f951340f25 ("mm/mprotect: fix do_mprotect_pkey() return on error")
> Reported-by: Jeff Xu <jeffxu@chromium.org>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> mm/mprotect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 92d3d3ca390a..c59e7561698c 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -867,7 +867,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len,
> }
> tlb_finish_mmu(&tlb);
>
> - if (!error && vma_iter_end(&vmi) < end)
> + if (!error && tmp < end)
> error = -ENOMEM;
>
> out:
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm/mprotect: Fix do_mprotect_pkey() limit check
[not found] <20230606182912.586576-1-Liam.Howlett@oracle.com>
2023-06-07 7:43 ` [PATCH] mm/mprotect: Fix do_mprotect_pkey() limit check David Hildenbrand
@ 2023-06-07 7:46 ` Vlastimil Babka
1 sibling, 0 replies; 2+ messages in thread
From: Vlastimil Babka @ 2023-06-07 7:46 UTC (permalink / raw)
To: Liam R. Howlett, Andrew Morton
Cc: linux-mm, linux-kernel, Lorenzo Stoakes, Jeff Xu, stable
On 6/6/23 20:29, Liam R. Howlett wrote:
> The return of do_mprotect_pkey() can still be incorrectly returned as
> success if there is a gap that spans to or beyond the end address passed
> in. Update the check to ensure that the end address has indeed been
> seen.
>
> Link: https://lore.kernel.org/all/CABi2SkXjN+5iFoBhxk71t3cmunTk-s=rB4T7qo0UQRh17s49PQ@mail.gmail.com/
> Fixes: 82f951340f25 ("mm/mprotect: fix do_mprotect_pkey() return on error")
> Reported-by: Jeff Xu <jeffxu@chromium.org>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/mprotect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 92d3d3ca390a..c59e7561698c 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -867,7 +867,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len,
> }
> tlb_finish_mmu(&tlb);
>
> - if (!error && vma_iter_end(&vmi) < end)
> + if (!error && tmp < end)
> error = -ENOMEM;
>
> out:
^ permalink raw reply [flat|nested] 2+ messages in thread