From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22FDC7EE23 for ; Wed, 7 Jun 2023 07:43:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 107746B0072; Wed, 7 Jun 2023 03:43:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B7B28E0003; Wed, 7 Jun 2023 03:43:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E99F18E0002; Wed, 7 Jun 2023 03:43:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D6A636B0072 for ; Wed, 7 Jun 2023 03:43:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A94021A0157 for ; Wed, 7 Jun 2023 07:43:23 +0000 (UTC) X-FDA: 80875161486.09.3D7536B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 7E81D1C0002 for ; Wed, 7 Jun 2023 07:43:21 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="hgYhB/nM"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686123801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxZp9KdUKEgw6XPITnZ8rbdpOnJBleKSijZBJrFdz/4=; b=LRteiTcDEzi3T5KyGEJEmFeqoBpiqv5xrSSYgeL9jGtsDWIIkCp0Q41CM9esiToyhxa9k5 xGhC1VoUmZvXS8uo93PRtU/gUEPZmhNYdUu1Z7Tqdz0Oq2p1XPXMZPvzhpCF1vDr83uEGl ZIJNlO7ks/frLHa42napWoZNSoIyC68= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686123801; a=rsa-sha256; cv=none; b=GjXxaZSjxhAurmp1/LE7gD2kmFyAGDqQlJJhsVGV9VEc3tb+NEs2E/Eh1hV/Sx7ZFMLINM 1wR3i66mQONSGUksOANtFIkY6/vq7axRQrmtBUzfBLm+q9sZdHixTQ140upAiIT0fpMOv2 9qK23uQ5G3cg/bg66QlJhPs6mEF0D4w= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="hgYhB/nM"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686123800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vxZp9KdUKEgw6XPITnZ8rbdpOnJBleKSijZBJrFdz/4=; b=hgYhB/nMUegbYZ16a++kBXpAPmYJyb8XC1tH4u1L2B30tYm3klarJlwbdJa0sWDrif1lLb Lrl7WpteiV3lYkM8kKOKov3uaANXvfu/kuXAKpzPnHnBMGT+6AqEbyRZNJLK373rm3EcHM 5w/W3VAAIDtR2gQutfByND4hzLpsQbs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-nEF_10fdNQyNax0rVDgYXA-1; Wed, 07 Jun 2023 03:43:17 -0400 X-MC-Unique: nEF_10fdNQyNax0rVDgYXA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f7eb415010so1624905e9.0 for ; Wed, 07 Jun 2023 00:43:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686123796; x=1688715796; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vxZp9KdUKEgw6XPITnZ8rbdpOnJBleKSijZBJrFdz/4=; b=dQS1DP3zf2vmMFppHBxHqBS9zA33tqdYFIlcr/ZrXIo69XVsRwtXk1DVw8AXHpM74r Dh6qi47TlrLlUp9/t/h2tFZztDBTgfFpIYcprjvgT2YJVbuyEsqP99eFkS3gRD2C8fMj k5s5jylVtpOSYSVGdSCTLIdNBnYU18Yzau2SoncmIKknyNQOBx8XY3FZhTks4bNNrCq1 ED7oXrEtH9bIUp/nSEGE+mqjtu99pG43VS8jt8GMDMFiE82ltqKMrvyQVMYLqTl4e29q bEbuDEVRNyZ8UoJ+YonaWJhTJ12XXMIdle625u5xRJK6R+Xs+bcIWY5zeBrDD7fhkX+K 8fmQ== X-Gm-Message-State: AC+VfDzB7CBg+NDObWsXkOsK3Opk3eJoB5N7w5a6fBXfXYB1iDucICtD LqdcMTt/7CbnsgIWPWdS4LRtWsfx2KATDIiKkqctRVzRx8SNxUnSZ0SJnXx9LpeFJsKyoSmpYVD oLShR0K/ssjU= X-Received: by 2002:a05:600c:354f:b0:3f7:ec38:7b02 with SMTP id i15-20020a05600c354f00b003f7ec387b02mr2772832wmq.3.1686123796419; Wed, 07 Jun 2023 00:43:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Z/oafmbbbdymBvFhysi9pZ7rB9/GzpxAwi7QXPZLn1SSiVpHCJ+hrMbTgXgCgV2HZ5oGlPA== X-Received: by 2002:a05:600c:354f:b0:3f7:ec38:7b02 with SMTP id i15-20020a05600c354f00b003f7ec387b02mr2772818wmq.3.1686123796122; Wed, 07 Jun 2023 00:43:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9c00:8d26:3031:d131:455c? (p200300cbc70e9c008d263031d131455c.dip0.t-ipconnect.de. [2003:cb:c70e:9c00:8d26:3031:d131:455c]) by smtp.gmail.com with ESMTPSA id o16-20020a05600c379000b003f6038faa19sm1178915wmr.19.2023.06.07.00.43.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 00:43:15 -0700 (PDT) Message-ID: <1b27077f-d4e5-321c-f15e-b1309763806c@redhat.com> Date: Wed, 7 Jun 2023 09:43:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] mm/mprotect: Fix do_mprotect_pkey() limit check To: "Liam R. Howlett" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Vlastimil Babka , Jeff Xu , stable@vger.kernel.org References: <20230606182912.586576-1-Liam.Howlett@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230606182912.586576-1-Liam.Howlett@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7E81D1C0002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tyd6pxrzi5p4yoxxpfwczsjxe8a9aykf X-HE-Tag: 1686123801-216090 X-HE-Meta: U2FsdGVkX19ACyJQJD1Y2oRGKsACh/QGODKyIWv4MlHR6yYw/RkrKmCQOEUpouwY7TQmMsvDAr6/oXNzFJzb1c36huEBuEQlkF8UR2p0rud1mG4CVYNXuMVSeG9ARB4k2eSzCTxqqI6wHEKTgqYX86GMECMmJbE7opK/CSZrCzX6sakgiMtysPHaEcvs5AK4X4TfAc+lo4OuDHkfSus+SRB7nyo3jgG1qxc78lYcKCEmjBUoEhb7oE0wUg2Rn+VuG7EIobKkEfr7pEYvE7EieJrRzp29t+Hsvq5dAptnOQY0267JWST4H/Oo1jA/CfKCVNcmo0CRNw8IjspAUFxmwWK7i8xT2bPST4mz5v4N3yYSMmLDUn07n5BXkLeVCvVlLHPrkj4vnuelfdWxkwnYd2dVGl7UG1SwQUxUGwKoEjCR/zm4J9NHUx84XIJOLpQ0gFNXYebuxlbELSbrYGc6FBTSpPYdzgoZw1oxL8Zfc9AwdRvRDpr7KQa/NsL8iA5VFkGvkRI55usTT2UYsejcXAG3Ypt+jtngDo8D8xMF4OOFL/hQlM/VcvJwyd1ogHsQ1LAqgku5kJ3vBUjjx91l6tDCtsb9FFq2m8WI4wXrHbMCbU2yO4Qrcu3PqqEWrhc6Hc6HSakgKGCgPJP0ilLDMkdtUqigISARPuLxO/6qA3K6wk9PKLqrOpWzkxZiWMgq284K98/1TGc+pjqxSO6+IafqA/PuhRyfyb9J0Ltm6/WmRjNYQlSpWHcQ21mZnO5NSXi/79C7O79Sgq6iedMZ+grzYxoiYe6iYkJZQ+xv8Z50/2sUVx1uBVFhYdwDyU3LrL9qPn68j9GAf4r90Ql6G/JSG6ytg+RUGbDpGY4M3zqfEbz2gfARFeTM5C8leE/6qgeHHuu7c7sgQwIEWME4gVHqRpipccdAArH4yQ+VfAUSV2Aec/cDwdA/05dRztw6sYy/ggcccAhV35uN/dJ gbAVKdQC PdubCbfo9MPBsNSrzAse17edHWx7hTlI9/8Dw8pR177x8ybztt94wPXVaXK+Xz3qfDVs3cNzTyY39aisAzdZvAkti26FNEGY12jMmlQ94ZvIvfdorIbaW5R8hjeTepxpthPIAyMv26rD0FnDJxDRwoKW7/TruKIbVcR5Og8iNl2uAaDLdBiW2Dx5NFI5I9GVQEaWj5HJY/rWojR69hnGDIk1ptaTD73WCryKefHfsikAoLmY1fv6S83KeTzpxmnmlMvgdn5KH2b3nCLDtRTBN3mnCze4uArMWoBti0RWZxwTkD6pntWKpvBL/dhdtt9WqwTWo+qeeCDbbTHMcVN8U+IUjww5mKQT2blbQ7L5J8SNrobN4YEOSdypHKysQLZVnOHbV2pSUxqM7iVwiP9Xqhffc0kCzgeCCe6/TJdFdSIn+/HXigB1VpSk5e92jd+JCcqS/t1blg1gx3RO0Tym1QRJJZ30xHbKuMlKMP1Vf255WGlvsP8LZsmSybOOUkJiq/+GVNbzXTIPpxwNcKgT3wWgv21BvXD+/KS6cPi3/z1fSeZwKax+dCvDlxN76IMWrM4QKcAHomf5pjCvN5ao2u0G9SUyV+rXQ55dVcQiJ8xMe4Io= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.06.23 20:29, Liam R. Howlett wrote: > The return of do_mprotect_pkey() can still be incorrectly returned as > success if there is a gap that spans to or beyond the end address passed > in. Update the check to ensure that the end address has indeed been > seen. > > Link: https://lore.kernel.org/all/CABi2SkXjN+5iFoBhxk71t3cmunTk-s=rB4T7qo0UQRh17s49PQ@mail.gmail.com/ > Fixes: 82f951340f25 ("mm/mprotect: fix do_mprotect_pkey() return on error") > Reported-by: Jeff Xu > Cc: > Signed-off-by: Liam R. Howlett > --- > mm/mprotect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 92d3d3ca390a..c59e7561698c 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -867,7 +867,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > } > tlb_finish_mmu(&tlb); > > - if (!error && vma_iter_end(&vmi) < end) > + if (!error && tmp < end) > error = -ENOMEM; > > out: Acked-by: David Hildenbrand -- Cheers, David / dhildenb