From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C27F2C02192 for ; Wed, 5 Feb 2025 16:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4964E280004; Wed, 5 Feb 2025 11:18:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4460A280003; Wed, 5 Feb 2025 11:18:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BFCB280004; Wed, 5 Feb 2025 11:18:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B735280003 for ; Wed, 5 Feb 2025 11:18:26 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A59CE1203CF for ; Wed, 5 Feb 2025 16:18:25 +0000 (UTC) X-FDA: 83086398570.27.2FA6CE0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id 4E9E6180019 for ; Wed, 5 Feb 2025 16:18:23 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DMrpjL3L; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kQMH8M2I; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DMrpjL3L; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kQMH8M2I; spf=pass (imf24.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738772303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qqXMYTGRPo//iC4U6ET+snD1ntsXXfRNOFComRHHCgM=; b=jNZ2dNQ6JmmoCN+y4zqqUNzKNYg0hwLDJm1IRExXec4G+dq4keJt46Y16kEI5Zb9811wVu tfVWfCgmGPXQ2WIIO8ZCHPcs7xvpANWv5RVeszLFrxkEjuyHDYg8tM04ln6oEEb+2EDPqX 1SB8n2aEsjvqHrESkWd2vPYHfsx16AY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DMrpjL3L; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kQMH8M2I; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DMrpjL3L; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kQMH8M2I; spf=pass (imf24.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738772303; a=rsa-sha256; cv=none; b=nMzMp274/4xCR91aLykWaEzVf8anzhSv1XCo9B/c8EzowiGqhZQMpf3qicUKS6aUEALLBy Lvtx4RvZlo93ThaxrwDhOfgATZW0YVQ70k26a443E43zmUZP1fOE4f+kJTEAFzZs2PY3wy ZvzZIXqS2ypme3GnWfQ5e4NFIguXW8A= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 983AC2127C; Wed, 5 Feb 2025 16:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738772301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqXMYTGRPo//iC4U6ET+snD1ntsXXfRNOFComRHHCgM=; b=DMrpjL3L5UVfUDm93oaO+VKDWFmu/e+rkIpfk5qrtpgk9AdAMMU2a8GdsXXzklH3oDQ+bd 1Cxgz/phvR/+65wq9qwyDITOIarvFMhzFCHFdgZ880ZSwvml/9IPY3pubHupqFUeF1JQPf QECo89Bc9mmEWJ0KtLzcxjcqkATVfT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738772301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqXMYTGRPo//iC4U6ET+snD1ntsXXfRNOFComRHHCgM=; b=kQMH8M2IwNV5WtepSpNP4NeSL02tUF3TlNkvI9+uubUP6vBuVY9Yt9I6DDLvfMCOSmYKDn 2EKHTenv7NvRXEBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738772301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqXMYTGRPo//iC4U6ET+snD1ntsXXfRNOFComRHHCgM=; b=DMrpjL3L5UVfUDm93oaO+VKDWFmu/e+rkIpfk5qrtpgk9AdAMMU2a8GdsXXzklH3oDQ+bd 1Cxgz/phvR/+65wq9qwyDITOIarvFMhzFCHFdgZ880ZSwvml/9IPY3pubHupqFUeF1JQPf QECo89Bc9mmEWJ0KtLzcxjcqkATVfT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738772301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqXMYTGRPo//iC4U6ET+snD1ntsXXfRNOFComRHHCgM=; b=kQMH8M2IwNV5WtepSpNP4NeSL02tUF3TlNkvI9+uubUP6vBuVY9Yt9I6DDLvfMCOSmYKDn 2EKHTenv7NvRXEBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2365813694; Wed, 5 Feb 2025 16:18:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Fpb7Bk2Po2eNMwAAD6G6ig (envelope-from ); Wed, 05 Feb 2025 16:18:21 +0000 Message-ID: <1b211dd3-a45d-4a2e-aa2a-e0d3e302d4ca@suse.de> Date: Wed, 5 Feb 2025 17:18:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] fs/buffer: simplify block_read_full_folio() with bh_offset() To: Luis Chamberlain , willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-2-mcgrof@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250204231209.429356-2-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4E9E6180019 X-Stat-Signature: y1w3msm8wznp7tn1bpbc6ed8xfq3p5qq X-Rspam-User: X-HE-Tag: 1738772303-115326 X-HE-Meta: U2FsdGVkX1/zYLQ5SJUJBWYXPC3pdQ/nkgAhJoZkAx7SGAJlLryf5oBR/2Hiq8SJ3gZpvxjDbKEQNhuUKjkn45MfYrgN9uBGajaSPm6JUwtk+cHgSyl7wx1Hx/+asUE7upW2O6IYPJcnxeAJKEl2TzWWu4KblZnQK2JBntoO0TCF0AdmLpYNy7+3EP8lfOTJ4CikjD6G4A3lFi/e65nz+edmbONITkWNUWD7Xzz1jQlSmuy1PLn/xFoSrbcqVt5xsnWXm18VcmAVRS3WY6OWdB+3s6tGfnR5JfnFilNB5faViuZ7L3YRi3x4cSNtzVErL4EENf6ga9z3PZZ3sbX/EQnOTdYhnbwoivP2sRPXQD9nB7Mtty1iokJ+nYVfSSOnsG8JceSQjKDnlRZwIuRBuQAtAkKeN/b+EieJGxuVt+BuJ+lxtV1/1yHvCvHQyNloFb4juq0yGSwzNS+s4UjVId32zn7oeWRFNSG2p8KubZpA/cblN6OznyOMolL8veQZT49McLQIKZPGzAWo1/jtMKnidVUiNwb8A1vvZnLcjrGfp2rRrm6tc26madcLae35XM4mXDAIsM6FcenTvPgOJ5JobGXCoSqzw+AOoj4vLGg73s+juqBFt+BUW6X6d0BhpfU/dOlWlECRypmoDpPwt6mE45wX5mX4MpukdaOARpyTwaJX+XjRFimBOed56s0/IMcRFqf/lZsxg+85rhPWJ1DFVTBVpPOcRPOixAt778jXNyRB8xH6wE11QyK3Jmf444i6GLqD/W83M0BesoDbkcsbVgOl+/dwomg+3veVWRje5sOihn0vFAlpp4jcdTv3dyOUDisIdREHgAkj26rbsw+9AKBVwvzZiPr/Dn2IYSuxSrOj6hcN3DYPNCqh1eH8RXxIDpwa0vkXlFc6iGu0cSGNFRLcXm7xO+le+9NVme0VWF1f8w8nbMdWCWBj+HgEQhHEkj3QM/EJRbMznIk 4pVaF/DL X9jh1vyAvJS5cwCMevcZdP5Rhe9UMDRs272RqFj2W7xd6MGiZynFkkWSfB4HC6zG4t8pYQFLjJDbtUh89sTW4GpGAboG2k7eNaV8hZRh1u54znpEcwh+coP7LrZd2QRtinyHKDAd9uMgNzhju78E7h6Tk302/PJazTidVM08dAOwWw9Q4Kzk+bY+QsrQI/R3xpIg5+06x1q2mVOIddIUQuV9NXMxZvqLTCEmJPT17y1q5vibmQvUKrIZYU3UvnKs1ayXUraDbww5xGkUjmoSgC5uK/y1oST1ORYuL81t7/5+dwmDDaJjiHPQrtvu4b6OmFMSaErLfCKWtrL9QozFtBRjlXeSATwWhDTIkQFU9VqfzlfcVGXDk9trtW1Q9gybTvsY0cpH21c8JvMxOXt28MFkbcEINU9w8BSF5+yD45BCB/vsi4MlVBa3Vz9Uk/m60AvXPKg4CfiXIyn9FiS81JjHJqtdWDtfcWByJAFksGdMRsUsHUpaFpS4JVPx5j5hRnXJ2R8OIipt2fSCTuqzuGZO8Fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/5/25 00:12, Luis Chamberlain wrote: > When we read over all buffers in a folio we currently use the > buffer index on the folio and blocksize to get the offset. Simplify > this with bh_offset(). This simplifies the loop while making no > functional changes. > > Suggested-by: Matthew Wilcox > Signed-off-by: Luis Chamberlain > --- > fs/buffer.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index cc8452f60251..b99560e8a142 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -2381,7 +2381,6 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) > lblock = div_u64(limit + blocksize - 1, blocksize); > bh = head; > nr = 0; > - i = 0; > > do { > if (buffer_uptodate(bh)) > @@ -2398,7 +2397,7 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) > page_error = true; > } > if (!buffer_mapped(bh)) { > - folio_zero_range(folio, i * blocksize, > + folio_zero_range(folio, bh_offset(bh), > blocksize); > if (!err) > set_buffer_uptodate(bh); > @@ -2412,7 +2411,7 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) > continue; > } > arr[nr++] = bh; > - } while (i++, iblock++, (bh = bh->b_this_page) != head); > + } while (iblock++, (bh = bh->b_this_page) != head); > > if (fully_mapped) > folio_set_mappedtodisk(folio); One wonders: shouldn't we use plugging here to make I/O more efficient? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich