From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2230C00140 for ; Mon, 15 Aug 2022 14:01:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 313488D0002; Mon, 15 Aug 2022 10:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C2BB8D0001; Mon, 15 Aug 2022 10:01:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 163D58D0002; Mon, 15 Aug 2022 10:01:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 04F198D0001 for ; Mon, 15 Aug 2022 10:01:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CE41BAB601 for ; Mon, 15 Aug 2022 14:01:35 +0000 (UTC) X-FDA: 79801989750.09.E032403 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id E2E1A801C6 for ; Mon, 15 Aug 2022 14:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660572076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bc2CaX7Vyv8jSZVbk9O/eBQgCcbOhmOwLMqxv9AfCMo=; b=aW+XUo6aPijJpqzIMnyoI37BDJMoC0h7tLkzAxbwU2AcHWiTE1jz+b2r5hcz2OBZpZIY16 rP+8BDSDcGJfYUYXL8KTbTuuSCNT3rtyAubK5hbhSvyq8i04UIo6Hyao4+qshoWwahLXxr D3SoRZWCz+WNbcPyPSsqJaJ84bgN/lY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660572085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bc2CaX7Vyv8jSZVbk9O/eBQgCcbOhmOwLMqxv9AfCMo=; b=YI2DpllBFF1EAei8PnY4bI0RTjUu7DgajL58HyWflGCBNtN6QuaInuyDMBNO/IK7RxfJkC FC+tmV+BTswOvDGLb8IhfoJHS23oDsrR3kD8uzlTkthz8ufpS/PJBRQSGJZPBYcJ5m13A6 nKeUKIlOS3bxJeHp3JYRBqBcYsMEycQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-113--DWdlP5gMXKGfAzb3eMupw-1; Mon, 15 Aug 2022 10:01:11 -0400 X-MC-Unique: -DWdlP5gMXKGfAzb3eMupw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 675FC100AF8F; Mon, 15 Aug 2022 14:01:09 +0000 (UTC) Received: from [10.18.17.215] (dhcp-17-215.bos.redhat.com [10.18.17.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14A60403178; Mon, 15 Aug 2022 14:01:08 +0000 (UTC) Message-ID: <1b10858e-7dd7-75bf-3366-8ccdb48652ac@redhat.com> Date: Mon, 15 Aug 2022 10:01:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] mm/slab_common: Deleting kobject in kmem_cache_destroy() without holding slab_mutex/cpu_hotplug_lock Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220812183033.346425-1-longman@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aW+XUo6a; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YI2DpllB; spf=temperror (imf30.hostedemail.com: error in processing during lookup of longman@redhat.com: DNS error) smtp.mailfrom=longman@redhat.com X-Stat-Signature: jp1pf6aet4jqn8ihepupfzm4gb1unxto X-Rspamd-Server: rspam09 X-Rspam-User: X-Rspamd-Queue-Id: E2E1A801C6 X-HE-Tag: 1660572085-218213 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/13/22 11:00, Hyeonggon Yoo wrote: > On Fri, Aug 12, 2022 at 02:30:33PM -0400, Waiman Long wrote: >> A circular locking problem is reported by lockdep due to the following >> circular locking dependency. >> >> +--> cpu_hotplug_lock --> slab_mutex --> kn->active --+ >> | | >> +-----------------------------------------------------+ >> >> The forward cpu_hotplug_lock ==> slab_mutex ==> kn->active dependency >> happens in >> >> kmem_cache_destroy(): cpus_read_lock(); mutex_lock(&slab_mutex); >> ==> sysfs_slab_unlink() >> ==> kobject_del() >> ==> kernfs_remove() >> ==> __kernfs_remove() >> ==> kernfs_drain(): rwsem_acquire(&kn->dep_map, ...); > Maybe you mean this? > > /* but everyone should wait for draining */ > wait_event(root->deactivate_waitq, > atomic_read(&kn->active) == KN_DEACTIVATED_BIAS); > This is part of the kernfs_drain() operation. However, I am focusing on the behavior of the pseudo lock that causes the lockdep splat in the first place. That is why I am showcasing the rwsem_acquire() call here. >> The backward kn->active ==> cpu_hotplug_lock dependency happens in >> >> kernfs_fop_write_iter(): kernfs_get_active(); >> ==> slab_attr_store() >> ==> cpu_partial_store() >> ==> flush_all(): cpus_read_lock() >> >> One way to break this circular locking chain is to avoid holding >> cpu_hotplug_lock and slab_mutex while deleting the kobject in >> sysfs_slab_unlink() which should be equivalent to doing a write_lock >> and write_unlock pair of the kn->active virtual lock. >> >> Since the kobject structures are not protected by slab_mutex or the >> cpu_hotplug_lock, we can certainly release those locks before doing >> the delete operation. >> >> Move sysfs_slab_unlink() and sysfs_slab_release() to the newly >> created kmem_cache_release() and call it outside the slab_mutex & >> cpu_hotplug_lock critical sections. There will be a slight delay >> in the deletion of sysfs files if kmem_cache_release() is called >> indirectly from a work function. >> >> Signed-off-by: Waiman Long >> --- >> >> [v3] Move sysfs_slab_unlink() out to kmem_cache_release() and move >> schedule_work() back right after list_add_tail(). >> >> mm/slab_common.c | 45 +++++++++++++++++++++++++++++---------------- >> 1 file changed, 29 insertions(+), 16 deletions(-) >> >> diff --git a/mm/slab_common.c b/mm/slab_common.c >> index 17996649cfe3..07b948288f84 100644 >> --- a/mm/slab_common.c >> +++ b/mm/slab_common.c >> @@ -392,6 +392,28 @@ kmem_cache_create(const char *name, unsigned int size, unsigned int align, >> } >> EXPORT_SYMBOL(kmem_cache_create); >> >> +#ifdef SLAB_SUPPORTS_SYSFS >> +/* >> + * For a given kmem_cache, kmem_cache_destroy() should only be called >> + * once or there will be a use-after-free problem. The actual deletion >> + * and release of the kobject does not need slab_mutex or cpu_hotplug_lock >> + * protection. So they are now done without holding those locks. >> + * >> + * Note that there will be a slight delay in the deletion of sysfs files >> + * if kmem_cache_release() is called indrectly from a work function. >> + */ >> +static void kmem_cache_release(struct kmem_cache *s) >> +{ >> + sysfs_slab_unlink(s); >> + sysfs_slab_release(s); >> +} >> +#else >> +static void kmem_cache_release(struct kmem_cache *s) >> +{ >> + slab_kmem_cache_release(s); >> +} >> +#endif >> + >> static void slab_caches_to_rcu_destroy_workfn(struct work_struct *work) >> { >> LIST_HEAD(to_destroy); >> @@ -418,11 +440,7 @@ static void slab_caches_to_rcu_destroy_workfn(struct work_struct *work) >> list_for_each_entry_safe(s, s2, &to_destroy, list) { >> debugfs_slab_release(s); >> kfence_shutdown_cache(s); >> -#ifdef SLAB_SUPPORTS_SYSFS >> - sysfs_slab_release(s); >> -#else >> - slab_kmem_cache_release(s); >> -#endif >> + kmem_cache_release(s); >> } >> } >> >> @@ -437,20 +455,11 @@ static int shutdown_cache(struct kmem_cache *s) >> list_del(&s->list); >> >> if (s->flags & SLAB_TYPESAFE_BY_RCU) { >> -#ifdef SLAB_SUPPORTS_SYSFS >> - sysfs_slab_unlink(s); >> -#endif >> list_add_tail(&s->list, &slab_caches_to_rcu_destroy); >> schedule_work(&slab_caches_to_rcu_destroy_work); >> } else { >> kfence_shutdown_cache(s); >> debugfs_slab_release(s); >> -#ifdef SLAB_SUPPORTS_SYSFS >> - sysfs_slab_unlink(s); >> - sysfs_slab_release(s); >> -#else >> - slab_kmem_cache_release(s); >> -#endif >> } >> >> return 0; >> @@ -465,14 +474,16 @@ void slab_kmem_cache_release(struct kmem_cache *s) >> >> void kmem_cache_destroy(struct kmem_cache *s) >> { >> + int refcnt; >> + >> if (unlikely(!s) || !kasan_check_byte(s)) >> return; >> >> cpus_read_lock(); >> mutex_lock(&slab_mutex); >> >> - s->refcount--; >> - if (s->refcount) >> + refcnt = --s->refcount; >> + if (refcnt) >> goto out_unlock; >> >> WARN(shutdown_cache(s), >> @@ -481,6 +492,8 @@ void kmem_cache_destroy(struct kmem_cache *s) >> out_unlock: >> mutex_unlock(&slab_mutex); >> cpus_read_unlock(); >> + if (!refcnt && !(s->flags & SLAB_TYPESAFE_BY_RCU)) >> + kmem_cache_release(s); >> } >> EXPORT_SYMBOL(kmem_cache_destroy); >> >> -- >> 2.31.1 >> > little bit complicated but looks good to me. > Thank you for fixing this. > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Thanks for the review. Cheers, Longman