From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Qi Zheng <zhengqi.arch@bytedance.com>,
peterz@infradead.org, agordeev@linux.ibm.com, palmer@dabbelt.com,
tglx@linutronix.de, david@redhat.com, jannh@google.com,
hughd@google.com, yuzhao@google.com, willy@infradead.org,
muchun.song@linux.dev, vbabka@kernel.org,
lorenzo.stoakes@oracle.com, akpm@linux-foundation.org,
rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de,
will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com,
dave.hansen@linux.intel.com, rppt@kernel.org,
ryan.roberts@arm.com
Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-um@lists.infradead.org
Subject: Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table()
Date: Thu, 2 Jan 2025 17:53:58 +0100 [thread overview]
Message-ID: <1b09335c-f0b6-4ccb-9800-5fb22f7e8083@arm.com> (raw)
In-Reply-To: <0e8f0b3835c15e99145e0006ac1020ae45a2b166.1735549103.git.zhengqi.arch@bytedance.com>
On 30/12/2024 10:07, Qi Zheng wrote:
> static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt)
> {
> - if (riscv_use_sbi_for_rfence())
> + if (riscv_use_sbi_for_rfence()) {
> tlb_remove_ptdesc(tlb, pt);
> - else
> + } else {
> + pagetable_dtor(pt);
> tlb_remove_page_ptdesc(tlb, pt);
I find the imbalance pretty confusing: pagetable_dtor() is called
explicitly before using tlb_remove_page() but not tlb_remove_ptdesc().
Doesn't that assume that CONFIG_MMU_GATHER_HAVE_TABLE_FREE is selected?
Could we not call pagetable_dtor() from __tlb_batch_free_encoded_pages()
to ensure that the dtor is always called just before freeing, and remove
the extra handling from arch code? I may well be missing something, I'm
not super familiar with the tlb handling code.
- Kevin
next prev parent reply other threads:[~2025-01-02 16:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 9:07 [PATCH v4 00/15] move pagetable_*_dtor() " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 01/15] Revert "mm: pgtable: make ptlock be freed by RCU" Qi Zheng
2024-12-30 9:07 ` [PATCH v4 02/15] riscv: mm: Skip pgtable level check in {pud,p4d}_alloc_one Qi Zheng
2025-01-06 11:20 ` Alexandre Ghiti
2024-12-30 9:07 ` [PATCH v4 03/15] asm-generic: pgalloc: Provide generic p4d_{alloc_one,free} Qi Zheng
2024-12-30 9:07 ` [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table Qi Zheng
2025-01-02 16:53 ` Kevin Brodsky
2025-01-03 3:53 ` Qi Zheng
2025-01-03 7:46 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 05/15] arm64: pgtable: use mmu gather to free p4d " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 06/15] s390: pgtable: add statistics for PUD and P4D " Qi Zheng
2025-01-06 10:32 ` Alexander Gordeev
2025-01-06 11:05 ` Qi Zheng
2025-01-06 13:34 ` Alexander Gordeev
2025-01-06 13:37 ` Qi Zheng
2024-12-30 9:07 ` [PATCH v4 07/15] mm: pgtable: introduce pagetable_dtor() Qi Zheng
2025-01-06 10:34 ` Alexander Gordeev
2025-01-06 10:55 ` Qi Zheng
2025-01-06 12:36 ` Alexander Gordeev
2025-01-06 13:23 ` Qi Zheng
2025-01-07 9:23 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 08/15] arm: pgtable: move pagetable_dtor() to __tlb_remove_table() Qi Zheng
2024-12-30 9:07 ` [PATCH v4 09/15] arm64: " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 10/15] riscv: " Qi Zheng
2025-01-02 16:53 ` Kevin Brodsky [this message]
2025-01-03 3:48 ` Qi Zheng
2025-01-03 8:02 ` Kevin Brodsky
2025-01-03 9:13 ` Qi Zheng
2025-01-03 9:35 ` Qi Zheng
2025-01-03 13:27 ` Kevin Brodsky
2025-01-06 3:49 ` Qi Zheng
2025-01-07 9:57 ` Kevin Brodsky
2025-01-07 10:51 ` Qi Zheng
2025-01-07 11:58 ` Kevin Brodsky
2025-01-07 12:31 ` Qi Zheng
2025-01-07 14:17 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 11/15] x86: " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD " Qi Zheng
2025-01-06 10:36 ` Alexander Gordeev
2025-01-06 11:02 ` Qi Zheng
2025-01-06 12:44 ` Alexander Gordeev
2025-01-06 13:34 ` Qi Zheng
2025-01-06 14:35 ` Alexander Gordeev
2025-01-06 14:44 ` Qi Zheng
2024-12-30 9:07 ` [PATCH v4 13/15] mm: pgtable: introduce generic __tlb_remove_table() Qi Zheng
2025-01-07 12:32 ` Andreas Larsson
2025-01-07 12:34 ` Qi Zheng
2025-01-07 14:20 ` Alexander Gordeev
2024-12-30 9:07 ` [PATCH v4 14/15] mm: pgtable: move __tlb_remove_table_one() in x86 to generic file Qi Zheng
2024-12-30 9:07 ` [PATCH v4 15/15] mm: pgtable: introduce generic pagetable_dtor_free() Qi Zheng
2025-01-07 14:22 ` Alexander Gordeev
2024-12-31 0:24 ` [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table() Andrew Morton
2025-01-02 17:00 ` Kevin Brodsky
2025-01-03 3:56 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b09335c-f0b6-4ccb-9800-5fb22f7e8083@arm.com \
--to=kevin.brodsky@arm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=muchun.song@linux.dev \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yuzhao@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox