From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FAEECAAA1 for ; Fri, 9 Sep 2022 11:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2591C8D0003; Fri, 9 Sep 2022 07:39:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 208908D0002; Fri, 9 Sep 2022 07:39:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1024B8D0003; Fri, 9 Sep 2022 07:39:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 011BB8D0002 for ; Fri, 9 Sep 2022 07:39:14 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CFAB6AB4C8 for ; Fri, 9 Sep 2022 11:39:14 +0000 (UTC) X-FDA: 79892351028.06.FDBC3A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 7D1444007A for ; Fri, 9 Sep 2022 11:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662723554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4+xQ+u9S0tgyk9MqUu4hGDCqntK9cHlkmBOzSNS1R1w=; b=itqytkEaGrXjb0F1mJGy5iNRGjlJcS5XQG1zgowht8dwZXrxgWD6InTM4mFkuYNWafrMFr PFL6/3zEV8BiXMskHQ46xfzWtGPRosG3Csvu9+raPzbmfTekm6yd2zTpJNwAzElN9O4w2o a7pyiOu4nXxrtefZtBDteauqDqihqgo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-470-N1So_UpGOqikpEz5EhE5QA-1; Fri, 09 Sep 2022 07:39:12 -0400 X-MC-Unique: N1So_UpGOqikpEz5EhE5QA-1 Received: by mail-wm1-f72.google.com with SMTP id r186-20020a1c44c3000000b003b3309435a9so1932951wma.6 for ; Fri, 09 Sep 2022 04:39:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=4+xQ+u9S0tgyk9MqUu4hGDCqntK9cHlkmBOzSNS1R1w=; b=49TWTXhpBrodL6XkNXLlzb3aC/6EXApoZDp+qHktpOBWFE3O4KpxsOI2KfE5t+bjMJ CAQ08YRSKKIkETseiHHPsi5wGlrMzsMUq9nDj1u7QtRbGfGhOHHEI3D0xKuzolbFnVGp ANot/7MHtDQmtYWiy75ueeQR2UFJyLbr/IroEWcxrqKszFYCusujags0ERtXcg68qoFq zFrWpV+El/0nq1d2eG9VRJDokXH49CCq+wD/3bf397VL27Zih5j+3zAPtvoNRXyRcuBL muJ3Z9xTmdXEw7PCd0fiVo2SOGScieIhKHniLJYXir4dEyMojKAiuowk2/zUepvGntH5 VlQg== X-Gm-Message-State: ACgBeo3Aszeld1MZm+XFm4SagFM9dJwYUdCV924OQx7vgZbe5dIOHIFK NY5Tv5N5tDoPEZPviHOs4DUTJfN8GyBr8d7m0wWbicSk8zTZPTcbROQJzdQePWFnnmfpARQxnYE QhksvdC4ce60= X-Received: by 2002:a05:600c:190a:b0:3a8:43b8:53e3 with SMTP id j10-20020a05600c190a00b003a843b853e3mr5410830wmq.4.1662723551769; Fri, 09 Sep 2022 04:39:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR5oSOQCv1rV8+0kKXwGqYxsbmkXFVKOldZ3ZBR0HZyGJjq4rqQ63TIdaJov10te02Vg9N29fQ== X-Received: by 2002:a05:600c:190a:b0:3a8:43b8:53e3 with SMTP id j10-20020a05600c190a00b003a843b853e3mr5410821wmq.4.1662723551494; Fri, 09 Sep 2022 04:39:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id k13-20020adfe3cd000000b00228655a5c8fsm308697wrm.28.2022.09.09.04.39.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:39:11 -0700 (PDT) Message-ID: <1b078b99-a0d8-f1d9-d804-10cd0228d168@redhat.com> Date: Fri, 9 Sep 2022 13:39:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 01/16] mm/page_alloc: ensure kswapd doesn't accidentally go to sleep To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-2-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-2-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662723554; a=rsa-sha256; cv=none; b=ZZvuB0hmi8FFZWkFMBixUn+XwE3x8E8Au4kqUxZr5M8zK6XDGfBIJnEiifVC6YUDIrAxe2 m7rb8UFyZo+GpKfCjlvNwR3WNcVzBubCu/IzQhwLnoAX4VN3dE32oQhWnNO3Xv1W59U/pM bkMnckdZrUATs0pJtKubvjvPTdvXxIU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itqytkEa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662723554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4+xQ+u9S0tgyk9MqUu4hGDCqntK9cHlkmBOzSNS1R1w=; b=PAQCahDadvAJiMkg4oZTXoNVeTMhxAEgkkqG0PklPCGQjSaZYXspea9fAL6dP+2yRlNV4K RbvUBMBWaI3kmkoeX0QrGI1G7Y2GLlrY2R2h5WK3cJWpBP/9Mo0qvS30hWhMvvxvm1Mx1O 4Njjs7IgFDVSWBYlEf8HEFlJ9zjYuWs= X-Rspam-User: X-Rspamd-Server: rspam05 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itqytkEa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Stat-Signature: zm1zomuszebs5zb9fceyw1mwfbb8c1qg X-Rspamd-Queue-Id: 7D1444007A X-HE-Tag: 1662723554-434891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > If ALLOC_KSWAPD is set, wake_all_kswapds() will be called to ensure > kswapd doesn't accidentally go to sleep. But when reserve_flags is > set, alloc_flags will be overwritten and ALLOC_KSWAPD is thus lost. > Preserve the ALLOC_KSWAPD flag in alloc_flags to ensure kswapd won't > go to sleep accidentally. > > Fixes: 0a79cdad5eb2 ("mm: use alloc_flags to record if kswapd can wake") > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index ba5c9402a5cb..4b97a03fa2dd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5147,7 +5147,8 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > > reserve_flags = __gfp_pfmemalloc_flags(gfp_mask); > if (reserve_flags) > - alloc_flags = gfp_to_alloc_flags_cma(gfp_mask, reserve_flags); > + alloc_flags = gfp_to_alloc_flags_cma(gfp_mask, reserve_flags) | > + (alloc_flags & ALLOC_KSWAPD); > > /* > * Reset the nodemask and zonelist iterators if memory policies can be Acked-by: David Hildenbrand -- Thanks, David / dhildenb