From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14435C021AA for ; Fri, 21 Feb 2025 13:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E2D728000E; Fri, 21 Feb 2025 08:13:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96BF2280009; Fri, 21 Feb 2025 08:13:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BE3028000E; Fri, 21 Feb 2025 08:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5E00A280009 for ; Fri, 21 Feb 2025 08:13:08 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1CA87161059 for ; Fri, 21 Feb 2025 13:13:08 +0000 (UTC) X-FDA: 83143992456.30.46C7371 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf10.hostedemail.com (Postfix) with ESMTP id D1D52C0002 for ; Fri, 21 Feb 2025 13:13:05 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=pc773gsj; spf=pass (imf10.hostedemail.com: domain of quic_zijuhu@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zijuhu@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740143585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rMvoDC9TQDacf/N4q7elXEm8gc6mCq2kbKwfjC8SnZE=; b=twz4cC8aH4e14gRmCQDD5uUPgjZ/sTxVUbcJpQzl3pQ9RDMMwqr79xYDtIRmnpOAliQz8j v286ph4cEiTx4nvGAN8xBQ+EFDUaw5AvpenKbxheCJNkhdIfWNVgqByAsi7iImmRXPfREm jkf4DvJRTUWHGEFjAr433KFpMwmBwfk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=pc773gsj; spf=pass (imf10.hostedemail.com: domain of quic_zijuhu@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zijuhu@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740143585; a=rsa-sha256; cv=none; b=E4/CdRPQDPecFYkZ01MsCqZ7JnLTBKD5Y/LQ7jYYudltagZOKF6lVJCP8yhmimy+9TY9EW Kqmw7xTfG+UwFEXjcCw+aonqTLV0ALDRRUY3qOVvPxZFuNmu5Xf9CaN3d5QvuEQ154KFYV K3dyG6SAtSfz4K6E6HvUAhYfPH9FPcA= Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51LCkunU031803; Fri, 21 Feb 2025 13:12:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rMvoDC9TQDacf/N4q7elXEm8gc6mCq2kbKwfjC8SnZE=; b=pc773gsjOQLDV/PM r17xLoo6bZqZ2646wj4cFe1GVnZb/X5+Q3SL5PCzSLg058TzPTP4wC9gwdLLi7uR w+MvokjXu516qUFcWhVs5inKQIXjZEOs+27Hstywy2GStMMl9S2Ye0kFmYcm36fI VnTW4nQ1ftmRByq4AZnerZaYKIpPYRqkogaGne5lMCENEzLeKLqXT2enmfz0oFMX 6t0SJIyZDOaW5/LM/HDgvhtiljH+do9ffOB7c3F0YC6qKXcXYZCIFJJp9mOJjB97 NEoeItGOkynDrKEFPp2FSIfQEAJ35Ga5eLsYPD0f4hKDhXXYEpa7aLPF++I//CzR BAlz9Q== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44vyy5j0cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Feb 2025 13:12:45 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 51LDCdgX003306 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Feb 2025 13:12:39 GMT Received: from [10.133.33.29] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 21 Feb 2025 05:12:31 -0800 Message-ID: <1aefcfbe-cdfe-460e-9ccc-d7b5e0f9f330@quicinc.com> Date: Fri, 21 Feb 2025 21:12:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH *-next 13/18] gpiolib: Remove needless return in two void APIs To: Bartosz Golaszewski CC: Greg Kroah-Hartman , Will Deacon , Aneesh Kumar K.V , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Zijun Hu , , , , , , , , , , , References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-13-cc8dff275827@quicinc.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 6LBvVGxpuh7hzUH31SaVtdTZALn_bpnL X-Proofpoint-GUID: 6LBvVGxpuh7hzUH31SaVtdTZALn_bpnL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-21_04,2025-02-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=827 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502210097 X-Rspam-User: X-Stat-Signature: dabu8mu6hf61c558dscu178t4ijeibrc X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D1D52C0002 X-HE-Tag: 1740143585-492297 X-HE-Meta: U2FsdGVkX19iCwWWHmNIj6z51874gpM6nZ+u2OBTk8FBJhA8uFkh2K6TMEqYiQbxtP472mNGNf+FlRBvAf3ySpXUvfMQcExKkUe5ak2HiaqfR0hq7JwQYemKmY+UZtYMUyC+WpppkR1eJdLi70m6naVzMBokYFJZQsSrAD2C//340tRzzcT75iFaK4sIC6DzSXgjxoC/RcFWzQuqwJm95/8Zr8+43jA278CJ2Cg3yP6pdfiCskmj9JRew5EecKUpv4kyCugHNj4eM9S4pbFOE+XCvu8MHvosvYlHiBtmVAq4F/u3JJU2vz7RtQUuUAO2NApOg+eZPjhdPj4wP9ktYZw5L9PbXeW4ybr/5UdTXqkOFNj1e0Ji5eJuR9vNQpFYlCun5ihSL80W+/598UnM1JQuIHvRuuPJ7cdso4qvtBQqqo7UChEBOhzpVvTP3lcigOtQw5gnpq24N0BVsdj1f99xUNy5KRf8KVcxMWFFyie830LyZ/3CWQ0zLKEkakpyegQocQJH1f6r7xwOnic00lXSVKnHunRqxFI9TOqjK98l6NxITzykZnmQvnAV0ajGbw6i+iypJsCLTPGSoZdZQJk4cX5tJ2lDxUwaYr66EFAyLWjkD44372jKPR5fKK/E9hsouJjKXujD7az3RgM80CZgx71li5IINOGlm15hH4IWJ/J3UM6T7kdD3yOZIfKqjNpMWYXwq3poREGxl9TiepMtRZobLYkrGUR1erWtctIR/PBHutamko1yu+8l8EvKUko/xL96IKfEGnjJs8Imo4cz+ZqVgVALiHJfQSasAhMJJlUthmRMSktaT18zOqg6cjpWG9wYZwiq+IhgVY+5NOpVxxkI7FmEfTB/8FV2+EbmX3uJGeE4rLfJDl9Z7GLHWYtbtR22yLkySM2QNGX5Q1rL0FvnLrRb6kTCSS2RGNAkGnaT6elMtocMUzLI3d/YqbaQ3ELvkjlnkjShjEQ hJ4Po3Ao MQbr2jy24Q02zTAUwQ+rW3Fwo8knNBwJXPD41M0v5Mg+3h4zdSbpC/oC2WLiWddfTauneXQmIfDx3cX7SBdRN5w/xJ2jfqfEpM7DdSz1ObTGA0Spbg8JyE739v6lrafPdNszj/psoiO4WAbXtPKWLaCW/F80UuEwRQVJU6p2zU3tKihc1jMGqVPBiTpN8/kpNrPi9WUG7afz1CjcLC49raENiRKWDqkPjLz1B7jFKx4tty8d53CWPmBbnyqkqoE3N/tK1wrMZ9R7gfR/l04ZvkKeJ/+M74Lxsh0uJr00lF8UWZhFoqY0F87ncRDGVH0n2Tfkz2x0rZquo4CiEA4YvIitBmx7Q5NLSo7X6z/RbgTtc1m/vPH2TxHncIhUssa4tROrV8b75PA252h6w6qZkgCJ5Qz/37OiEjMkbwPBiS0gvXmdufcmGbTpnfeOMS5EaQiv+OtWGVulPqLbRl6N8NY072I1/q3+D5n4DuxVJKElHrMuJ+xL25Wc8lpzh1hwJlP+nuOlq779Z24sQrnsR2vIHwF2dkY0zrK1b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/21/2025 9:06 PM, Bartosz Golaszewski wrote: > On Fri, Feb 21, 2025 at 2:02 PM Zijun Hu wrote: >> >> Remove needless 'return' in the following void APIs: >> >> gpio_set_value_cansleep() >> gpio_set_value() >> >> Since both the API and callee involved are void functions. >> >> Signed-off-by: Zijun Hu >> --- > > That would normally make sense but we're getting that reworked[1] in > this very cycle so please drop this patch from your series. > sure, will drop it in next revision. > Bart > > [1] https://lore.kernel.org/linux-gpio/20250220-gpio-set-retval-v2-0-bc4cfd38dae3@linaro.org/