From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D5BE77188 for ; Fri, 10 Jan 2025 15:29:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90E316B00B0; Fri, 10 Jan 2025 10:29:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 898656B00B1; Fri, 10 Jan 2025 10:29:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C19F6B00B4; Fri, 10 Jan 2025 10:29:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3DAA16B00B0 for ; Fri, 10 Jan 2025 10:29:09 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EFE8F80A6D for ; Fri, 10 Jan 2025 15:29:08 +0000 (UTC) X-FDA: 82991925576.22.815FC1A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 57A8040003 for ; Fri, 10 Jan 2025 15:29:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dGJrmNRi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736522946; a=rsa-sha256; cv=none; b=rQl9t7lEM74J4YwfnGomso6DL56zmmBEmSSVUTsMlflSFzqI4Ex46Iao3ix5TA+D0HcKS+ vV9LKJbAhNE67t8Ey6pGvfQgYjZhEna/nh12GNNI1lUqTjBVAFg7+cVt2qNGtIaGqvGE3T /T7DkBV/rV7Vsk/ZZLK7xR6i30ENqZM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dGJrmNRi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736522946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JedACyF3qaYIJ70J/2rldT4MFWaos417O6C0UzElWMQ=; b=NExlCDs0WP+TAN3oqygA+Zujs/A59KO0JTWKhfgnukJ5Zj8fqQLSq92I9otaL4oltc7zRp ZPvwfPSEZa/EseHx1KjjR51Tdb0fhdMc5ObvAqVDlyOVdGnCEHursYVc7uqpScj4RYbfm4 dZsv5KypxQAZ/ib8JSp4i9kA0zZxCv4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736522944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JedACyF3qaYIJ70J/2rldT4MFWaos417O6C0UzElWMQ=; b=dGJrmNRij8aOAk4y79Mkack8DOXaDQC9B+DF4Tfm1XretkqwJnqK4yWxK9Ro01gxygGhQY OuDDY4p32tP/ppsm9nAKJjUa9rCx1Bcwz3LDIDJUCMt6jjvZI/djJKnBsETSCQzIJVfgPw CINDwGOvaAXATMbubPNZVasYpSzdQjo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-GJG-flf7NpCkYl3vO8ofjQ-1; Fri, 10 Jan 2025 10:29:02 -0500 X-MC-Unique: GJG-flf7NpCkYl3vO8ofjQ-1 X-Mimecast-MFC-AGG-ID: GJG-flf7NpCkYl3vO8ofjQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43628594d34so12096785e9.2 for ; Fri, 10 Jan 2025 07:29:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736522941; x=1737127741; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JedACyF3qaYIJ70J/2rldT4MFWaos417O6C0UzElWMQ=; b=RDOwnNSJ5tBVPvUHpml09X4Zh284IvgRyPTwNqmpusHZzJT467zeuURYRToM8YrLCB 7MpZScQXBUir1Wn1i1fWBwNAGoTvKkrH44M+LT6TfTkEUmhFdx40RmVxv56uuHgtJHLK Qe7SfwWZFHTt0WL4DnScWJlUlJbemxOEI+Zbs2nUBmQPEOKEzLFcxLYu/adbGtWh7NMI DFA+dF4mDUKQ4XjoJei1pmDQRT3mGWVxfbB70nYbQt3PLf2VSysY0Nx+xJ76MW7VZWxu gNlnpEkqfoUI5fXKPFoXd1rYn6zvjWf1b8IndQjkxxpcle7ZkGGwo7s2TRnJ4iM2acr1 ysww== X-Gm-Message-State: AOJu0YwFgXNxlxcABrn3AEzSwQcC1zg0bqKCmsSG8O5Bu20V0X+ibTks YnEdGtlZlcAPn+4Hv4IipeHHZdoBP+Novz3bnjujMEzoMQiJ5NYKZYWHow7lWev2BCPU1ypwpmV dKbzhdfwHTJrf6X/cNO2iSjZyfPC8bq6WktF24X9EmIiVXG/u X-Gm-Gg: ASbGncuTlmpdHmklCJFC9fthzMgzPYeBsqwfpGK22nNGqKSSOq8thVWVGghWejSygFh VPnxKPnQDlftUyzmEHX6Z26fe4JzxIsqIfwrdGBmMAxwdM2V6Il5wD9Ldnd54t49HyUAaIr4PWv SWsDPG3fzwcq+DkQkMvZdBTwfCHYh/9kb8YVi6J0E58WzfdcGnFExXCB4/B7twGqZa6tmvlnheb kSJZwnEt7AxivdRl1U/XiaT5wo+S/Otv/upggMc6XCNonrhwERZULnVUR3eP9r0JT1FtrjimgpK BqxILsWb9hRTQrR4XXjpi5rHh4ZaTv7qTQH2dNOJqiyhPoUIzVWrmEJ12G8gZ1YdPMl5bM5uHZ+ Sgno+XINj X-Received: by 2002:a05:600c:46c6:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-436e26d9482mr94059565e9.26.1736522940988; Fri, 10 Jan 2025 07:29:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnAGe2xqHxmg2z1ZugKda1zemeP3ZymZ6IqA3Yc14/9MbHhyrmu+3BSz6AZa88PuYXrh1Cow== X-Received: by 2002:a05:600c:46c6:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-436e26d9482mr94058915e9.26.1736522939414; Fri, 10 Jan 2025 07:28:59 -0800 (PST) Received: from ?IPV6:2003:cb:c708:e100:4f41:ff29:a59f:8c7a? (p200300cbc708e1004f41ff29a59f8c7a.dip0.t-ipconnect.de. [2003:cb:c708:e100:4f41:ff29:a59f:8c7a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1ce5sm4865805f8f.94.2025.01.10.07.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 07:28:57 -0800 (PST) Message-ID: <1ac669c9-331b-493c-a241-8a7a07716eed@redhat.com> Date: Fri, 10 Jan 2025 16:28:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] selftests/mm: virtual_address_range: mmap() without PROT_WRITE To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Andrew Morton , Shuah Khan , Dev Jain , Thomas Gleixner Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250110-virtual_address_range-tests-v2-0-262a2bf3c3d0@linutronix.de> <20250110-virtual_address_range-tests-v2-1-262a2bf3c3d0@linutronix.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250110-virtual_address_range-tests-v2-1-262a2bf3c3d0@linutronix.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gj3C-VkxYW1AOrKdjBSjeivvGGIn9Xpz2mT2ytykvgc_1736522941 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 57A8040003 X-Stat-Signature: bw7efeojsecsu8k1z6akiqgrwdu9ucn7 X-Rspam-User: X-HE-Tag: 1736522946-907582 X-HE-Meta: U2FsdGVkX19ch08WTO1LUPaIEJ3n/F8dnDwFkq8xy2vFvTvuLWmsE0jMnmBaBwIwL2bVqVg+28rsH9v0mB7Qbt6z7TAn1RvsAE55puTFVIqJ1q4+pqK4m7NUoUV3wGgBnpCJvKCju2LBAOJs2ZkZAATo9YjIueomFzSXLCQx0wBU2chl1OsVkfq4B5yK/sia+WtLbmO8Ry2WSLALjN+ydqWp78xdwUOIyMjTllyJFVYh14s+FIqptnUoQ3n+NnSQonpDMBHfDFQFkyxC8Ehi9dtrSdM9JUAEvU33tOQGLIatMt99JGLeqY3g2c0wjfISp40xLhrfVpe0QeajVawrEyxj71hNj10XYWeWmCnizToCbSqQVH9LzdJzKu5cMHVtS8Lk4ZDILWvx5ucR9i0WBTh3uXwSDzwba7f89u6/1PqqWx8fltgx4wdxvBIGHI98WeA/7RURPfo9fFL6537hRpbfF8mcYIO0k87At6ea4r94sqcNJKbFwBP5Vd3bEkQa/Lx0w6x5nNHVu41NIg5kRjObTDqIJUWb7zGVJG6i1Jr5M1KWJnx4Jgqf8zGczrM2QsmLBdq9nlAlEJ9NU6ttgle53z4IY+M0mYWlyX5E4s2TlFQzAmkdb6Zd2nZeD6qzWOw8SaLJ13N1S0h6WVphVY0DUEwEGbln5PyutyOADHhAYjYv5pUEfAwyLat3Eolti3kH2rNTzWSbVjtw63N/BMBaCqS1X+k0ScuFS70nRjDxhQT/ge/Mle8O23UTt9J/5RGMjHB5NfnG/UaEP0k3qIythQ4zOeNt5TAqQEuvnlvfI0NAik6YkQWhopI6QuKyf5GcgT2UVJ5zu+A1h0V3FSkf4ZlewXTqJmiwRsAxFd346YsGurf4BEZbLVxhBGeH/C0t4E2Bz27XhtKkNMTij5R1wvIVVvzmR7mjORGJkj+gaRFmyNNBDfa8iP7zPGRahAkMf68lR/caI9RQcYA Z8d1GPV7 Lo2VULzbfo0BkgJJZ+iUOrDh7Z+cMplyeagrM7LCAqlP89wLLxpX4K/mqGoBqrv3JcgPKTriPgOJVX3UIzYyvAXXFGG141hQNsTsVQWlzWCH3ZtZdbxEDI1o93sW2zsA6vTXtMU0tpgting5nX6mC5/WgbrzDP9WaTOPt6/bE4PAegY2Gi8KrWbr74JECZ48WfYefa7HfeqZdfuF2HtgLaWKkmCBFaWoDgv9GgAf9H6I1ZINKruPFkohPWMajogkAgYqFCCxit+TUdKX8z2R+NBcX0Vgz91urOR/DYWa3r3S8+AgttcTDwdFa7Ys7yMVugAT1AMrJ8SYUNuVtDE4b2GuzlTpSAOC+8vVxG6dFahrPwysibsmDaGRnasoxmtmvP12qz8Z+XpPv4+VsmDHDIquVY/jYBHEvHFqqrTYXWoRPX9LIIWvU2HhzY/ReqmvbyOQWsMOejCrApZE+GFbnM0ck6vWYY/aAVjvh/9R7B61gMNDool+T7CSG+3X9oE1ofPZXbKp+TDympQM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.01.25 14:05, Thomas Weißschuh wrote: > When mapping a larger chunk than physical memory is available with > PROT_WRITE and overcommit is disabled, the mapping will fail. > This will prevent the test from running on systems with less then ~1GiB > of memory and triggering an inscrutinable test failure. > As the mappings are never written to anyways, the flag can be removed. > > Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") > Signed-off-by: Thomas Weißschuh > > --- > I went with dropping PROT_WRITE instead of adding MAP_NORESERVE as this > works even in the face of OVERCOMMIT_NEVER. Yes, makes sense, it's certainly simpler this way. Acked-by: David Hildenbrand -- Cheers, David / dhildenb