From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DB9EB8FA5 for ; Wed, 6 Sep 2023 07:29:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5453D44014A; Wed, 6 Sep 2023 03:29:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F4868E0014; Wed, 6 Sep 2023 03:29:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36EA044014A; Wed, 6 Sep 2023 03:29:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 22C258E0014 for ; Wed, 6 Sep 2023 03:29:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E2F13A0CE7 for ; Wed, 6 Sep 2023 07:29:56 +0000 (UTC) X-FDA: 81205348392.10.B34B2B3 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf19.hostedemail.com (Postfix) with ESMTP id BD75E1A0010 for ; Wed, 6 Sep 2023 07:29:53 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of yuancan@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=yuancan@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693985394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QfHHr6ll71IYiRrIBcEpXUpqKPlwwlOt+VaSpEGN1NU=; b=B2D6Q97SjWvX/syUGNnTgjapB370vn/EKlu2tHGoEeeJMWnIrFikX5Omj3bwb/t5z6DnLn gfkE/ZsLUMkJwyuhxpFB+BTiS2F0C79mBHpD7QfmP9STVGK0HnFJBFTxPsS+PO7B3OwNjR GkDEkyHllaGC0hUr9VEiJatEBAeJj04= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of yuancan@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=yuancan@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693985394; a=rsa-sha256; cv=none; b=0exaiKLvYGAqSXUzLjYXlVCNL6jYfUDK7KfCZ4qhhOiAOgT7NPs64dpIT95StBN4q0cinh 7RI6UH0W46TxX0i7ijxNV3LOcoyFFx/Luc3VDxjTnVq/tbCsFol5OQLJxcOvtboJP1Ju5s gIECjiUkeLXzz5/mO2fCLyGdTNQ+kTc= Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RgYqg71ZfzrRgQ; Wed, 6 Sep 2023 15:27:43 +0800 (CST) Received: from [10.174.178.41] (10.174.178.41) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 6 Sep 2023 15:29:31 +0800 Message-ID: <1ac09088-6309-1bb5-5c8f-18eaaedeaf23@huawei.com> Date: Wed, 6 Sep 2023 15:29:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] mm: hugetlb_vmemmap: avoid allocation failure message in alloc_vmemmap_page_list() To: Muchun Song CC: Mike Kravetz , Andrew Morton , Linux-MM , Kefeng Wang References: <20230906063423.99395-1-yuancan@huawei.com> From: Yuan Can In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.41] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: BD75E1A0010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7ifx9hcnctyxr9pbxa84xaojbkrtkjy7 X-HE-Tag: 1693985393-800871 X-HE-Meta: U2FsdGVkX1/x2kJiEGeAha1b9UFL2GGzUv85bOG9RFXyOE1jGA+vFouw0F53EVLOOP9l4WzNj3EohngPIVHbWU3OTvnd8WxzoMwa4R+/G9LXHz26LNQmKKfUH52vNofTrS7q1lO4t9asnNJG9zUF+H6M4qp2KLpDUvRSV8C+smzmkpcbf/to87Cm3UQiQcKtETaTmUVqZySdwkafenm4rZDfwzI8jmhm33zvFz2dBLl55FD6hMeh3y+/mfK1FNFtyu/Qb7s21Vf9Su7zz8pNq9Fha4qd/+may8+3EGIuwlUrYBVHVAv+w5J0s1mPA7VAQXrYfOlmAIWdvs8iZJSmhIlRbUOn1bdoxeKIYeeEymKgU6zNtRoLiKTHtTwX3x1hoNhrFlxJSf8tTF0fCPiaFIXQxhFI/vc0HhVWqVi/QtHnWCc4YC3U7/me13J0zoGyL6Jrrg0ZHY8RSbQmxtwh/AGa36z0yPpR0Nwg3qViLN3vU/U24F3JkvU27CVHUGggPf5pUhbHqe6pWhXGU1v1Z7TkEwZgImf6tjZi2oqzeRdU2BxYzqYQ+Qbu61/o7RvRMa2Hq+Y6Q9SPZYnhTdKIcizVaDYXcME/KCuJkevje+AHh6IcgFEsit3cgCd3OChvEvwY128or+P5rPVaHU/rodZffrTHQm/mlU42HXKpvSKOagebEPl+93atg6Cx4JqcfQfZHThPhMnKHH2CPByq41hTTaD/mWONy/HnHpAsSvN31uxbVkqnFzqT1oXCEsaSBoQYkH47wGEzCYMIfjVSJly7a0gsiScyuwAitnJzreMatWzxrfuahebhHuVHJ57IDRuO48fASCP4mWA6fYot/40L7phUr6XMaHlAtTKXuZNzJx9a/AxOZ/C3vGPZF3St4f3X3FiuChSeM2grsat90jE+gCYvbFGH4V1DhWX9mtH3sTa1g1owX0r+9OECWXubJRJWn/YMmsB8dJo/I0g DBi4jhDT TpkxW/O9dqKpYbsQq9Oti9NqQwDjVr5l8WBsZw3xBJf5RUBcszflxPil8XQDddt2V5cvOpAlr5tHdtXpvEV6b6vZ2eyuVhKgvyySRaQvZHtGlCr/hUtmlRan5AScrS/McuCqrG3MPaXcbsKBcvoYfx+K4HoQoUTdtgF4Vo/JxqQ3RKiJETDDCbvpc1HKopt22AvpYceRv0bNEFUs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/9/6 15:25, Muchun Song 写道: > >> On Sep 6, 2023, at 15:22, Yuan Can wrote: >> >> >> 在 2023/9/6 14:52, Muchun Song 写道: >>> >>>> On Sep 6, 2023, at 14:34, Yuan Can wrote: >>>> >>>> When vmemmap pages allocation failed, the hugetlb pages fail to free, >>>> which is not an fatel error, so avoid the allocation failure report by >>>> passing __GFP_NOWARN in gfp_mask. >>>> >>> You have misunderstand me and Mike. We mean the memory allocation >>> in vmemmap_remap_free() which also use __GFP_THISNODE, it has the >>> same issue as you fixed in another thread. But the failure of memory >>> allocation is not fetal. And it is better to remove __GFP_THISNODE >>> as well. >>> >>> Thanks. >>> >> Ok, sorry about this, I will send another patch to remove __GFP_THISNODE in >> vmemmap_remap_free, and I would like to know is it ok to add __GFP_NOWARN in >> alloc_vmemmap_page_list()? > Do not do this. We need a warning here. > > Thanks. Ok, thanks for the reply. -- Best regards, Yuan Can