From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152DCC433EF for ; Thu, 30 Dec 2021 06:33:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66DA96B008A; Thu, 30 Dec 2021 01:33:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61D916B008C; Thu, 30 Dec 2021 01:33:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50C8F6B0092; Thu, 30 Dec 2021 01:33:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 447DD6B008A for ; Thu, 30 Dec 2021 01:33:03 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DF2B787712 for ; Thu, 30 Dec 2021 06:33:02 +0000 (UTC) X-FDA: 78973493004.19.9E7EE84 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 991EAC000A for ; Thu, 30 Dec 2021 06:33:01 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R801e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0V0JrawZ_1640845976; Received: from 30.21.164.60(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0V0JrawZ_1640845976) by smtp.aliyun-inc.com(127.0.0.1); Thu, 30 Dec 2021 14:32:57 +0800 Message-ID: <1aaf9c11-0d8e-b92d-5c92-46e50a6e8d4e@linux.alibaba.com> Date: Thu, 30 Dec 2021 14:33:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: mmotm 2021-12-29-20-07 uploaded (mm/damon) To: Randy Dunlap , akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, SeongJae Park References: <20211230040740.SbquJAFf5%akpm@linux-foundation.org> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 991EAC000A X-Stat-Signature: 8htmr4aeaxpwtqzdbzfs7fueiwtwyw48 Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.42 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-HE-Tag: 1640845981-211345 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 12/30/2021 2:27 PM, Randy Dunlap wrote: > Hi-- >=20 > On 12/29/21 20:07, akpm@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2021-12-29-20-07 has been uploaded to >> >> https://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> https://www.ozlabs.org/~akpm/mmotm/ >> >> This is a snapshot of my -mm patch queue. Uploaded at random hopefull= y >> more than once a week. >> >> You will need quilt to apply these patches to the latest Linus release= (5.x >> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicate= d in >> https://ozlabs.org/~akpm/mmotm/series >> >> The file broken-out.tar.gz contains two datestamp files: .DATE and >> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-s= s, >> followed by the base kernel version against which this patch series is= to >> be applied. >=20 >=20 > On i386: >=20 > ../mm/damon/vaddr.c: In function =E2=80=98damon_hugetlb_mkold=E2=80=99: > ../mm/damon/vaddr.c:402:17: warning: unused variable =E2=80=98h=E2=80=99= [-Wunused-variable] > struct hstate *h =3D hstate_vma(vma); Ah, thanks for report, I think below changes can fix the warning. And=20 I'll send a new version to address this warning. diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index bcdc602..25bff8a 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -397,7 +397,6 @@ static void damon_hugetlb_mkold(pte_t *pte, struct=20 mm_struct *mm, struct vm_area_struct *vma, unsigned=20 long addr) { bool referenced =3D false; - struct hstate *h =3D hstate_vma(vma); pte_t entry =3D huge_ptep_get(pte); struct page *page =3D pte_page(entry); @@ -414,7 +413,7 @@ static void damon_hugetlb_mkold(pte_t *pte, struct=20 mm_struct *mm, } #ifdef CONFIG_MMU_NOTIFIER - if (mmu_notifier_clear_young(mm, addr, addr + huge_page_size(h))) + if (mmu_notifier_clear_young(mm, addr, addr +=20 huge_page_size(hstate_vma(vma)))) referenced =3D true; #endif /* CONFIG_MMU_NOTIFIER */