From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C575CD98E5 for ; Wed, 11 Oct 2023 01:59:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E78B8D00E9; Tue, 10 Oct 2023 21:59:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 896E78D0002; Tue, 10 Oct 2023 21:59:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 785508D00E9; Tue, 10 Oct 2023 21:59:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 699778D0002 for ; Tue, 10 Oct 2023 21:59:33 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 38D481CAAD5 for ; Wed, 11 Oct 2023 01:59:33 +0000 (UTC) X-FDA: 81331523826.29.F293724 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf20.hostedemail.com (Postfix) with ESMTP id 4916F1C0003 for ; Wed, 11 Oct 2023 01:59:31 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=Vppq1Pqm; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf20.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696989571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LIetvc1RCzHeFJQBRUPPPlIX4XH2j0AA3ULxkOAJjLY=; b=q7hg5eRpai6/PpqBbFHKSQLtlAHsSkXm2JxbbW3/obfRxxkh8HHy2r+zdqBTmS8nwIO/I2 03iyCRANtuUZLmCAkszef68vHBzd+cpdOb4AiX5B29TYNmAKt+52Bo9B0rh3lI5T7dfKV6 ACFquXepTAdlDjvPcR8m2u4A4n9hcLQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=Vppq1Pqm; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf20.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696989571; a=rsa-sha256; cv=none; b=koDTSKlJx8nlFl2P64Eh1D3kDOczTxsSIgV1Q2hvIglOVvfngtTRy2Z3exK6/QJjXAtksv QtfQY4DIdgCT/MOwSf3O6OhylgcS4g0ih9pltMqscCNqf7NGP7a20AeXRV/ug5MpzOof3c qNSuC20nZ4UOsyikSFWLvQj9CkiDsiY= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-692779f583fso4483327b3a.0 for ; Tue, 10 Oct 2023 18:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1696989570; x=1697594370; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=LIetvc1RCzHeFJQBRUPPPlIX4XH2j0AA3ULxkOAJjLY=; b=Vppq1PqmQK/gcuuGW/bL1KQ8QfSy0waADEaC3NVuFyY9z2jeZ85S/UoU7KvHsNSNuP DIwBXvIjkiwHkB7mi8EPkLLJNEvbTIrtqf9AG6RvVpHsrAqnj26K5+PEA4hsC+i84uPb MU5AdiIh2lYEAgEYF2p/K7wCUX8RTm60eMOg1Lq9HlwNSF2rDRLexZNwT9FCak2YQq6i fRRb3zA6nT1BgMz/GQU3flY/0v80cRxv6ayHh0sPHl9PxyRKgvS/QuzS8JdB9uJFb0UD hhrKR37GNjnjDspYkXFm4JV8+D3zSOTqTGkd1pIwI8Su8/B2JDJR9e7NUQOrwn5KCDVB s/3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696989570; x=1697594370; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LIetvc1RCzHeFJQBRUPPPlIX4XH2j0AA3ULxkOAJjLY=; b=gsF6mIq9cwASp2UL4y3snrrVhy34PjekCZJxCiNJDxEw2Fj+Pk5ea3+O/QzwdHXsDR L+CHatOs8RXq43LBqzFodOXi8dKUWXZJBPCoDpmMC5t+h8NAkX/Ry+n8TqGLfRZZBD/L us0eCrojUcLbybC6boQAm1witUDmDQizAgZa2u23t3AKOMFH2UAkFBbF+TyUsW1UhORz TCI3skWqhme5qdJTCzqZMhg9AFaeN7sdrHwj1ulfFaog2f76jd6KApX2lHrKx3510Iqz 8CdfUC1SESkHu736+cgZoj5Hx9EUTim0MjU/3TMJOI9O7uQ8lFAfFNQ7GdgyXnTGx+mP RZ6A== X-Gm-Message-State: AOJu0Yzbvw7CCgOCEBf1TzKU1rw1KNeIr2tTI/jtpLt3VGRUACQEj170 IXatpAkurTe/dH5w0xJAc0GhWWcZ6IQsU52aMug= X-Google-Smtp-Source: AGHT+IEqkTNN2T+hfCHJ/ViHfWdxArtT0gp28rpF3xhdPwJzWeQ3Ga8d3gt1tPf8eIV/mbMvs+M1cw== X-Received: by 2002:a05:6a00:248b:b0:692:b539:28ff with SMTP id c11-20020a056a00248b00b00692b53928ffmr19360914pfv.24.1696989570062; Tue, 10 Oct 2023 18:59:30 -0700 (PDT) Received: from [10.54.24.52] ([143.92.118.3]) by smtp.gmail.com with ESMTPSA id m26-20020aa78a1a000000b0068fb783d0c6sm9125148pfa.141.2023.10.10.18.59.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 18:59:29 -0700 (PDT) Message-ID: <1a8ee686-e416-466b-4f6d-1dd26212b360@shopee.com> Date: Wed, 11 Oct 2023 09:59:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/2] memcg, oom: unmark under_oom after the oom killer is done To: Michal Hocko Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org References: <20230922070529.362202-1-haifeng.xu@shopee.com> <6b7af68c-2cfb-b789-4239-204be7c8ad7e@shopee.com> <94b7ed1d-9ca8-7d34-a0f4-c46bc995a3d2@shopee.com> <9b463e7e-4a89-f218-ec5c-7f6c16b685ea@shopee.com> From: Haifeng Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4916F1C0003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gr3sacwup995zcceeypin38njydfhxx9 X-HE-Tag: 1696989571-302704 X-HE-Meta: U2FsdGVkX18mWqByKzdQPZyY9wgDh6eBi2w+7aONnUstcKcDxrNlZkWBK/fX2hsP/zgJI3Ag/FWWHRxB7HYPCQOrKp/aLl99r41xkegfa4FtM6uiQvmPpS1pb0c5Mu04gfn4TQH6thvuynfHcbZonvmSCNyhfvXEXdvv4cDv/d6goSPJbt/QjgPsEn33KOkUSAkCHASX2ii/WR3BtM9GsDMEJ20fJzecJe9PahGhdWglIptaNidXot0ZKYdhg44QIikRW6w9dRHoGKVongKeZJ1SqJIA4xdv8kLIIwcQRd5lo6mi1PSaD9iiMqWBcpBY4OR8qZV5R0jmeVy/VP3h+LPpnqyv9HMzG7X+DgRxJeItczHUWgmT+O28qLgT+2qVBFoBl5lH39Wq78A01t3NsMRKMoF5j8PFNkywjSyTq2mmceNP2GosFNnlWjcqCphmEzzWgUWqUP7WZTvI0CVzayp9EKW+13qvNCUBHGhjCW1/gfGSHxAlI+y0/mwEe1+ecc0MWKGsuvTaAnlzDvvj3tFrfWa9/lLfU5D7uLsA2EeB3jl+SupnrqyBd0A8MnYhW3idiz+UqHpSvSFS3W2675EnftmeHkenVTkm3pZotcZ8N9YLNExGyH3RU+Uu8kf75US3P8tyvcBvUjVmBXHU6uO+acU+YZAoPgZCjFkD4j6ZfE0RoPPDYIR3fIIP5BZR5ckJxQ3Cu5iEZNNpYxI0TICLDydHBQ6FIeCFdts91qkIEGcfYibjtK3Td6xF+9mgeT1YZ7TezUbkkK3eeBrA6uqQpmfj743uOeg/VE/769Jb8m8nTR2huII+ghLbrxcpN2GSKdv2jqK8HivD7eLTeZQhIX6/NW8T1rlfJhYsd2s2cPdbcfzmGJ9am33J/qeNpepSefDsCdp3+JUqHdCA2+oW4iBoBmRRdSbkK7kCGuwjWpOm+OgWtE8yOnndLN+ZG/sSyf7qbzsy3hZONfx KvMtesgw FPlkCIJggrqZQ6KDWoI10l4KZVB7svzbvU7652Zym6kTL6J366JD1jryP1a268329OYzCUGlmb33N34r3BpwTVDPawySV4CxP+V+8LV52DwVAvUywkOltmeEZOJ5kqPfUQWxLsgtI9NmUDaItGmQEed52L+JaNZUusYJ6uGLmtst0RrBaNKZTTzzpoUEbeR68eGpKPWYS03uNJsbKApoH7u0WUWhabxclJyaraOeJwo7scYsizFJJ1w8jipLGnLd07lZfboqP1Fku6a5bHI3Ut1oFiueRBuKp70RYGPOF6724KKKoCVvO5jmlfQVd/IUUYnwnC1fpcQGUrp//pc+aPCsCJCRk+NLT+Zj5T3YiuOzpqMA22uJUJ+wmtuv/IurISPOT+NOe8KdzXIPnoiW0BXPDEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/3 15:50, Michal Hocko wrote: > On Thu 28-09-23 11:03:23, Haifeng Xu wrote: > [...] >>>> for example, we want to run processes in the group but those parametes related to >>>> memory allocation is hard to decide, so use the notifications to inform us that we >>>> need to adjust the paramters automatically and we don't need to create the new processes >>>> manually. >>> >>> I do understand that but OOM is just way too late to tune anything >>> upon. Cgroup v2 has a notion of high limit which can throttle memory >>> allocations way before the hard limit is set and this along with PSI >>> metrics could give you a much better insight on the memory pressure >>> in a memcg. >>> >> >> Thank you for your suggestion. We will try to use memory.high instead. > > OK, is the patch still required? Yes As I've said I am not strongly opposed, > it is just that the justification is rather weak. >