From: Haifeng Xu <haifeng.xu@shopee.com>
To: Michal Hocko <mhocko@suse.com>
Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev,
shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] memcg, oom: unmark under_oom after the oom killer is done
Date: Wed, 11 Oct 2023 09:59:25 +0800 [thread overview]
Message-ID: <1a8ee686-e416-466b-4f6d-1dd26212b360@shopee.com> (raw)
In-Reply-To: <ZRvH2UzJ+VlP/12q@dhcp22.suse.cz>
On 2023/10/3 15:50, Michal Hocko wrote:
> On Thu 28-09-23 11:03:23, Haifeng Xu wrote:
> [...]
>>>> for example, we want to run processes in the group but those parametes related to
>>>> memory allocation is hard to decide, so use the notifications to inform us that we
>>>> need to adjust the paramters automatically and we don't need to create the new processes
>>>> manually.
>>>
>>> I do understand that but OOM is just way too late to tune anything
>>> upon. Cgroup v2 has a notion of high limit which can throttle memory
>>> allocations way before the hard limit is set and this along with PSI
>>> metrics could give you a much better insight on the memory pressure
>>> in a memcg.
>>>
>>
>> Thank you for your suggestion. We will try to use memory.high instead.
>
> OK, is the patch still required?
Yes
As I've said I am not strongly opposed,
> it is just that the justification is rather weak.
>
next prev parent reply other threads:[~2023-10-11 1:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 7:05 Haifeng Xu
2023-09-22 23:17 ` Roman Gushchin
2023-09-23 8:05 ` Haifeng Xu
2023-09-25 7:57 ` Michal Hocko
2023-09-25 9:03 ` Haifeng Xu
2023-09-25 11:38 ` Michal Hocko
2023-09-25 12:28 ` Haifeng Xu
2023-09-25 12:37 ` Michal Hocko
2023-09-26 14:39 ` Haifeng Xu
2023-09-27 13:36 ` Michal Hocko
2023-09-28 3:03 ` Haifeng Xu
2023-10-03 7:50 ` Michal Hocko
2023-10-11 1:59 ` Haifeng Xu [this message]
2023-10-25 21:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a8ee686-e416-466b-4f6d-1dd26212b360@shopee.com \
--to=haifeng.xu@shopee.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox