From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEABC47258 for ; Thu, 25 Jan 2024 09:22:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 947A16B00AD; Thu, 25 Jan 2024 04:22:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FA136B00AE; Thu, 25 Jan 2024 04:22:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 799666B00AF; Thu, 25 Jan 2024 04:22:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6114A6B00AD for ; Thu, 25 Jan 2024 04:22:22 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 34E9F803BB for ; Thu, 25 Jan 2024 09:22:22 +0000 (UTC) X-FDA: 81717292524.15.6028CBB Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf12.hostedemail.com (Postfix) with ESMTP id 24CF840012 for ; Thu, 25 Jan 2024 09:22:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="SlbG/w+2"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706174540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rq+n81SPFVBRVsOq1GkIa0O+TpyvfNFLv7fPMxY8cNU=; b=fSHYdeNc5tfJbEgxD/+GS8DGd+wspxd3iD6/U/qPB5Fk6D5a0uq1HfKgLoVuRP3HXoowya cGaMogBErMB2y2tqJ/dpPRoK0G8d3gC2KTU2ZTzXhgMmDkPeCCa4iBZKRMOOXUHZUIAK8c WQzsIcmRBDmRx1WJWU2x0lqidYEbugc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="SlbG/w+2"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706174540; a=rsa-sha256; cv=none; b=3F/I5hkEhgIFhxfxCewatfOR65wKcxonS4djcc4Tm5woLq37khamlhuUQu6g/UJBzAdmjG vF8SyUBuXHljFrDQbhmw/H95B+FAqvJJvfN1NQheamCrodFB9OLNyOPYF9r6xbA2NFOOhA GxcrRqvL0JzYxl6P/95fFsAcfos3RcM= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d74045c463so31719065ad.3 for ; Thu, 25 Jan 2024 01:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706174538; x=1706779338; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rq+n81SPFVBRVsOq1GkIa0O+TpyvfNFLv7fPMxY8cNU=; b=SlbG/w+2z79ki6U+BwmJK2Wnki8yBwo+sHDBBSUopcVgoamWlpLXmnWAWp7DzKgfWr tbQTolLgH53rtd9DaXMkh5O0SvCNiYYArtNi4KMCjfr/1x+biAkW4BKiyeS+qgn0Z9Jj 5E4PVhZ2wyhcbBuIXxgijPILyMyuGbgtQKuf7kaiK4uTkwnC3rAzkYIdYyhUbFDd5iDB ak3Z06j2tiqbTN57UgMjH/ilLolZq3fIxKOiypZL/3kmUmPeIuqRW3ywASlm8foulFfQ lITGcaCLXQEdIytgJ4ymSBSq/OUHqgom4oWZ3RDqsj7d5LEYVRMu/N7OVKp0q8I07Fd4 AdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706174538; x=1706779338; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rq+n81SPFVBRVsOq1GkIa0O+TpyvfNFLv7fPMxY8cNU=; b=G1JATU/fl/ZMFWWzj3F1sGxQrS6pyKpyLoMUOFhiUtUfGjFGABj6ihxiefgSvv8j1Z ocx5g91H5gkScLnvak+tmNSqYYh5kU54QoBH4KgjK6M+IraMDR6E4BtuCP0ofwun6qLs LQ55al4JRLyFBx0LT2sAPAAOKxeguaTKmoMor+9RkpzWYHMNo38pucyhECY9CtD6Wnkr ZYw+dun1To6gpfazcPcwlDHo9Yc2nhOVGmYhHO4YUlUFxYyeujoV8UnVvPk8Lkyl7auo mEQD9gcxMx15Kjik4bLyckUhVw5RdXLxXacmKpEqJS/FdErClNJGZdv2jNUPY4ahJzxW SIdA== X-Gm-Message-State: AOJu0Yw4PUWCX7fG4Eo1aPpwJzHJjj5nH824QFYrs2IhZE3EwdeHTffa azlKzt6FpiDkQWIvF40KWwtGiXsZiqe2QVwz7S5aLT4cqDwiF1KI87J0ghtMvzdU7Gcucu04wF2 j X-Google-Smtp-Source: AGHT+IFQhOc40F1lW2QjAs6bYcA2acCY8Wc8ukNCbhIQYDrjBJLwkHKymF0NX/i1Wa4iZS8mLSBy9g== X-Received: by 2002:a17:902:ea94:b0:1d7:91ae:6dde with SMTP id x20-20020a170902ea9400b001d791ae6ddemr580819plb.13.1706174537732; Thu, 25 Jan 2024 01:22:17 -0800 (PST) Received: from [10.4.195.141] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id n4-20020a170902968400b001d7859ea961sm2237083plp.272.2024.01.25.01.22.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 01:22:17 -0800 (PST) Message-ID: <1a8a513f-fa84-41ca-b7f4-62726e78fd31@bytedance.com> Date: Thu, 25 Jan 2024 17:22:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: zswap: remove unnecessary tree cleanups in zswap_swapoff() Content-Language: en-US To: Yosry Ahmed Cc: Johannes Weiner , Andrew Morton , Nhat Pham , Chris Li , Huang Ying , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240120024007.2850671-1-yosryahmed@google.com> <20240120024007.2850671-3-yosryahmed@google.com> <20240122201906.GA1567330@cmpxchg.org> <20240123153851.GA1745986@cmpxchg.org> <20240123201234.GC1745986@cmpxchg.org> <1496dce3-a4bb-4ccf-92d6-701a45b67da3@bytedance.com> <35c3b0e5-a5eb-44b2-aa7d-3167f4603c73@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 24CF840012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: prxj7zjd1n46ug1gg33fgcfx6bdaifry X-HE-Tag: 1706174538-957799 X-HE-Meta: U2FsdGVkX19Y17scT2wfUVprfEr2eXXAgV0bEr5I+q8BjjQrFF+XQquJV0s5rquzZ0B3y484H3uZzMyc9w2acvdvIKgfBXKKJ0h87EXfnZ01nERHWycexGZ9rBEZ5qqcnu/T9O0iX8nOZ3xPkAB/n/Ix6jdxARICmlyx7hsj/A0hIyOXICymnk85aY/PIwdajI80LzW9yqD9ymVcqMSlEG7ONwRZgxXYEmAUAWuBj7ONqkT/EfwPOAnMIycJwnG0gVJkZhL7cTEf8fYG0KxTxFDtsaVQNKj8vHLTFR/S+VX95KtVjBePChBT5LCancma8Zx7sj7mNN/7T0qVASNULv0aCPmIBFWvaiy1a/ihQpBw+wH6bk98OaL3YE74hI8nc5cBPXmpW5wM0p+TjUJcHheem9/ksX4qS6wao3iHFGb3UlcbfJQl1ul8JNipblC9tFQ60mUmwXenTY2dzrxa/FrYDFedU07eXHsyTCJyzAiW1uUkD3h+B3bac6UWonPpGN7UMQw7QqcVKmtMpsVafiATEWpjRc6INfGZNQjGe3/lqrnXKILrFJ0rec4ICBI9V//6o0XcLFPWyos4C1qQKVTM6ddAFgocGcmG2fG2aeQQc/lNLBjaioqPnhj6i7VZvlq8NX+Oov4P8wOoXL2j/snjyOZSeSecDbeGY5ZuzEdUCfvBfLubWU978H2bzEoiw58xaVciwYcBfRABBPmBJt1hk7nAUBjXkyRkjGqInpmtNTeOWHjSs8TotjQXs+1C7G8/0+KzcexKXcOVTdFreTOe9q5sK4lWVMocHPKDHxg7OSRgcutabO8HlUDzZo9YLNv0pWk/lmF/4H9Xhiz9zweT7alGp1uoRmNObC3/U8RFs88gY8zwzl0VY1qfAnospiGBzBQKUN0ab4a7r67ZtGVHg4Fzb7tQNTPWAy3UpV9Et8ufCvW0Wl7uzsTxJPmifngts9b2naEXrAUlcXu /P4ceoHJ Bcv4dMr3jVbkaSR0WET1Y3Upl5mhayPIzIeevpsniFGxf8NyzFN4jOEArjE6tn+b6DQuu2oyjM1sYvpfhfGENHB7nZG1lOJSzTDZfS4rt37tLiWZaTjDBMv/37SCkhWwH2++ZNb1KEdYh0pIoZNOjE4bEJb7nIxtJ4lPhkNNFB5oFQGucTMhG50Dplw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/25 17:03, Yosry Ahmed wrote: >>>>>> The second difference is the handling of lru entry, which is easy that we >>>>>> just zswap_lru_del() in tree lock. >>>>> >>>>> Why do we need zswap_lru_del() at all? We should have already isolated >>>>> the entry at that point IIUC. >>>> >>>> I was thinking how to handle the "zswap_lru_putback()" if not writeback, >>>> in which case we can't use the entry actually since we haven't got reference >>>> of it. So we can don't isolate at the entry, and only zswap_lru_del() when >>>> we are going to writeback actually. >>> >>> Why not just call zswap_lru_putback() before we unlock the folio? >> >> When early return because __read_swap_cache_async() return NULL or !folio_was_allocated, >> we don't have a locked folio yet. The entry maybe invalidated and freed concurrently. > > Oh, that path, right. > > If we don't isolate the entry straightaway, concurrent reclaimers will > see the same entry, call __read_swap_cache_async(), find the folio > already in the swapcache and stop shrinking. This is because usually > this means we are racing with swapin and hitting the warmer part of > the zswap LRU. > > I am not sure if this would matter in practice, maybe Nhat knows > better. Perhaps we can rotate the entry in the LRU before calling > __read_swap_cache_async() to minimize the chances of such a race? Or > we can serialize the calls to __read_swap_cache_async() but this may > be an overkill. Also, not sure, rotate the entry maybe good IMHO since we will zswap_lru_del() once we checked the invalidate race.